All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Austin Kim <austindh.kim@gmail.com>,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	x86@kernel.org, dvhart@infradead.org, andy@infradead.org,
	hpa@zytor.com, allison@lohutok.net, armijn@tjaldur.nl,
	kjlu@umn.edu, platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/platform/uv: move kmalloc() NULL check routine
Date: Fri, 6 Sep 2019 12:53:52 +0200	[thread overview]
Message-ID: <20190906105352.GA8656@kroah.com> (raw)
In-Reply-To: <20190906104341.GW2349@hirez.programming.kicks-ass.net>

On Fri, Sep 06, 2019 at 12:43:41PM +0200, Peter Zijlstra wrote:
> On Fri, Sep 06, 2019 at 11:32:52AM +0200, Greg KH wrote:
> > On Fri, Sep 06, 2019 at 08:29:51AM +0900, Austin Kim wrote:
> > > The result of kmalloc should have been checked ahead of below statement:
> > > 	pqp = (struct bau_pq_entry *)vp;
> > > 
> > > Move BUG_ON(!vp) before above statement.
> > > 
> > > Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> > > ---
> > >  arch/x86/platform/uv/tlb_uv.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
> > > index 20c389a..5f0a96bf 100644
> > > --- a/arch/x86/platform/uv/tlb_uv.c
> > > +++ b/arch/x86/platform/uv/tlb_uv.c
> > > @@ -1804,9 +1804,9 @@ static void pq_init(int node, int pnode)
> > >  
> > >  	plsize = (DEST_Q_SIZE + 1) * sizeof(struct bau_pq_entry);
> > >  	vp = kmalloc_node(plsize, GFP_KERNEL, node);
> > > -	pqp = (struct bau_pq_entry *)vp;
> > > -	BUG_ON(!pqp);
> > > +	BUG_ON(!vp);
> > 
> > Ick!  Don't crash the whole machine if you are out of memory, that's a
> > totally lazy and broken driver.  Fix this up properly please.
> 
> This is boot time init; if memory allocation fails, we're in trouble, no
> way forward no way back.
> 
> It is not uncommon to have BUG_ON() for alloc failing during boot.

Hey, how come you get to get away with this here, and in the tty layer I
had to do all sorts of foolish things just for the same "impossible"
thing because syzbot found a way to emulate such lunacy?

Just you wait until the fuzzers get ahold of this code...  :)

greg k-h

      reply	other threads:[~2019-09-06 10:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05 23:29 Austin Kim
2019-09-05 23:29 ` Austin Kim
2019-09-06  9:32 ` Greg KH
2019-09-06 10:43   ` Peter Zijlstra
2019-09-06 10:53     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190906105352.GA8656@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=allison@lohutok.net \
    --cc=andy@infradead.org \
    --cc=armijn@tjaldur.nl \
    --cc=austindh.kim@gmail.com \
    --cc=bp@alien8.de \
    --cc=dvhart@infradead.org \
    --cc=hpa@zytor.com \
    --cc=kjlu@umn.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH] x86/platform/uv: move kmalloc() NULL check routine' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.