From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
darcari@redhat.com, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket
Date: Fri, 6 Sep 2019 16:46:55 +0300 [thread overview]
Message-ID: <20190906134655.GU2680@smile.fi.intel.com> (raw)
In-Reply-To: <780a3faf-9e44-64f4-a354-bdee39af3af5@redhat.com>
On Fri, Sep 06, 2019 at 05:39:54AM -0400, Prarit Bhargava wrote:
> On 9/5/19 7:37 PM, Srinivas Pandruvada wrote:
> > Read the bucket and core count relationship via MSR and display
> > when displaying turbo ratio limits.
> > + ret = isst_send_msr_command(cpu, 0x1ae, 0, buckets_info);
>
> ^^^ you can get rid of the magic number 0x1ae by doing (sorry for the cut-and-paste)
>
> diff --git a/tools/power/x86/intel-speed-select/Makefile b/tools/power/x86/intel
> index 12c6939dca2a..087d802ad844 100644
> --- a/tools/power/x86/intel-speed-select/Makefile
> +++ b/tools/power/x86/intel-speed-select/Makefile
> @@ -15,6 +15,8 @@ endif
> MAKEFLAGS += -r
>
> override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include
> +override CFLAGS += -I../../../include
> +override CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"'
I guess it can be done in more neat way.
> As I've been looking at this code I have been wondering why didn't you just use
> the standard /dev/cpu/X/msr interface that other x86 power utilities (turbostat,
> x86_energy_perf_policy) use? Implementing msr_read() is trivial (warning
> untested and uncompiled code)
Actually good point!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-09-06 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 23:37 [PATCH 1/2] platform/x86: ISST: Allow additional TRL MSRs Srinivas Pandruvada
2019-09-05 23:37 ` [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket Srinivas Pandruvada
2019-09-06 9:39 ` Prarit Bhargava
2019-09-06 13:46 ` Andy Shevchenko [this message]
2019-09-06 14:50 ` Srinivas Pandruvada
2019-09-06 15:07 ` Srinivas Pandruvada
2019-09-07 18:18 ` Andy Shevchenko
2019-09-08 9:46 ` Prarit Bhargava
2019-09-08 14:13 ` Srinivas Pandruvada
2019-09-08 14:43 ` Srinivas Pandruvada
2019-09-09 10:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906134655.GU2680@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=darcari@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.