From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D060C43331 for ; Fri, 6 Sep 2019 23:48:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DD3F214E0 for ; Fri, 6 Sep 2019 23:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567813702; bh=NSLywlCOcgcWPM52MbfyuhWTAOW2/4du9FX0KFp7RSI=; h=In-Reply-To:References:Cc:To:From:Subject:Date:List-ID:From; b=xW1pCkfRfLOJMxatTSTpamBNUZa7d8hBSFMBP3iEBIAYsa62UwuJbFr4HUccNOXLK ppYw/kN+MxQQBX7RZ9utWJx4AOuxijgfvkEfWrJWvowRJXNlyOMRJmQKqvUfU+8Qki TDJTcvJwjUq0/TxV2OuTzNyjyDOhWCsrCXeLFJbM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406236AbfIFXsU (ORCPT ); Fri, 6 Sep 2019 19:48:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:42622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405441AbfIFXsT (ORCPT ); Fri, 6 Sep 2019 19:48:19 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC0DA20842; Fri, 6 Sep 2019 23:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567813699; bh=NSLywlCOcgcWPM52MbfyuhWTAOW2/4du9FX0KFp7RSI=; h=In-Reply-To:References:Cc:To:From:Subject:Date:From; b=KwtHGJhGEM4BfLeqXjbsZT07sFB7biEeHKuQ9ohRGYNIP+wMSmwfyp48kbdV4SUug 9M91UWABZNoGL2ftCmjs/VA0iuLyajB//EFiauZlmyBqMSnWqUAU5XYGAqo9yY+2fj yelyGsFZ9lWHC9sKK4riqUF9SI/AwZEQtDSQvrHU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190830220743.439670-12-lkundrak@v3.sk> References: <20190830220743.439670-1-lkundrak@v3.sk> <20190830220743.439670-12-lkundrak@v3.sk> Cc: "Cc : Rob Herring" , Mark Rutland , Thomas Gleixner , Jason Cooper , Kishon Vijay Abraham I , Russell King , Michael Turquette , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Lubomir Rintel To: "To : Olof Johansson" , Lubomir Rintel From: Stephen Boyd Subject: Re: [PATCH v3 11/16] ARM: mmp: add support for MMP3 SoC User-Agent: alot/0.8.1 Date: Fri, 06 Sep 2019 16:48:18 -0700 Message-Id: <20190906234818.EC0DA20842@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Lubomir Rintel (2019-08-30 15:07:38) > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 801fa1cd03217..8bb2ac83a1fcc 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -301,6 +301,11 @@ config COMMON_CLK_STM32H7 > ---help--- > Support for stm32h7 SoC family clocks > =20 > +config COMMON_CLK_MMP2 > + def_bool COMMON_CLK && (MACH_MMP2_DT || MACH_MMP3_DT) Does it need to depend on COMMON_CLK? I thought that by being part of the menuconfig (even if it's a hidden symbol) mean that it wouldn't be evaulated unless the COMMON_CLK define is =3DY. > + help > + Support for Marvell MMP2 and MMP3 SoC clocks > + > config COMMON_CLK_BD718XX > tristate "Clock driver for ROHM BD718x7 PMIC" > depends on MFD_ROHM_BD718XX || MFD_ROHM_BD70528 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v3 11/16] ARM: mmp: add support for MMP3 SoC Date: Fri, 06 Sep 2019 16:48:18 -0700 Message-ID: <20190906234818.EC0DA20842@mail.kernel.org> References: <20190830220743.439670-1-lkundrak@v3.sk> <20190830220743.439670-12-lkundrak@v3.sk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190830220743.439670-12-lkundrak@v3.sk> Sender: linux-kernel-owner@vger.kernel.org To: "To : Olof Johansson" Cc: "Cc : Rob Herring" , Mark Rutland , Thomas Gleixner , Jason Cooper , Kishon Vijay Abraham I , Russell King , Michael Turquette , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Lubomir Rintel List-Id: devicetree@vger.kernel.org Quoting Lubomir Rintel (2019-08-30 15:07:38) > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 801fa1cd03217..8bb2ac83a1fcc 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -301,6 +301,11 @@ config COMMON_CLK_STM32H7 > ---help--- > Support for stm32h7 SoC family clocks > =20 > +config COMMON_CLK_MMP2 > + def_bool COMMON_CLK && (MACH_MMP2_DT || MACH_MMP3_DT) Does it need to depend on COMMON_CLK? I thought that by being part of the menuconfig (even if it's a hidden symbol) mean that it wouldn't be evaulated unless the COMMON_CLK define is =3DY. > + help > + Support for Marvell MMP2 and MMP3 SoC clocks > + > config COMMON_CLK_BD718XX > tristate "Clock driver for ROHM BD718x7 PMIC" > depends on MFD_ROHM_BD718XX || MFD_ROHM_BD70528 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 025E0C43331 for ; Fri, 6 Sep 2019 23:48:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA73F214E0 for ; Fri, 6 Sep 2019 23:48:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SAC1ZoFd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="KwtHGJhG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA73F214E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xoKJtK5i2Gh/pUQBSGa3X/WRcsfJUf7qpx1E/uGbSis=; b=SAC1ZoFdqvc2oR OZV/HHVxb6HBNju1qnTsJGfwIK5p28Oh04D39ZtXz+LGzUYqPZEcO+N7Ofk0HVyo91QBGPFlVwpCZ s7BrzB2nUwULkQyJTjaXVvZzQPuBz7Tq3BxcdW4wYeBpFFGX9st8yzqyPU/gDtiirtG3xtVjIJFM3 DRAOFSagSBY3MRuqn7vswwr2yw3Kmq2/b/irIifBwCc14ct9Yd58rmpUnBduTqkBzn5cpAU4WTLSl kh0GsMXdVJBflmEBv4tkyrwUi5EB2y3FaZyL076FmnU6YmfS979x66RBq6sg6us4A2LIxGCXDNkGL YZ3t9DS+ZQ/UenXFnJ4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i6Nxm-0004wX-Hz; Fri, 06 Sep 2019 23:48:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i6Nxj-0004w8-U5 for linux-arm-kernel@lists.infradead.org; Fri, 06 Sep 2019 23:48:21 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC0DA20842; Fri, 6 Sep 2019 23:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567813699; bh=NSLywlCOcgcWPM52MbfyuhWTAOW2/4du9FX0KFp7RSI=; h=In-Reply-To:References:Cc:To:From:Subject:Date:From; b=KwtHGJhGEM4BfLeqXjbsZT07sFB7biEeHKuQ9ohRGYNIP+wMSmwfyp48kbdV4SUug 9M91UWABZNoGL2ftCmjs/VA0iuLyajB//EFiauZlmyBqMSnWqUAU5XYGAqo9yY+2fj yelyGsFZ9lWHC9sKK4riqUF9SI/AwZEQtDSQvrHU= MIME-Version: 1.0 In-Reply-To: <20190830220743.439670-12-lkundrak@v3.sk> References: <20190830220743.439670-1-lkundrak@v3.sk> <20190830220743.439670-12-lkundrak@v3.sk> To: "To : Olof Johansson" , Lubomir Rintel From: Stephen Boyd Subject: Re: [PATCH v3 11/16] ARM: mmp: add support for MMP3 SoC User-Agent: alot/0.8.1 Date: Fri, 06 Sep 2019 16:48:18 -0700 Message-Id: <20190906234818.EC0DA20842@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190906_164819_997357_86E57F01 X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Jason Cooper , linux-kernel@vger.kernel.org, Michael Turquette , Russell King , Kishon Vijay Abraham I , Lubomir Rintel , "Cc : Rob Herring" , Thomas Gleixner , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Lubomir Rintel (2019-08-30 15:07:38) > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 801fa1cd03217..8bb2ac83a1fcc 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -301,6 +301,11 @@ config COMMON_CLK_STM32H7 > ---help--- > Support for stm32h7 SoC family clocks > > +config COMMON_CLK_MMP2 > + def_bool COMMON_CLK && (MACH_MMP2_DT || MACH_MMP3_DT) Does it need to depend on COMMON_CLK? I thought that by being part of the menuconfig (even if it's a hidden symbol) mean that it wouldn't be evaulated unless the COMMON_CLK define is =Y. > + help > + Support for Marvell MMP2 and MMP3 SoC clocks > + > config COMMON_CLK_BD718XX > tristate "Clock driver for ROHM BD718x7 PMIC" > depends on MFD_ROHM_BD718XX || MFD_ROHM_BD70528 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel