From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hillf Danton Subject: Re: Xorg indefinitely hangs in kernelspace Date: Mon, 9 Sep 2019 15:13:48 +0800 Message-ID: <20190909082313.0303E8995F@gabe.freedesktop.org> References: <20190906055322.17900-1-hdanton@sina.com> <20190909055219.q44k27cczwkuio3z@sirius.home.kraxel.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0291912722==" Return-path: In-Reply-To: <20190909055219.q44k27cczwkuio3z@sirius.home.kraxel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spice-devel-bounces@lists.freedesktop.org Sender: "Spice-devel" To: Gerd Hoffmann Cc: David Airlie , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "virtualization@lists.linux-foundation.org" , Daniel Vetter , "spice-devel@lists.freedesktop.org" , Jaak Ristioja , Dave Airlie List-Id: dri-devel@lists.freedesktop.org --===============0291912722== Content-Type: multipart/alternative; boundary="_AD05A452-BEFD-47CB-8E14-119A02D5DF11_" --_AD05A452-BEFD-47CB-8E14-119A02D5DF11_ Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi, On Mon, 9 Sep 2019 from Gerd Hoffmann > > Hmm, I think the patch is wrong. As far I know it is the qxl drivers's > job to call ttm_eu_backoff_reservation(). Doing that automatically in > ttm will most likely break other ttm users. > Perhaps. >So I guess the call is missing in the qxl driver somewhere, most likely >in some error handling code path given that this bug is a relatively >rare event. > >There is only a single ttm_eu_reserve_buffers() call in qxl. >So how about this? > No preference in either way if it is a right cure. BTW a quick peep at the mainline tree shows not every ttm_eu_reserve_buffers() pairs with ttm_eu_backoff_reservation() without qxl being taken in account. Hillf --_AD05A452-BEFD-47CB-8E14-119A02D5DF11_ Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8"

Hi,

On Mon, 9 Sep 2019 from Gerd Hoffmann <k= raxel@redhat.com>

>

> Hmm, I think the patch is wrong.=C2=A0 As far I know it is the q= xl drivers's

> job to = call ttm_eu_backoff_reservation().=C2=A0 Doing that automatically in=

> ttm will most likely break= other ttm users.

>

Perhaps.

>So I guess the call is missin= g in the qxl driver somewhere, most likely

<= span lang=3DEN-US>>in some error handling code path given that this bug = is a relatively

>rare = event.

>

>There is only a s= ingle ttm_eu_reserve_buffers() call in qxl.

= >So how about this?

>

No preference in either way if it is a right cure.

=

BTW a quick peep at the mainline tree show= s not every

ttm_eu_reserv= e_buffers() pairs with ttm_eu_backoff_reservation()

without qxl being taken in account.

=

Hillf

= --_AD05A452-BEFD-47CB-8E14-119A02D5DF11_-- --===============0291912722== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KU3BpY2UtZGV2 ZWwgbWFpbGluZyBsaXN0ClNwaWNlLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3NwaWNlLWRldmVs --===============0291912722==--