From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5245BC4740A for ; Mon, 9 Sep 2019 11:12:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1884A2089F for ; Mon, 9 Sep 2019 11:12:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BkQbGtCL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730250AbfIILMT (ORCPT ); Mon, 9 Sep 2019 07:12:19 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:34948 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730703AbfIILMS (ORCPT ); Mon, 9 Sep 2019 07:12:18 -0400 Received: by mail-wr1-f67.google.com with SMTP id g7so13406579wrx.2 for ; Mon, 09 Sep 2019 04:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=r0cqelu1CHocdn9tAl3rxNNP2PFx49WcLGnntUDmH00=; b=BkQbGtCLTXPp+0ahNqGnKkBg9mw1KDONv/V/dovinCIjnlFHwTGsyK8iWoB9FnIpMw 8TKZ2mMZ622pGuvFHAW5ZIMPEzo5HHE/eJMai7lsyTdSu6i8fx/Qog4gpYYQaZire8J4 acRrOqaYGh3x1Ou+o7UsSmuOR5yevYuqFSgDv9JydXEOD7RQvEB4Cql8uUEon6IR1MHb 8gGKs4cDvaodT+IW0I03i+zZCZhYEYVzKD1KJGIOu1I/FE8Fe1XPRj9g+z2RkKcaYe6R Uhrop5P4MrMzUgcEhuLGfr3DKNWxVhulxq1ndBupq6OJEuJpWq60u8AVxWzYwdBKfIMp L7rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=r0cqelu1CHocdn9tAl3rxNNP2PFx49WcLGnntUDmH00=; b=EWEN6WdJ+sc8fcoAYa0J5f4YaMfbWSVEOg13QtimZvamj3SAy5hnZCEZGto+iMcAFo y9dR5qCy8ols3MTJ5nN6L5fm0Vfg/gGXKUcql6w5QEzax3P1xcbcrGB9CSPHJ5FZbGh5 JwZW5nv6LMHk7zXreic8p3oP8m9419x6uGIvBKS3Jhk5Qwb6fw6jdZMuPHGHNjhbYJfr 4nsFFVcNkQoy0R6GT1IhaQD8R00hziCPO9krNNbQVZA+9Q05SIM5BqqP7StaqBaGoOLo az6Y9NrVIEse2XAyYYFxx2idaf+6yPlXkreZ9m9yffvInpxgX6knpYBMeQXemcHwocdy LX2g== X-Gm-Message-State: APjAAAV3R73uyl8I1InDMe4kn9lhfvNhh0QAQNHKamAmW9xeGdfKH8Cj Kw3i6HlBHqJVGQ3bSoOh2m083w== X-Google-Smtp-Source: APXvYqzaBI0NkJdKnfne3ZbLfenHCgShMsft+MxAjXo4pydOyPT+jtolAEOiXuPQUOi3pKczahHhYA== X-Received: by 2002:adf:d1a4:: with SMTP id w4mr19670272wrc.331.1568027535792; Mon, 09 Sep 2019 04:12:15 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id k6sm29499911wrg.0.2019.09.09.04.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Sep 2019 04:12:15 -0700 (PDT) Date: Mon, 9 Sep 2019 12:12:13 +0100 From: Daniel Thompson To: Jacek Anaszewski Cc: Lee Jones , Jean-Jacques Hiblot , pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, jingoohan1@gmail.com, dmurphy@ti.com, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com Subject: Re: [PATCH v4 0/4] Add a generic driver for LED-based backlight Message-ID: <20190909111213.objkrztpikruhgzi@holly.lan> References: <20190717141514.21171-1-jjhiblot@ti.com> <283d9044-df2d-b176-bea9-7e1520d9cf56@gmail.com> <20190722070620.GD8402@dell> <9cbd9cf6-3422-85df-885f-904f52e9cabd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Sun, Sep 08, 2019 at 06:17:50PM +0200, Jacek Anaszewski wrote: > On 7/22/19 11:23 PM, Jacek Anaszewski wrote: > > On 7/22/19 9:06 AM, Lee Jones wrote: > >> On Thu, 18 Jul 2019, Jacek Anaszewski wrote: > >> > >>> On 7/17/19 4:15 PM, Jean-Jacques Hiblot wrote: > >>>> This series aims to add a led-backlight driver, similar to pwm-backlight, > >>>> but using a LED class device underneath. > >>>> > >>>> A few years ago (2015), Tomi Valkeinen posted a series implementing a > >>>> backlight driver on top of a LED device: > >>>> https://patchwork.kernel.org/patch/7293991/ > >>>> https://patchwork.kernel.org/patch/7294001/ > >>>> https://patchwork.kernel.org/patch/7293981/ > >>>> > >>>> The discussion stopped because Tomi lacked the time to work on it. > >>>> > >>>> changes in v4: > >>>> - fix dev_err() messages and commit logs following the advices of Pavel > >>>> - cosmetic changes (indents, getting rid of "? 1 : 0" in > >>>> led_match_led_node()) > >>>> > >>>> changes in v3: > >>>> - dt binding: don't limit the brightness range to 0-255. Use the range of > >>>> the underlying LEDs. as a side-effect, all LEDs must now have the same > >>>> range > >>>> - driver: Adapt to dt binding update. > >>>> - driver: rework probe() for clarity and remove the remaining goto. > >>>> > >>>> changes in v2: > >>>> - handle more than one LED. > >>>> - don't make the backlight device a child of the LED controller. > >>>> - make brightness-levels and default-brightness-level optional > >>>> - removed the option to use a GPIO enable. > >>>> - removed the option to use a regulator. It should be handled by the LED > >>>> core > >>>> - don't make any change to the LED core (not needed anymore) > >>>> > >>>> Jean-Jacques Hiblot (2): > >>>> leds: Add managed API to get a LED from a device driver > >>>> dt-bindings: backlight: Add led-backlight binding > >>>> > >>>> Tomi Valkeinen (2): > >>>> leds: Add of_led_get() and led_put() > >>>> backlight: add led-backlight driver > >>>> > >>>> .../bindings/leds/backlight/led-backlight.txt | 28 ++ > >>>> drivers/leds/led-class.c | 92 ++++++ > >>>> drivers/video/backlight/Kconfig | 7 + > >>>> drivers/video/backlight/Makefile | 1 + > >>>> drivers/video/backlight/led_bl.c | 268 ++++++++++++++++++ > >>>> include/linux/leds.h | 6 + > >>>> 6 files changed, 402 insertions(+) > >>>> create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.txt > >>>> create mode 100644 drivers/video/backlight/led_bl.c > >>>> > >>> > >>> For the whole set: > >>> > >>> Acked-by: Jacek Anaszewski > >>> > >>> Lee - we need to create immutable branch for this set since there will > >>> be some interfering changes in the LED core in this cycle. > >>> > >>> I can create the branch and send the pull request once we will > >>> obtain the ack from Rob for DT bindings, unless you have other > >>> preference. > >> > >> We also require a review to be conducted by Daniel Thompson. > >> > >> After which, an immutable branch sounds like a good idea. I'd like to > >> create this myself if you don't mind. > > > > Sure, thanks. > > Unfortunately that hasn't happened and it will miss 5.4 merge window. > > Daniel, we need your ack for this patch set. Sorry for dropping the ball here. I'm afraid I couldn't ack since I spotted a bug but I have shared review feedback now! Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Subject: Re: [PATCH v4 0/4] Add a generic driver for LED-based backlight Date: Mon, 9 Sep 2019 12:12:13 +0100 Message-ID: <20190909111213.objkrztpikruhgzi@holly.lan> References: <20190717141514.21171-1-jjhiblot@ti.com> <283d9044-df2d-b176-bea9-7e1520d9cf56@gmail.com> <20190722070620.GD8402@dell> <9cbd9cf6-3422-85df-885f-904f52e9cabd@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B7C189B8F for ; Mon, 9 Sep 2019 11:12:17 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id d17so608400wrq.13 for ; Mon, 09 Sep 2019 04:12:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jacek Anaszewski Cc: mark.rutland@arm.com, jingoohan1@gmail.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, dmurphy@ti.com, pavel@ucw.cz, Jean-Jacques Hiblot , Lee Jones , linux-leds@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBTZXAgMDgsIDIwMTkgYXQgMDY6MTc6NTBQTSArMDIwMCwgSmFjZWsgQW5hc3pld3Nr aSB3cm90ZToKPiBPbiA3LzIyLzE5IDExOjIzIFBNLCBKYWNlayBBbmFzemV3c2tpIHdyb3RlOgo+ ID4gT24gNy8yMi8xOSA5OjA2IEFNLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPj4gT24gVGh1LCAxOCBK dWwgMjAxOSwgSmFjZWsgQW5hc3pld3NraSB3cm90ZToKPiA+Pgo+ID4+PiBPbiA3LzE3LzE5IDQ6 MTUgUE0sIEplYW4tSmFjcXVlcyBIaWJsb3Qgd3JvdGU6Cj4gPj4+PiBUaGlzIHNlcmllcyBhaW1z IHRvIGFkZCBhIGxlZC1iYWNrbGlnaHQgZHJpdmVyLCBzaW1pbGFyIHRvIHB3bS1iYWNrbGlnaHQs Cj4gPj4+PiBidXQgdXNpbmcgYSBMRUQgY2xhc3MgZGV2aWNlIHVuZGVybmVhdGguCj4gPj4+Pgo+ ID4+Pj4gQSBmZXcgeWVhcnMgYWdvICgyMDE1KSwgVG9taSBWYWxrZWluZW4gcG9zdGVkIGEgc2Vy aWVzIGltcGxlbWVudGluZyBhCj4gPj4+PiBiYWNrbGlnaHQgZHJpdmVyIG9uIHRvcCBvZiBhIExF RCBkZXZpY2U6Cj4gPj4+PiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzcyOTM5 OTEvCj4gPj4+PiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzcyOTQwMDEvCj4g Pj4+PiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzcyOTM5ODEvCj4gPj4+Pgo+ ID4+Pj4gVGhlIGRpc2N1c3Npb24gc3RvcHBlZCBiZWNhdXNlIFRvbWkgbGFja2VkIHRoZSB0aW1l IHRvIHdvcmsgb24gaXQuCj4gPj4+Pgo+ID4+Pj4gY2hhbmdlcyBpbiB2NDoKPiA+Pj4+IC0gZml4 IGRldl9lcnIoKSBtZXNzYWdlcyBhbmQgY29tbWl0IGxvZ3MgZm9sbG93aW5nIHRoZSBhZHZpY2Vz IG9mIFBhdmVsCj4gPj4+PiAtIGNvc21ldGljIGNoYW5nZXMgKGluZGVudHMsIGdldHRpbmcgcmlk IG9mICAiPyAxIDogMCIgaW4KPiA+Pj4+ICAgbGVkX21hdGNoX2xlZF9ub2RlKCkpCj4gPj4+Pgo+ ID4+Pj4gY2hhbmdlcyBpbiB2MzoKPiA+Pj4+IC0gZHQgYmluZGluZzogZG9uJ3QgbGltaXQgdGhl IGJyaWdodG5lc3MgcmFuZ2UgdG8gMC0yNTUuIFVzZSB0aGUgcmFuZ2Ugb2YKPiA+Pj4+ICAgdGhl IHVuZGVybHlpbmcgTEVEcy4gYXMgYSBzaWRlLWVmZmVjdCwgYWxsIExFRHMgbXVzdCBub3cgaGF2 ZSB0aGUgc2FtZQo+ID4+Pj4gICByYW5nZQo+ID4+Pj4gLSBkcml2ZXI6IEFkYXB0IHRvIGR0IGJp bmRpbmcgdXBkYXRlLgo+ID4+Pj4gLSBkcml2ZXI6IHJld29yayBwcm9iZSgpIGZvciBjbGFyaXR5 IGFuZCByZW1vdmUgdGhlIHJlbWFpbmluZyBnb3RvLgo+ID4+Pj4KPiA+Pj4+IGNoYW5nZXMgaW4g djI6Cj4gPj4+PiAtIGhhbmRsZSBtb3JlIHRoYW4gb25lIExFRC4KPiA+Pj4+IC0gZG9uJ3QgbWFr ZSB0aGUgYmFja2xpZ2h0IGRldmljZSBhIGNoaWxkIG9mIHRoZSBMRUQgY29udHJvbGxlci4KPiA+ Pj4+IC0gbWFrZSBicmlnaHRuZXNzLWxldmVscyBhbmQgZGVmYXVsdC1icmlnaHRuZXNzLWxldmVs IG9wdGlvbmFsCj4gPj4+PiAtIHJlbW92ZWQgdGhlIG9wdGlvbiB0byB1c2UgYSBHUElPIGVuYWJs ZS4KPiA+Pj4+IC0gcmVtb3ZlZCB0aGUgb3B0aW9uIHRvIHVzZSBhIHJlZ3VsYXRvci4gSXQgc2hv dWxkIGJlIGhhbmRsZWQgYnkgdGhlIExFRAo+ID4+Pj4gICBjb3JlCj4gPj4+PiAtIGRvbid0IG1h a2UgYW55IGNoYW5nZSB0byB0aGUgTEVEIGNvcmUgKG5vdCBuZWVkZWQgYW55bW9yZSkKPiA+Pj4+ Cj4gPj4+PiBKZWFuLUphY3F1ZXMgSGlibG90ICgyKToKPiA+Pj4+ICAgbGVkczogQWRkIG1hbmFn ZWQgQVBJIHRvIGdldCBhIExFRCBmcm9tIGEgZGV2aWNlIGRyaXZlcgo+ID4+Pj4gICBkdC1iaW5k aW5nczogYmFja2xpZ2h0OiBBZGQgbGVkLWJhY2tsaWdodCBiaW5kaW5nCj4gPj4+Pgo+ID4+Pj4g VG9taSBWYWxrZWluZW4gKDIpOgo+ID4+Pj4gICBsZWRzOiBBZGQgb2ZfbGVkX2dldCgpIGFuZCBs ZWRfcHV0KCkKPiA+Pj4+ICAgYmFja2xpZ2h0OiBhZGQgbGVkLWJhY2tsaWdodCBkcml2ZXIKPiA+ Pj4+Cj4gPj4+PiAgLi4uL2JpbmRpbmdzL2xlZHMvYmFja2xpZ2h0L2xlZC1iYWNrbGlnaHQudHh0 IHwgIDI4ICsrCj4gPj4+PiAgZHJpdmVycy9sZWRzL2xlZC1jbGFzcy5jICAgICAgICAgICAgICAg ICAgICAgIHwgIDkyICsrKysrKwo+ID4+Pj4gIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L0tjb25m aWcgICAgICAgICAgICAgICB8ICAgNyArCj4gPj4+PiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQv TWFrZWZpbGUgICAgICAgICAgICAgIHwgICAxICsKPiA+Pj4+ICBkcml2ZXJzL3ZpZGVvL2JhY2ts aWdodC9sZWRfYmwuYyAgICAgICAgICAgICAgfCAyNjggKysrKysrKysrKysrKysrKysrCj4gPj4+ PiAgaW5jbHVkZS9saW51eC9sZWRzLmggICAgICAgICAgICAgICAgICAgICAgICAgIHwgICA2ICsK PiA+Pj4+ICA2IGZpbGVzIGNoYW5nZWQsIDQwMiBpbnNlcnRpb25zKCspCj4gPj4+PiAgY3JlYXRl IG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9sZWRzL2JhY2ts aWdodC9sZWQtYmFja2xpZ2h0LnR4dAo+ID4+Pj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJz L3ZpZGVvL2JhY2tsaWdodC9sZWRfYmwuYwo+ID4+Pj4KPiA+Pj4KPiA+Pj4gRm9yIHRoZSB3aG9s ZSBzZXQ6Cj4gPj4+Cj4gPj4+IEFja2VkLWJ5OiBKYWNlayBBbmFzemV3c2tpIDxqYWNlay5hbmFz emV3c2tpQGdtYWlsLmNvbT4KPiA+Pj4KPiA+Pj4gTGVlIC0gd2UgbmVlZCB0byBjcmVhdGUgaW1t dXRhYmxlIGJyYW5jaCBmb3IgdGhpcyBzZXQgc2luY2UgdGhlcmUgd2lsbAo+ID4+PiBiZSBzb21l IGludGVyZmVyaW5nIGNoYW5nZXMgaW4gdGhlIExFRCBjb3JlIGluIHRoaXMgY3ljbGUuCj4gPj4+ Cj4gPj4+IEkgY2FuIGNyZWF0ZSB0aGUgYnJhbmNoIGFuZCBzZW5kIHRoZSBwdWxsIHJlcXVlc3Qg b25jZSB3ZSB3aWxsCj4gPj4+IG9idGFpbiB0aGUgYWNrIGZyb20gUm9iIGZvciBEVCBiaW5kaW5n cywgdW5sZXNzIHlvdSBoYXZlIG90aGVyCj4gPj4+IHByZWZlcmVuY2UuCj4gPj4KPiA+PiBXZSBh bHNvIHJlcXVpcmUgYSByZXZpZXcgdG8gYmUgY29uZHVjdGVkIGJ5IERhbmllbCBUaG9tcHNvbi4K PiA+Pgo+ID4+IEFmdGVyIHdoaWNoLCBhbiBpbW11dGFibGUgYnJhbmNoIHNvdW5kcyBsaWtlIGEg Z29vZCBpZGVhLiAgSSdkIGxpa2UgdG8KPiA+PiBjcmVhdGUgdGhpcyBteXNlbGYgaWYgeW91IGRv bid0IG1pbmQuCj4gPiAKPiA+IFN1cmUsIHRoYW5rcy4KPiAKPiBVbmZvcnR1bmF0ZWx5IHRoYXQg aGFzbid0IGhhcHBlbmVkIGFuZCBpdCB3aWxsIG1pc3MgNS40IG1lcmdlIHdpbmRvdy4KPiAKPiBE YW5pZWwsIHdlIG5lZWQgeW91ciBhY2sgZm9yIHRoaXMgcGF0Y2ggc2V0LgoKU29ycnkgZm9yIGRy b3BwaW5nIHRoZSBiYWxsIGhlcmUuCgpJJ20gYWZyYWlkIEkgY291bGRuJ3QgYWNrIHNpbmNlIEkg c3BvdHRlZCBhIGJ1ZyBidXQgSSBoYXZlIHNoYXJlZApyZXZpZXcgZmVlZGJhY2sgbm93IQoKCkRh bmllbC4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs