From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Veeraiyan Chidambaram <external.veeraiyan.c@de.adit-jv.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
<linux-usb@vger.kernel.org>,
Andrew Gabbasov <andrew_gabbasov@mentor.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: Re: [PATCH v2 1/3] usb: renesas_usbhs: enable DVSE interrupt
Date: Mon, 9 Sep 2019 15:05:25 +0200 [thread overview]
Message-ID: <20190909130525.GA19423@vmlxhi-102.adit-jv.com> (raw)
In-Reply-To: <1567771431-13235-1-git-send-email-external.veeraiyan.c@de.adit-jv.com>
Hi Veeraiyan,
On Fri, Sep 06, 2019 at 02:03:49PM +0200, Veeraiyan Chidambaram wrote:
> From: Eugeniu Rosca <erosca@de.adit-jv.com>
>
> Commit [1] enabled the possibility of checking the DVST (Device State
> Transition) bit of INTSTS0 (Interrupt Status Register 0) and calling
> the irq_dev_state() handler if the DVST bit is set. But neither
> commit [1] nor commit [2] actually enabled the DVSE (Device State
> Transition Interrupt Enable) bit in the INTENB0 (Interrupt Enable
> Register 0). As a consequence, irq_dev_state() handler is getting
> called as a side effect of other (non-DVSE) interrupts being fired,
> which definitely can't be relied upon, if DVST notifications are of
> any value.
>
> Why this doesn't hurt is because usbhsg_irq_dev_state() currently
> doesn't do much except of a dev_dbg(). Once more work is added to
> the handler (e.g. detecting device "Suspended" state and notifying
> other USB gadget components about it), enabling DVSE becomes a hard
> requirement. Do it in a standalone commit for better visibility and
> clear explanation.
>
> [1] f1407d5 ("usb: renesas_usbhs: Add Renesas USBHS common code")
> [2] 2f98382 ("usb: renesas_usbhs: Add Renesas USBHS Gadget")
>
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> ---
> v2: No change
> v1: https://patchwork.kernel.org/patch/10581479/
It looks like this series changes the patch order of v1.
Could you kindly stick to the original order? Many thanks.
--
Best Regards,
Eugeniu.
next prev parent reply other threads:[~2019-09-09 13:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 12:03 [PATCH v2 1/3] usb: renesas_usbhs: enable DVSE interrupt Veeraiyan Chidambaram
2019-09-06 12:03 ` [PATCH v2 2/3] usb: renesas_usbhs: simplify usbhs_status_get_device_state() Veeraiyan Chidambaram
2019-09-06 12:03 ` [PATCH v2 3/3] usb: renesas_usbhs: add suspend event support in gadget mode Veeraiyan Chidambaram
2019-09-09 7:05 ` Yoshihiro Shimoda
2019-09-09 7:02 ` [PATCH v2 1/3] usb: renesas_usbhs: enable DVSE interrupt Yoshihiro Shimoda
2019-09-09 9:55 ` Greg Kroah-Hartman
2019-09-09 11:04 ` veeraiyan chidambaram
2019-09-09 13:05 ` Eugeniu Rosca [this message]
2019-09-09 16:01 ` veeraiyan chidambaram
2019-11-18 10:24 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909130525.GA19423@vmlxhi-102.adit-jv.com \
--to=erosca@de.adit-jv.com \
--cc=andrew_gabbasov@mentor.com \
--cc=balbi@kernel.org \
--cc=external.veeraiyan.c@de.adit-jv.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=roscaeugeniu@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.