From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>
Subject: [Xen-devel] [PATCH v4 2/5] xen: add new CONFIG_DEBUG_LOCKS option
Date: Mon, 9 Sep 2019 16:31:31 +0200 [thread overview]
Message-ID: <20190909143134.15379-3-jgross@suse.com> (raw)
In-Reply-To: <20190909143134.15379-1-jgross@suse.com>
Instead of enabling debugging for debug builds only add a dedicated
Kconfig option for that purpose which defaults to DEBUG.
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
V2:
- rename to CONFIG_DEBUG_LOCKS (Jan Beulich)
---
xen/Kconfig.debug | 7 +++++++
xen/common/spinlock.c | 4 ++--
xen/include/xen/spinlock.h | 2 +-
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
index e10e314e25..1faaa3ba6a 100644
--- a/xen/Kconfig.debug
+++ b/xen/Kconfig.debug
@@ -51,6 +51,13 @@ config LOCK_PROFILE
You can use serial console to print (and reset) using 'l' and 'L'
respectively, or the 'xenlockprof' tool.
+config DEBUG_LOCKS
+ bool "Lock debugging"
+ default DEBUG
+ ---help---
+ Enable debugging features of lock handling. Some additional
+ checks will be performed when acquiring and releasing locks.
+
config PERF_COUNTERS
bool "Performance Counters"
---help---
diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c
index 1be1b5ebe6..79e70a9947 100644
--- a/xen/common/spinlock.c
+++ b/xen/common/spinlock.c
@@ -9,7 +9,7 @@
#include <asm/processor.h>
#include <asm/atomic.h>
-#ifndef NDEBUG
+#ifdef CONFIG_DEBUG_LOCKS
static atomic_t spin_debug __read_mostly = ATOMIC_INIT(0);
@@ -97,7 +97,7 @@ void spin_debug_disable(void)
atomic_dec(&spin_debug);
}
-#else /* defined(NDEBUG) */
+#else /* CONFIG_DEBUG_LOCKS */
#define check_lock(l) ((void)0)
#define check_barrier(l) ((void)0)
diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h
index 24405386a7..6da55e74a2 100644
--- a/xen/include/xen/spinlock.h
+++ b/xen/include/xen/spinlock.h
@@ -7,7 +7,7 @@
#define SPINLOCK_CPU_BITS 12
-#ifndef NDEBUG
+#ifdef CONFIG_DEBUG_LOCKS
union lock_debug {
uint16_t val;
#define LOCK_DEBUG_INITVAL 0xffff
--
2.16.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-09 14:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 14:31 [Xen-devel] [PATCH v4 0/5] enhance lock debugging Juergen Gross
2019-09-09 14:31 ` [Xen-devel] [PATCH v4 1/5] xen/spinlocks: in debug builds store cpu holding the lock Juergen Gross
2019-09-09 14:50 ` Jan Beulich
2019-09-09 14:56 ` Juergen Gross
2019-09-09 14:31 ` Juergen Gross [this message]
2019-09-09 14:31 ` [Xen-devel] [PATCH v4 3/5] xen: print lock profile info in panic() Juergen Gross
2019-09-09 14:31 ` [Xen-devel] [PATCH v4 4/5] xen: modify lock profiling interface Juergen Gross
2019-09-09 14:31 ` [Xen-devel] [PATCH v4 5/5] xen: add function name to lock profiling data Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909143134.15379-3-jgross@suse.com \
--to=jgross@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.