All of lore.kernel.org
 help / color / mirror / Atom feed
From: Murphy Zhou <xzhou@redhat.com>
To: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Cc: fstests@vger.kernel.org, darrick.wong@oracle.com
Subject: Re: [PATCH] generic/566:  skip this test if -f option is non-supported
Date: Tue, 10 Sep 2019 12:28:51 +0800	[thread overview]
Message-ID: <20190910042851.ybwqgmh2a4xue3f4@XZHOUW.usersys.redhat.com> (raw)
In-Reply-To: <1568024086-2151-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>

On Mon, Sep 09, 2019 at 06:14:46PM +0800, Yang Xu wrote:
> This test will use xfs_quota -f option, this option was introduced
> since xfsprogs v4.10.0-rc1. On old version, we should skip this case.

Tested and ack.

Thanks!

> 
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
>  tests/generic/566 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/566 b/tests/generic/566
> index e8491e54..173974ad 100755
> --- a/tests/generic/566
> +++ b/tests/generic/566
> @@ -34,6 +34,7 @@ _supported_os Linux
>  _supported_fs generic
>  _require_scratch
>  _require_quota
> +_require_xfs_quota_foreign
>  _require_user
>  
>  rm -f $seqres.full
> -- 
> 2.18.1
> 
> 
> 

  reply	other threads:[~2019-09-10  4:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09 10:14 [PATCH] generic/566: skip this test if -f option is non-supported Yang Xu
2019-09-10  4:28 ` Murphy Zhou [this message]
2019-09-09 22:11   ` [PATCH v2] generic/566: use _require_xfs_quota_foreign and remove -f option Yang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190910042851.ybwqgmh2a4xue3f4@XZHOUW.usersys.redhat.com \
    --to=xzhou@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=xuyang2018.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.