From: Hillf Danton <hdanton@sina.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: David Airlie <airlied@linux.ie>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"spice-devel@lists.freedesktop.org"
<spice-devel@lists.freedesktop.org>,
Jaak Ristioja <jaak@ristioja.ee>,
Dave Airlie <airlied@redhat.com>
Subject: Re: Xorg indefinitely hangs in kernelspace
Date: Mon, 9 Sep 2019 15:13:48 +0800 [thread overview]
Message-ID: <20190910065807.68D776E827@gabe.freedesktop.org> (raw)
In-Reply-To: <20190909055219.q44k27cczwkuio3z@sirius.home.kraxel.org>
[-- Attachment #1.1: Type: text/plain, Size: 750 bytes --]
Hi,
On Mon, 9 Sep 2019 from Gerd Hoffmann <kraxel@redhat.com>
>
> Hmm, I think the patch is wrong. As far I know it is the qxl drivers's
> job to call ttm_eu_backoff_reservation(). Doing that automatically in
> ttm will most likely break other ttm users.
>
Perhaps.
>So I guess the call is missing in the qxl driver somewhere, most likely
>in some error handling code path given that this bug is a relatively
>rare event.
>
>There is only a single ttm_eu_reserve_buffers() call in qxl.
>So how about this?
>
No preference in either way if it is a right cure.
BTW a quick peep at the mainline tree shows not every
ttm_eu_reserve_buffers() pairs with ttm_eu_backoff_reservation()
without qxl being taken in account.
Hillf
[-- Attachment #1.2: Type: text/html, Size: 6170 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-09-09 7:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 5:53 Xorg indefinitely hangs in kernelspace Hillf Danton
2019-09-06 20:27 ` [Spice-devel] " Frediano Ziglio
2019-09-06 20:27 ` Frediano Ziglio
2019-09-07 2:00 ` Hillf Danton
2019-09-07 2:00 ` Hillf Danton
2019-09-07 2:00 ` Hillf Danton
2019-09-07 2:00 ` [Spice-devel] " Hillf Danton
2019-09-09 5:52 ` Gerd Hoffmann
2019-09-09 5:52 ` Gerd Hoffmann
2019-09-09 7:13 ` Hillf Danton
2019-09-09 7:13 ` Hillf Danton
2019-09-09 7:13 ` Hillf Danton [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-09 12:12 Hillf Danton
2019-08-06 18:00 Jaak Ristioja
2019-09-05 7:14 ` Gerd Hoffmann
2019-09-05 7:14 ` Gerd Hoffmann
2019-09-05 12:34 ` Jaak Ristioja
2019-09-05 12:34 ` Jaak Ristioja
2019-09-24 9:12 ` Jaak Ristioja
2019-09-24 9:12 ` Jaak Ristioja
2019-09-05 7:14 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910065807.68D776E827@gabe.freedesktop.org \
--to=hdanton@sina.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jaak@ristioja.ee \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.