From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 10 Sep 2019 13:32:26 +0000 Subject: Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling Message-Id: <20190910133226.GD20699@kadam> List-Id: References: <20190904115057.GC4811@pendragon.ideasonboard.com> <20190904185507.GA3634@mwanda> <20190908160428.GA20115@ravnborg.org> In-Reply-To: <20190908160428.GA20115@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sam Ravnborg Cc: Laurent Pinchart , David Airlie , kernel-janitors@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Mark Brown , Thierry Reding On Sun, Sep 08, 2019 at 06:04:28PM +0200, Sam Ravnborg wrote: > Hi Dan. > > On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote: > > The "lvds->backlight" pointer could be NULL in situations were > > of_parse_phandle() returns NULL. Also it's slightly cleaner to use > > backlight_put() which already has a check for NULL built in. > > > > Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver") > > Signed-off-by: Dan Carpenter > > A much better fix would be to introduce use of devm_of_find_backlight(). > Then you do not have to worry about put(). > > Care to respin a v3 that does this? Sure. That does look nice. I will resend tomorrow. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling Date: Tue, 10 Sep 2019 16:32:26 +0300 Message-ID: <20190910133226.GD20699@kadam> References: <20190904115057.GC4811@pendragon.ideasonboard.com> <20190904185507.GA3634@mwanda> <20190908160428.GA20115@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by gabe.freedesktop.org (Postfix) with ESMTPS id 456A16E0C8 for ; Tue, 10 Sep 2019 13:32:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190908160428.GA20115@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sam Ravnborg Cc: Laurent Pinchart , David Airlie , kernel-janitors@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Mark Brown , Thierry Reding List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBTZXAgMDgsIDIwMTkgYXQgMDY6MDQ6MjhQTSArMDIwMCwgU2FtIFJhdm5ib3JnIHdy b3RlOgo+IEhpIERhbi4KPiAKPiBPbiBXZWQsIFNlcCAwNCwgMjAxOSBhdCAwOTo1NTowN1BNICsw MzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+ID4gVGhlICJsdmRzLT5iYWNrbGlnaHQiIHBvaW50 ZXIgY291bGQgYmUgTlVMTCBpbiBzaXR1YXRpb25zIHdlcmUKPiA+IG9mX3BhcnNlX3BoYW5kbGUo KSByZXR1cm5zIE5VTEwuICBBbHNvIGl0J3Mgc2xpZ2h0bHkgY2xlYW5lciB0byB1c2UKPiA+IGJh Y2tsaWdodF9wdXQoKSB3aGljaCBhbHJlYWR5IGhhcyBhIGNoZWNrIGZvciBOVUxMIGJ1aWx0IGlu Lgo+ID4gCj4gPiBGaXhlczogN2M5ZGZmNWJkNjQzICgiZHJtOiBwYW5lbHM6IEFkZCBMVkRTIHBh bmVsIGRyaXZlciIpCj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVu dGVyQG9yYWNsZS5jb20+Cj4gCj4gQSBtdWNoIGJldHRlciBmaXggd291bGQgYmUgdG8gaW50cm9k dWNlIHVzZSBvZiBkZXZtX29mX2ZpbmRfYmFja2xpZ2h0KCkuCj4gVGhlbiB5b3UgZG8gbm90IGhh dmUgdG8gd29ycnkgYWJvdXQgcHV0KCkuCj4gCj4gQ2FyZSB0byByZXNwaW4gYSB2MyB0aGF0IGRv ZXMgdGhpcz8KClN1cmUuICBUaGF0IGRvZXMgbG9vayBuaWNlLiAgSSB3aWxsIHJlc2VuZCB0b21v cnJvdy4KCnJlZ2FyZHMsCmRhbiBjYXJwZW50ZXIKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbA==