All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Toshiki Fukasawa <t-fukasawa@vx.jp.nec.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"adobriyan@gmail.com" <adobriyan@gmail.com>,
	"hch@lst.de" <hch@lst.de>,
	"longman@redhat.com" <longman@redhat.com>,
	"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
	"mst@redhat.com" <mst@redhat.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Junichi Nomura <j-nomura@ce.jp.nec.com>
Subject: Re: [RFC PATCH v2] mm: initialize struct pages reserved by ZONE_DEVICE driver.
Date: Tue, 10 Sep 2019 16:01:07 +0200	[thread overview]
Message-ID: <20190910140107.GD2063@dhcp22.suse.cz> (raw)
In-Reply-To: <20190906081027.15477-1-t-fukasawa@vx.jp.nec.com>

On Fri 06-09-19 08:09:52, Toshiki Fukasawa wrote:
[...]
> @@ -5856,8 +5855,6 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
>  		if (!altmap)
>  			return;
>  
> -		if (start_pfn == altmap->base_pfn)
> -			start_pfn += altmap->reserve;
>  		end_pfn = altmap->base_pfn + vmem_altmap_offset(altmap);

Who is actually setting reserve? This is is something really impossible
to grep for in the kernle and git grep on altmap->reserve doesn't show
anything AFAICS.

Btw. irrespective to this issue all three callers should be using
pfn_to_online_page rather than pfn_to_page AFAICS. It doesn't really
make sense to collect data for offline pfn ranges. They might be
uninitialized even without zone device.
-- 
Michal Hocko
SUSE Labs

  parent reply	other threads:[~2019-09-10 14:01 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  8:09 [RFC PATCH v2] mm: initialize struct pages reserved by ZONE_DEVICE driver Toshiki Fukasawa
2019-09-06  8:45 ` David Hildenbrand
2019-09-06 10:02   ` Toshiki Fukasawa
2019-09-06 10:35     ` David Hildenbrand
2019-09-09  5:48       ` Toshiki Fukasawa
2019-09-09  7:46         ` David Hildenbrand
2019-09-09  8:10           ` David Hildenbrand
2019-09-09 11:53             ` Dan Williams
2019-09-09 11:53               ` Dan Williams
2019-09-09 12:05               ` David Hildenbrand
2019-09-10  9:21                 ` Dan Williams
2019-09-10  9:21                   ` Dan Williams
2019-09-10 10:10                   ` David Hildenbrand
2019-09-17  2:34           ` Toshiki Fukasawa
2019-09-17  7:13             ` David Hildenbrand
2019-09-17  9:32               ` Toshiki Fukasawa
2019-09-17 10:20                 ` David Hildenbrand
2019-09-18  2:16                   ` Toshiki Fukasawa
2019-09-17 15:49               ` Waiman Long
2019-09-17 16:21                 ` Qian Cai
2019-09-17 16:21                   ` Qian Cai
2019-09-17 17:04                   ` Waiman Long
2019-09-17 20:23                     ` David Hildenbrand
2019-09-18  2:28                     ` Toshiki Fukasawa
2019-09-18  7:30           ` David Hildenbrand
2019-09-10 14:01 ` Michal Hocko [this message]
2019-09-10 14:53   ` Dan Williams
2019-09-10 14:53     ` Dan Williams
2019-09-10 17:35     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190910140107.GD2063@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=hch@lst.de \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=longman@redhat.com \
    --cc=mst@redhat.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=sfr@canb.auug.org.au \
    --cc=t-fukasawa@vx.jp.nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.