All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/4] drm/i915: Avoid round-trip via i915 in intel_gt_park
Date: Tue, 10 Sep 2019 15:38:22 +0100	[thread overview]
Message-ID: <20190910143823.10686-4-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20190910143823.10686-1-tvrtko.ursulin@linux.intel.com>

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Both in the container_of and getting to gt->awake there is no need to go
via i915 since both the wakeref and awake are members of gt.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/intel_gt_pm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
index 6ba0d2069f87..a2e29bcc9671 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
@@ -56,9 +56,9 @@ static int __gt_unpark(struct intel_wakeref *wf)
 
 static int __gt_park(struct intel_wakeref *wf)
 {
-	struct drm_i915_private *i915 =
-		container_of(wf, typeof(*i915), gt.wakeref);
-	intel_wakeref_t wakeref = fetch_and_zero(&i915->gt.awake);
+	struct intel_gt *gt = container_of(wf, typeof(*gt), wakeref);
+	intel_wakeref_t wakeref = fetch_and_zero(&gt->awake);
+	struct drm_i915_private *i915 = gt->i915;
 
 	GEM_TRACE("\n");
 
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-09-10 14:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 14:38 [PATCH 0/4] Few loose end intel_gt cleanups Tvrtko Ursulin
2019-09-10 14:38 ` [PATCH 1/4] drm/i915: Move GT init to intel_gt.c Tvrtko Ursulin
2019-09-10 15:00   ` Chris Wilson
2019-09-10 14:38 ` [PATCH 2/4] drm/i915: Make wait_for_timelines take struct intel_gt Tvrtko Ursulin
2019-09-10 15:02   ` Chris Wilson
2019-09-10 14:38 ` Tvrtko Ursulin [this message]
2019-09-10 15:02   ` [PATCH 3/4] drm/i915: Avoid round-trip via i915 in intel_gt_park Chris Wilson
2019-09-10 14:38 ` [PATCH 4/4] drm/i915: Make pm_notify take intel_gt Tvrtko Ursulin
2019-09-10 15:05   ` Chris Wilson
2019-09-10 14:55 ` ✗ Fi.CI.CHECKPATCH: warning for Few loose end intel_gt cleanups Patchwork
2019-09-10 15:17 ` ✓ Fi.CI.BAT: success " Patchwork
2019-09-11  7:14   ` Tvrtko Ursulin
2019-09-10 23:04 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190910143823.10686-4-tvrtko.ursulin@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.