All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Max Filippov <jcmvbkbc@gmail.com>,
	Riku Voipio <riku.voipio@iki.fi>,
	Laurent Vivier <laurent@vivier.eu>,
	Shu-Chun Weng <scw@google.com>
Subject: [Qemu-devel] [PULL 03/15] linux-user: erroneous fd_trans_unregister call
Date: Tue, 10 Sep 2019 18:35:48 +0200	[thread overview]
Message-ID: <20190910163600.19971-4-laurent@vivier.eu> (raw)
In-Reply-To: <20190910163600.19971-1-laurent@vivier.eu>

From: Shu-Chun Weng via Qemu-devel <qemu-devel@nongnu.org>

timer_getoverrun returns the "overrun count" for the timer, which is not
a file descriptor and thus should not call fd_trans_unregister on it.

Signed-off-by: Shu-Chun Weng <scw@google.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20190819185348.221825-1-scw@google.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/syscall.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 8b41a03901d4..b42f59a32c8d 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -11847,7 +11847,6 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
             timer_t htimer = g_posix_timers[timerid];
             ret = get_errno(timer_getoverrun(htimer));
         }
-        fd_trans_unregister(ret);
         return ret;
     }
 #endif
-- 
2.21.0



  parent reply	other threads:[~2019-09-10 16:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 16:35 [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches Laurent Vivier
2019-09-10 16:35 ` [Qemu-devel] [PULL 01/15] linux-user: remove useless variable Laurent Vivier
2019-09-10 16:35 ` [Qemu-devel] [PULL 02/15] linux-user: Add AT_HWCAP2 for aarch64-linux-user Laurent Vivier
2019-09-10 16:35 ` Laurent Vivier [this message]
2019-09-10 16:35 ` [Qemu-devel] [PULL 04/15] linux-user: fail and report on bad dfilter specs Laurent Vivier
2019-09-10 16:35 ` [Qemu-devel] [PULL 05/15] linux-user: add memfd_create Laurent Vivier
2019-09-10 16:35 ` [Qemu-devel] [PULL 06/15] linux-user: Pass CPUState to MAX_RESERVED_VA Laurent Vivier
2019-09-10 16:35 ` [Qemu-devel] [PULL 07/15] linux-user/arm: Adjust MAX_RESERVED_VA for M-profile Laurent Vivier
2019-09-10 16:35 ` [Qemu-devel] [PULL 08/15] linux-user: Support gdb 'qOffsets' query for ELF Laurent Vivier
2019-09-10 16:35 ` [Qemu-devel] [PULL 09/15] target/xtensa: linux-user: add call0 ABI support Laurent Vivier
2019-09-10 16:35 ` [Qemu-devel] [PULL 10/15] linux-user: drop redundant handling of environment variables Laurent Vivier
2019-09-10 16:35 ` [Qemu-devel] [PULL 11/15] linux-user: Add support for RNDRESEEDCRNG ioctl Laurent Vivier
2019-09-10 16:35 ` [Qemu-devel] [PULL 12/15] linux-user: Add support for FIOGETOWN and FIOSETOWN ioctls Laurent Vivier
2019-09-10 16:35 ` [Qemu-devel] [PULL 13/15] linux-user: Add support for FDFLUSH ioctl Laurent Vivier
2019-09-10 16:35 ` [Qemu-devel] [PULL 14/15] linux-user: Add support for FDMSGON and FDMSGOFF ioctls Laurent Vivier
2019-09-10 16:36 ` [Qemu-devel] [PULL 15/15] linux-user: Add support for FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls Laurent Vivier
2019-09-10 20:52 ` [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches no-reply
2019-09-11  0:38 ` no-reply
2019-09-11  2:32 ` no-reply
2019-09-11  4:36 ` no-reply
2019-09-11  6:36   ` Laurent Vivier
2019-09-11  6:45 ` no-reply
2019-09-11  7:37 ` no-reply
2019-09-11  8:40 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190910163600.19971-4-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=jcmvbkbc@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=scw@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.