From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [conntrack-tools PATCH] nfct: helper: Fix NFCTH_ATTR_PROTO_L4NUM size
Date: Tue, 10 Sep 2019 20:33:45 +0200 [thread overview]
Message-ID: <20190910183345.2fn5prc4yt3rwvnl@salvia> (raw)
In-Reply-To: <20190910120631.20817-1-phil@nwl.cc>
On Tue, Sep 10, 2019 at 02:06:31PM +0200, Phil Sutter wrote:
> Kernel defines NFCTH_TUPLE_L4PROTONUM as of type NLA_U8. When adding a
> helper, NFCTH_ATTR_PROTO_L4NUM attribute is correctly set using
> nfct_helper_attr_set_u8(), though when deleting
> nfct_helper_attr_set_u32() was incorrectly used. Due to alignment, this
> causes trouble only on Big Endian.
>
> Fixes: 5e8f64f46cb1d ("conntrackd: add cthelper infrastructure (+ example FTP helper)")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2019-09-10 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 12:06 [conntrack-tools PATCH] nfct: helper: Fix NFCTH_ATTR_PROTO_L4NUM size Phil Sutter
2019-09-10 18:33 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910183345.2fn5prc4yt3rwvnl@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.