From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23587C5ACAE for ; Wed, 11 Sep 2019 13:56:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9391206A5 for ; Wed, 11 Sep 2019 13:56:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9391206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i836i-00029n-Ih for qemu-devel@archiver.kernel.org; Wed, 11 Sep 2019 09:56:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37027) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8360-0001aD-Bv for qemu-devel@nongnu.org; Wed, 11 Sep 2019 09:55:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i835z-0004t8-9J for qemu-devel@nongnu.org; Wed, 11 Sep 2019 09:55:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52298) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i835z-0004sh-0y for qemu-devel@nongnu.org; Wed, 11 Sep 2019 09:55:43 -0400 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE79A6696F for ; Wed, 11 Sep 2019 13:55:41 +0000 (UTC) Received: by mail-qk1-f198.google.com with SMTP id z128so12638003qke.8 for ; Wed, 11 Sep 2019 06:55:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3Ijcv5EhNvjHAfSR2M7jiVx2VbNGZCjsuNwNZLOSzlw=; b=MIP+E4pNzge/v83ueJvFTzk2mNc6tjhic3XJv1RwPht+st269aTKA2gc3aGBXHKXk7 ZPwX7WcpvhFeJoLxwm7ZY18wHQ9nm30FTExwjBZIBqhsVoyEWWunW010B8vKalMosVXQ VVWQk/tCqDKvwrTaASc7YpMTmrt+u2k1UiLiOvHGsU7PN47oIr6QpHA1pGz9cMvy+NQh B9lsTsscuz+Wto7PZCQH/s7so1o1hG2j37YpmElkmQkAqNBmC/Ao0KCLML6WAQHc9+sb ASedjjHT50JHfqptDKdc7on+gb1IsSzSjJv6CQ+whnsKpSD8mu/DVsaQtMuZoqo8eAAt ybTg== X-Gm-Message-State: APjAAAWh4GLcT93xqqyQ8GER2wYTYjq0SfBth8Aaw5BGpNx88JZ6AimC X0tdxNfXfIp5tUidZ7r7UdMbqYefYaqey63TiPlInyZ1OcE+7Qwl5jixc+d7h3qYsXC+XwAo3IC GrNPFzCjLWSF3kxo= X-Received: by 2002:ac8:7246:: with SMTP id l6mr35657869qtp.359.1568210141052; Wed, 11 Sep 2019 06:55:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqxWxRIm8iCBEBuyNc6cSs9A0C1P36uv5W4jntXQX1E7UOjGApCrtE+xKWQ1emO1nt2U84LbUw== X-Received: by 2002:ac8:7246:: with SMTP id l6mr35657854qtp.359.1568210140880; Wed, 11 Sep 2019 06:55:40 -0700 (PDT) Received: from redhat.com ([80.74.107.118]) by smtp.gmail.com with ESMTPSA id u43sm7807044qte.19.2019.09.11.06.55.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2019 06:55:40 -0700 (PDT) Date: Wed, 11 Sep 2019 09:55:34 -0400 From: "Michael S. Tsirkin" To: Igor Mammedov Message-ID: <20190911095332-mutt-send-email-mst@kernel.org> References: <20190904085629.13872-1-shameerali.kolothum.thodi@huawei.com> <20190904085629.13872-11-shameerali.kolothum.thodi@huawei.com> <20190911155015.3627b072@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190911155015.3627b072@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Samuel Ortiz , Ard Biesheuvel , QEMU Developers , Shameer Kolothum , Linuxarm , Shannon Zhao , qemu-arm , Xu Wei , Eric Auger , sebastien.boeuf@intel.com, Laszlo Ersek Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 11, 2019 at 03:50:15PM +0200, Igor Mammedov wrote: > On Wed, 11 Sep 2019 13:57:06 +0100 > Peter Maydell wrote: > > > On Wed, 4 Sep 2019 at 09:58, Shameer Kolothum > > wrote: > > > > > > This patch is in preparation for adding numamem and memhp tests > > > to arm/virt board so that 'make check' is happy. This may not > > > be required once the scripts are run and new tables are > > > generated with ".numamem" and ".memhp" extensions. > > > > > > Signed-off-by: Shameer Kolothum > > > --- > > > I am not sure this is the right way to do this. But without this, when > > > the numamem and memhp tests are added, you will get, > > > > > > Looking for expected file 'tests/data/acpi/virt/SRAT.numamem' > > > Looking for expected file 'tests/data/acpi/virt/SRAT' > > > ** > > > ERROR:tests/bios-tables-test.c:327:load_expected_aml: assertion failed: (exp_sdt.aml_file) > > > > > > --- > > > tests/data/acpi/virt/SLIT | Bin 0 -> 48 bytes > > > tests/data/acpi/virt/SRAT | Bin 0 -> 224 bytes > > > 2 files changed, 0 insertions(+), 0 deletions(-) > > > create mode 100644 tests/data/acpi/virt/SLIT > > > create mode 100644 tests/data/acpi/virt/SRAT > > > > Do the tests pass with this patch and without the > > patch that adds the tests? (That is, can we keep the > > two patches separate without breaking bisection, or > > do we need to squash them together?) > > > > I'll leave it to somebody who understands the ACPI > > tests stuff to answer whether there's a better way to > I'd squash this patch into 11/11 test case, Pls don't - the way to add this is to add the files in question to tests/bios-tables-test-allowed-diff.h. Maintainer will create a separate commit updating the binaries and removing them from the whitelist. This way things like rebase work seemlessly. > CCing Michael (since he's the one who applies ACPI patches) > > > do this. > > > > thanks > > -- PMM > >