All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andriy Shevchenko <andriy.shevchenko@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rahul Tanwar <rahul.tanwar@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	qi-ming.wu@intel.com, yixin.zhu@linux.intel.com,
	cheol.yong.kim@intel.com
Subject: Re: [PATCH v1 0/2] pinctrl: Add new pinctrl/GPIO driver
Date: Thu, 12 Sep 2019 17:54:32 +0300	[thread overview]
Message-ID: <20190912145432.GD2680@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdYcdaoA_D6YyKJuT5bfJ5QE4LWfXF8+R1y01xaWJaJZuQ@mail.gmail.com>

On Thu, Sep 12, 2019 at 03:30:52PM +0100, Linus Walleij wrote:
> On Thu, Sep 12, 2019 at 2:58 PM Andriy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Thu, Sep 12, 2019 at 11:11:32AM +0100, Linus Walleij wrote:
> > > Hi Rahul,
> > >
> > > thanks for your patches!
> > >
> > > On Thu, Sep 12, 2019 at 8:59 AM Rahul Tanwar
> > > <rahul.tanwar@linux.intel.com> wrote:
> > >
> > > > This series is to add pinctrl & GPIO controller driver for a new SoC.
> > > > Patch 1 adds pinmux & GPIO controller driver.
> > > > Patch 2 adds the dt bindings document & include file.
> > > >
> > > > Patches are against Linux 5.3-rc5 at below Git tree:
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git
> > >
> > > OK nice, I think you need to include Mika Westerberg on this review
> > > as well, because I think he likes to stay on top of all things intel
> > > in pin control. (Also included two other Intel folks in Finland who usually
> > > take an interest in these things.)
> >
> > Linus,
> > nevertheless I guess you may give your comments WRT device tree use
> > (bindings, helpers, etc) along with some basics, (like devm_*()
> > [ab]use I just noticed).
> 
> I plan to look at the patches per se but right now I don't have much
> time because soon there is merge window and kernel summit,
> the patches just need to age a little bit like a good wine ;)

I meant in general, I know about merge window, so, I guess this is not
material for v5.4.

I reviewed it a bit, hope this helps.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2019-09-12 14:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12  7:59 [PATCH v1 0/2] pinctrl: Add new pinctrl/GPIO driver Rahul Tanwar
2019-09-12  7:59 ` [PATCH v1 1/2] pinctrl: Add pinmux & GPIO controller driver for new SoC Rahul Tanwar
2019-09-12 14:30   ` Andy Shevchenko
2019-09-19  8:36     ` Tanwar, Rahul
2019-10-04 20:28   ` Linus Walleij
2019-10-04 20:28     ` Linus Walleij
2019-10-10  4:35     ` Tanwar, Rahul
2019-10-10  4:35       ` Tanwar, Rahul
2019-10-16 12:05       ` Linus Walleij
2019-09-12  7:59 ` [PATCH v1 2/2] dt-bindings: pinctrl: intel: Add " Rahul Tanwar
2019-09-30 14:50   ` Rob Herring
2019-09-12 10:11 ` [PATCH v1 0/2] pinctrl: Add new pinctrl/GPIO driver Linus Walleij
2019-09-12 10:11   ` Linus Walleij
2019-09-12 13:58   ` Andriy Shevchenko
2019-09-12 13:58     ` Andriy Shevchenko
2019-09-12 14:30     ` Linus Walleij
2019-09-12 14:30       ` Linus Walleij
2019-09-12 14:54       ` Andriy Shevchenko [this message]
2019-09-13  8:18   ` Mika Westerberg
2019-09-13  8:18     ` Mika Westerberg
2019-09-23  3:37     ` Tanwar, Rahul
2019-09-23  3:37       ` Tanwar, Rahul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190912145432.GD2680@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=cheol.yong.kim@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=qi-ming.wu@intel.com \
    --cc=rahul.tanwar@linux.intel.com \
    --cc=yixin.zhu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.