From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D33C4CEC6 for ; Thu, 12 Sep 2019 23:55:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C93E2084D for ; Thu, 12 Sep 2019 23:55:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N/9FVwqw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728201AbfILXzr (ORCPT ); Thu, 12 Sep 2019 19:55:47 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:39765 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727325AbfILXzq (ORCPT ); Thu, 12 Sep 2019 19:55:46 -0400 Received: by mail-pf1-f193.google.com with SMTP id i1so8100509pfa.6 for ; Thu, 12 Sep 2019 16:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MKg9N5Ak/mqK4Z77OiWZOmXzQbsQdtgDZRsUGqX7iZY=; b=N/9FVwqw2HM4pjK9/KOapQ6CrsHfOWXlQZf5cbvJspNfr5YemTKwvog5nEJquW6vNB dhb8QaktoUZb+TX2cX2BqUb5r+E1dvNebQMcdWPh/J4FiNdPstJmUUdAZAD1kJgmW/Af 08haBzhalAZIsIPN29D7lBbgQjrl1RU3GRGrgJdxIgO8NdK32r7OiRK33X1bLBEwmewl /p4DtShHDsmPP7cb7nbP08iwxYdtD9Nblw29H3yAzefARKSyVftxzo39jEpvRvonGGXr bQ3TDRfX6z+Ezlf2vy3/BzFYT04GPSrPvMtEkR8C4ti0MnH3JYOzQyBeGGZ9FcbwOba6 REbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MKg9N5Ak/mqK4Z77OiWZOmXzQbsQdtgDZRsUGqX7iZY=; b=kxMGLIe2UdHcs5QDn70R2mYXVA5rMhinmNLz4gCnLW/nWhZzK+tTB2Oj3umbS/dggP 5/VbhiW5XIXsygiRabeIC/BjFkXK/cDm3IHkxS7EX125YVX+8nBnYsgpyRQXd5HuJWgu kEwkVuGr5cDwsR6kE4wmt+Oku2hx/9CwaO/Oji4/nG+CDHXO9arhHjrANVllhGbNt4KG MPvqs0YF4OZrSbN0wUwSKApq41wu78EML9prHxCD9QGFtVYysATpDYmpPyY5sfhgaM+Z HTakGK8mFEK3FpU5Fl+Q4zJIK5jXL9ZDvL7QKAiNT/rO5iGVmZSEs5c7d+kqK7ncO52c 0c/A== X-Gm-Message-State: APjAAAUYs2cP03+5erJ2Tw9Kq+QLA+ofJSjLp9gsDZ6pOEnnjWrVJOmn hKN1agU6HwUqzKlzaKJeJrY= X-Google-Smtp-Source: APXvYqwGccc6+qJ6fu7lfAAauwtZvtPeLkhiMe9OxJMG2Jg+hfl9NJGSzizq4OGkb7Sp0XJb4FrbIQ== X-Received: by 2002:aa7:8d10:: with SMTP id j16mr5842105pfe.109.1568332545774; Thu, 12 Sep 2019 16:55:45 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id 1sm24596429pff.39.2019.09.12.16.55.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Sep 2019 16:55:45 -0700 (PDT) Date: Thu, 12 Sep 2019 16:55:24 -0700 From: Nicolin Chen To: Daniel Baluta Cc: Mark Brown , Linux-ALSA , Timur Tabi , Xiubo Li , Daniel Baluta , "S.j. Wang" , Linux Kernel Mailing List , NXP Linux Team , Viorel Suman , Fabio Estevam Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_sai: Implement set_bclk_ratio Message-ID: <20190912235523.GG24937@Asurada-Nvidia.nvidia.com> References: <20190830215910.31590-1-daniel.baluta@nxp.com> <20190906012938.GB17926@Asurada-Nvidia.nvidia.com> <20190911110017.GA2036@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 11, 2019 at 04:06:41PM +0300, Daniel Baluta wrote: > On Wed, Sep 11, 2019 at 2:01 PM Mark Brown wrote: > > > > On Thu, Sep 05, 2019 at 06:29:39PM -0700, Nicolin Chen wrote: > > > On Sat, Aug 31, 2019 at 12:59:10AM +0300, Daniel Baluta wrote: > > > > > > This is to allow machine drivers to set a certain bitclk rate > > > > which might not be exactly rate * frame size. > > > > > Just a quick thought of mine: slot_width and slots could be > > > set via set_dai_tdm_slot() actually, while set_bclk_ratio() > > > would override that one with your change. I'm not sure which > > > one could be more important...so would you mind elaborating > > > your use case? > > > > The reason we have both operations is partly that some hardware > > can configure the ratio but not do TDM and partly that setting > > TDM slots forces us to configure the slot size depending on the > > current stream configuration while just setting the ratio means > > we can just fix the configuration once. I'd say it's just a user > > error to try to do both simultaneously. > > Yes, exactly. We wanted to have a better control of bclk freq. > Sorry for the late answer, I'm traveling. I see. Thanks for the explain. Just acked. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B410AC4CEC6 for ; Thu, 12 Sep 2019 23:56:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B7C520840 for ; Thu, 12 Sep 2019 23:56:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="HV0Ecv84"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N/9FVwqw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B7C520840 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E22DB1672; Fri, 13 Sep 2019 01:55:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E22DB1672 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568332608; bh=kPWRXcCpFtw9p1kAnehVFBVHIJAfNLH6wsQ7RchdvFE=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HV0Ecv840xbUJGfhyEsgLUaBiuC7kqsKGVxAQni55sKK8NW3WyYLYchtu+phSW3Ap +elOFpxduvIy3/JLzZ7CAWjlkzMFWpzXfcDbnHa2s70Qn/dHfLX1U3h6eF3bDlL9ry 92+IFXpWLvSHU7Rtk+JwuW+JnSUtbMG2jo4AiHKw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9D08CF80508; Fri, 13 Sep 2019 01:55:51 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 49451F805A0; Fri, 13 Sep 2019 01:55:50 +0200 (CEST) Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BCFCFF80368 for ; Fri, 13 Sep 2019 01:55:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BCFCFF80368 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N/9FVwqw" Received: by mail-pg1-x541.google.com with SMTP id u17so14281390pgi.6 for ; Thu, 12 Sep 2019 16:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MKg9N5Ak/mqK4Z77OiWZOmXzQbsQdtgDZRsUGqX7iZY=; b=N/9FVwqw2HM4pjK9/KOapQ6CrsHfOWXlQZf5cbvJspNfr5YemTKwvog5nEJquW6vNB dhb8QaktoUZb+TX2cX2BqUb5r+E1dvNebQMcdWPh/J4FiNdPstJmUUdAZAD1kJgmW/Af 08haBzhalAZIsIPN29D7lBbgQjrl1RU3GRGrgJdxIgO8NdK32r7OiRK33X1bLBEwmewl /p4DtShHDsmPP7cb7nbP08iwxYdtD9Nblw29H3yAzefARKSyVftxzo39jEpvRvonGGXr bQ3TDRfX6z+Ezlf2vy3/BzFYT04GPSrPvMtEkR8C4ti0MnH3JYOzQyBeGGZ9FcbwOba6 REbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MKg9N5Ak/mqK4Z77OiWZOmXzQbsQdtgDZRsUGqX7iZY=; b=GCwYN0E3fmMg6T9fHOaiBva9Hu8k22InuoDYJhay/dzaoJa7nhVG3kH8/N8F1PrOmB wx81oszr5bPMzdwIm5I9IuADkyrlUMV6wjIAEThkdfRPdbdaZLyojeAuIGfQLbNgcqw8 lGuw+oV+95pGd2FstOTWj0jTSfIwE/uDwRjwyOkqEE2wVnV/PUDuGu4Yk50jfSYQur1Y 3qs/wElsQAZhOKHKgXZ8MU5M05KNWo828cuCEp1OrzZw2jMZsFzpx9In6rgs+9zDhDME 8ThSh9u5UsHL5eFmzqUyTT43cwhIB4/fqqY9aRyR6wc0DXeEuaiGQTfvg5EWBLdIZQVA SOfQ== X-Gm-Message-State: APjAAAWhzl1sdYSYmCHhHuw3N91rMofxVAugyCOjKcaUPa9JnZFC2ly3 x0Nj5Ex6qYoJbwaFOqgry8o= X-Google-Smtp-Source: APXvYqwGccc6+qJ6fu7lfAAauwtZvtPeLkhiMe9OxJMG2Jg+hfl9NJGSzizq4OGkb7Sp0XJb4FrbIQ== X-Received: by 2002:aa7:8d10:: with SMTP id j16mr5842105pfe.109.1568332545774; Thu, 12 Sep 2019 16:55:45 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id 1sm24596429pff.39.2019.09.12.16.55.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Sep 2019 16:55:45 -0700 (PDT) Date: Thu, 12 Sep 2019 16:55:24 -0700 From: Nicolin Chen To: Daniel Baluta Message-ID: <20190912235523.GG24937@Asurada-Nvidia.nvidia.com> References: <20190830215910.31590-1-daniel.baluta@nxp.com> <20190906012938.GB17926@Asurada-Nvidia.nvidia.com> <20190911110017.GA2036@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Cc: Linux-ALSA , Timur Tabi , Xiubo Li , Fabio Estevam , "S.j. Wang" , Linux Kernel Mailing List , Mark Brown , NXP Linux Team , Viorel Suman , Daniel Baluta Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_sai: Implement set_bclk_ratio X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Sep 11, 2019 at 04:06:41PM +0300, Daniel Baluta wrote: > On Wed, Sep 11, 2019 at 2:01 PM Mark Brown wrote: > > > > On Thu, Sep 05, 2019 at 06:29:39PM -0700, Nicolin Chen wrote: > > > On Sat, Aug 31, 2019 at 12:59:10AM +0300, Daniel Baluta wrote: > > > > > > This is to allow machine drivers to set a certain bitclk rate > > > > which might not be exactly rate * frame size. > > > > > Just a quick thought of mine: slot_width and slots could be > > > set via set_dai_tdm_slot() actually, while set_bclk_ratio() > > > would override that one with your change. I'm not sure which > > > one could be more important...so would you mind elaborating > > > your use case? > > > > The reason we have both operations is partly that some hardware > > can configure the ratio but not do TDM and partly that setting > > TDM slots forces us to configure the slot size depending on the > > current stream configuration while just setting the ratio means > > we can just fix the configuration once. I'd say it's just a user > > error to try to do both simultaneously. > > Yes, exactly. We wanted to have a better control of bclk freq. > Sorry for the late answer, I'm traveling. I see. Thanks for the explain. Just acked. _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel