From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C4F8C4CEC7 for ; Mon, 16 Sep 2019 08:14:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 321DC206C2 for ; Mon, 16 Sep 2019 08:14:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730961AbfIPIOQ (ORCPT ); Mon, 16 Sep 2019 04:14:16 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:60021 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728150AbfIPIOQ (ORCPT ); Mon, 16 Sep 2019 04:14:16 -0400 Received: from static-dcd-cqq-121001.business.bouyguestelecom.com ([212.194.121.1] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1i9m9G-0006HC-Cc; Mon, 16 Sep 2019 08:14:14 +0000 Date: Mon, 16 Sep 2019 10:14:14 +0200 From: Christian Brauner To: Adrian Reber Cc: Eugene Syromiatnikov , linux-kernel@vger.kernel.org, Christian Brauner , Shuah Khan , linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 0/6] Update clone3 self-tests Message-ID: <20190916081413.32dmmed6f6yjta26@wittgenstein> References: <20190916074933.j33qc2z3hynpj2gf@wittgenstein> <20190916081247.GC26734@dcbz.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190916081247.GC26734@dcbz.redhat.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 16, 2019 at 10:12:47AM +0200, Adrian Reber wrote: > On Mon, Sep 16, 2019 at 09:49:34AM +0200, Christian Brauner wrote: > > On Tue, Sep 10, 2019 at 07:01:30PM +0100, Eugene Syromiatnikov wrote: > > > Hello. > > > > > > This patch set updates clone3 selftest in several aspects: > > > - adding checks for exit_signal invalid values handling; > > > - adding clone3 to selftests targets; > > > - enabling clone3 tests on all architectures; > > > - minor cleanups of the clone3 test. > > > > > > Applied on top of brauer/linux.git/for-next. > > > > So I like this series a lot! Testing is very important. > > And thanks for catching the clone3() exit_signal problem. This way we > > got to release a non-broken kernel. :) > > > > Some notes: I dropped the set_tid extension from the core process > > updates for 5.4 because we ended up in a discussion that made it clear > > we potentially need the ability to restore pids in multiple pid > > namespaces. This means we need some more discussion and the patchset is > > delayed for at least one release. > > Unfortunately, this also means the test that you have based yours upon > > does not exist anymore. However, the tests should not be blocked on > > this. I'd encourage you to talk to Adrian (who is Cced here anyway) and > > come up with a clone3() test suite I can merge. You can very likely do a > > Co-Developed-by so no-ones work gets dropped. :) > > > > Ideally I'd like to see: > > - verifying passing different struct sizes works correctly > > - verify that flag combinations work correctly > > - verify that struct members have correct values etc. pp. > > > > We definitely want the exit_signal test as a regression test so it > > doesn't bite us again! > > > > (Oh, please also add tool/test/selftests/clone3/ to the pidfd/core > > process MAINTAINERS entry.) > > Eugene and I have already discussed this. We will resubmit the clone3() > selftests in the next few days with all our changes combined. Excellent! Very happy to hear this! :) Christian