All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: "Derrick, Jonathan" <jonathan.derrick@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Busch, Keith" <keith.busch@intel.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"helgaas@kernel.org" <helgaas@kernel.org>
Subject: Re: [PATCH 2/2] PCI: vmd: Fix shadow offsets to reflect spec changes
Date: Tue, 17 Sep 2019 17:37:24 +0100	[thread overview]
Message-ID: <20190917163716.GA9715@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <ec24dc3d6f6f962a9f96ab1bab8c9cf4e138d61a.camel@intel.com>

On Tue, Sep 17, 2019 at 03:51:39PM +0000, Derrick, Jonathan wrote:

[...]

> Sorry for the confusion.
> 
> These changes only affect systems with VMD devices with 8086:28C0
> device IDs, but these won't be production hardware for some time.
> 
> Systems with VMD devices exist in the wild with 8086:201D device IDs.
> These don't support the guest passthrough mode and this code won't
> break anything with them. Additionally, patch 1/2 (bus numbering) only
> affects 8086:28C0.
> 
> So on existing HW, these patches won't affect anything

It is me who created confusion, apologies. I read the code properly and
I understand that both patches are fixes for HW that is still not
available (and they can't create an issue with current kernel because
HAS_MEMBAR_SHADOW and HAS_BUS_RESTRICTIONS features are not implemented
on 8086:201D), we should take these patches and trickle them to stable
kernels as soon as possible so that when HW _is_ available mainline and
stable kernels are fixed.

Correct ?

Lorenzo

  reply	other threads:[~2019-09-17 16:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16 13:54 [PATCH 0/2] VMD fixes for v5.4 Jon Derrick
2019-09-16 13:54 ` [PATCH 1/2] PCI: vmd: Fix config addressing when using bus offsets Jon Derrick
     [not found]   ` <20190918110800.18D9021920@mail.kernel.org>
2019-09-18 14:06     ` Lorenzo Pieralisi
2019-09-16 13:54 ` [PATCH 2/2] PCI: vmd: Fix shadow offsets to reflect spec changes Jon Derrick
2019-09-17 10:41   ` Lorenzo Pieralisi
2019-09-17 13:55     ` Derrick, Jonathan
2019-09-17 14:05       ` Lorenzo Pieralisi
2019-09-17 14:45         ` Derrick, Jonathan
2019-09-17 15:15           ` Lorenzo Pieralisi
2019-09-17 15:51             ` Derrick, Jonathan
2019-09-17 16:37               ` Lorenzo Pieralisi [this message]
2019-09-17 18:00                 ` Derrick, Jonathan
2019-09-18  9:15 ` [PATCH 0/2] VMD fixes for v5.4 Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190917163716.GA9715@e121166-lin.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=helgaas@kernel.org \
    --cc=jonathan.derrick@intel.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.