From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 741B2C4CED0 for ; Wed, 18 Sep 2019 06:22:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B41820678 for ; Wed, 18 Sep 2019 06:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568787724; bh=qKc9hFuApt77yOaD7f+h92ICXvsOaXgo5AkSeczts0w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Wi2QmV+HNEc+oG7A1nWpw/7JQk/xxpMCZQ6yJ2j0MQSnt4YmteOYOAnM02XNvXRZv uGFN0L93jlDphW3Hs8fE2lWy0LVPr7DmsO2ZV03KdmnnQ4r+mAnHRW57hgBkxZWtIY PMRRRvfLvFC3XZWaB/76Cgr2//4YgTUqwfego3Ag= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728467AbfIRGWD (ORCPT ); Wed, 18 Sep 2019 02:22:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:41798 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729306AbfIRGWB (ORCPT ); Wed, 18 Sep 2019 02:22:01 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DDB8218AF; Wed, 18 Sep 2019 06:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568787720; bh=qKc9hFuApt77yOaD7f+h92ICXvsOaXgo5AkSeczts0w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U4GF8ZMsiO0rQsbEZI4smpoSHZM7zV/5K5P91EGMFM7QqZKs+nKAOkOFyp5Zuvkyw Ajwfinhz9RQL3V20nzD6uN6v8f3RgWtsrYC3ZEUsZfyeR0Z9KhV1LLqt80zbQEOMR/ 09cW6fZ1ZZ94QXwGdYe1+iVuq3XwgAz+Nv7NLbZI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nikolay Aleksandrov , Nicolas Dichtel , "David S. Miller" Subject: [PATCH 4.19 01/50] bridge/mdb: remove wrong use of NLM_F_MULTI Date: Wed, 18 Sep 2019 08:18:44 +0200 Message-Id: <20190918061223.328227452@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190918061223.116178343@linuxfoundation.org> References: <20190918061223.116178343@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicolas Dichtel [ Upstream commit 94a72b3f024fc7e9ab640897a1e38583a470659d ] NLM_F_MULTI must be used only when a NLMSG_DONE message is sent at the end. In fact, NLMSG_DONE is sent only at the end of a dump. Libraries like libnl will wait forever for NLMSG_DONE. Fixes: 949f1e39a617 ("bridge: mdb: notify on router port add and del") CC: Nikolay Aleksandrov Signed-off-by: Nicolas Dichtel Acked-by: Nikolay Aleksandrov Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/bridge/br_mdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -419,7 +419,7 @@ static int nlmsg_populate_rtr_fill(struc struct nlmsghdr *nlh; struct nlattr *nest; - nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), NLM_F_MULTI); + nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), 0); if (!nlh) return -EMSGSIZE;