From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 544B8C4CEC9 for ; Wed, 18 Sep 2019 15:23:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2871E218AE for ; Wed, 18 Sep 2019 15:23:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=megous.com header.i=@megous.com header.b="mg/ptGc6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731635AbfIRPXM (ORCPT ); Wed, 18 Sep 2019 11:23:12 -0400 Received: from vps.xff.cz ([195.181.215.36]:59682 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbfIRPXL (ORCPT ); Wed, 18 Sep 2019 11:23:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1568820189; bh=kRc8vp8BAB11xc+/TQcnK+fReDy51rfmeTkpuKM5zHM=; h=Date:From:To:Cc:Subject:References:X-My-GPG-KeyId:From; b=mg/ptGc6dXUGFsO2H5hLJjbsOQ/VgVQSZiexphZP1C1FRS1rwh7D7VzHbTc1W3NSr ZYM44/sJcvtiR+3pt+Zcn/oMif/DRC2uHY4PIssBohbuPYA/yCwbeSLTNZ7phlMH7m 3IsVRn3Rd/LOktCj5i5Z4/V1/9Qniz007k7EQ3dk= Date: Wed, 18 Sep 2019 17:23:09 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Maxime Ripard Cc: David Airlie , Daniel Vetter , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting Message-ID: <20190918152309.j2dbu63jaru6jn2t@core.my.home> Mail-Followup-To: Maxime Ripard , David Airlie , Daniel Vetter , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20190914220337.646719-1-megous@megous.com> <20190918141734.kerdbbaynwutrxf6@gilmour> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190918141734.kerdbbaynwutrxf6@gilmour> X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Sep 18, 2019 at 04:17:34PM +0200, Maxime Ripard wrote: > Hi, > > On Sun, Sep 15, 2019 at 12:03:37AM +0200, megous@megous.com wrote: > > From: Ondrej Jirman > > > > There are various issues that this re-work of sun8i_[uv]i_layer_enable > > function fixes: > > > > - Make sure that we re-initialize zpos on reset > > - Minimize register updates by doing them only when state changes > > - Fix issue where DE pipe might get disabled even if it is no longer > > used by the layer that's currently calling sun8i_ui_layer_enable > > - .atomic_disable callback is not really needed because .atomic_update > > can do the disable too, so drop the duplicate code > > > > Signed-off-by: Ondrej Jirman > > It looks like these fixes should be in separate patches. Is there any > reason it's not the case? Bullet points just describe the resulting effect/benefits of the change to fix the pipe control register update issue (see the referenced e-mail). I can maybe split off the first bullet point into a separate patch. But I can't guarantee it will not make the original issue worse, because it might have been hiding the other issue with register updates. The rest is just a result of the single logical change. It doesn't work individually, it all has the goal of fixing the issue as a whole. If I were to split it I would have to actually re-implement .atomic_disable callback only to remove it in the next patch. I don't see the benefit. regards, o. > Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_ADSP_ALL, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 040E9C4CEC9 for ; Wed, 18 Sep 2019 15:23:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAB3E20665 for ; Wed, 18 Sep 2019 15:23:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WCs5HQLX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=megous.com header.i=@megous.com header.b="mg/ptGc6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAB3E20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=megous.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Llhh9yhqYYHWoor1/PAwUnxEPvk0uAEifCzoYcz7QAo=; b=WCs5HQLX1xePYz tm+HYj3H67cXzCnHqGSKpzZbse2CeWxztSRpfqp59aLzc8TSLLsHLuQYwBZBam/71ZknxufBADoBU V31ZQfjEPXxdsoSi2fJ8q2ar/BQBBJyNsXl3My7RvZOoyqxXXR2kN6KT22dM+o2PEIxtG1DzL3P+9 d6kXChT8q1laSoaHwlz02D8TwA6HFNhCDBzYCM/sRXJYCh0Xpjp91JweKSyTPyplrmSghGGuHuDjT dShzUeKgh2ewbNPNwiXn0gI/b9sILGneNSkRURP/yEKM7FcIIrRD1LoS3an2AgRs2KXZPOhtI/MI4 cqokpqe9Vs3U3L39HFdg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAbnb-00083y-79; Wed, 18 Sep 2019 15:23:19 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAbnX-00083A-5w for linux-arm-kernel@lists.infradead.org; Wed, 18 Sep 2019 15:23:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1568820189; bh=kRc8vp8BAB11xc+/TQcnK+fReDy51rfmeTkpuKM5zHM=; h=Date:From:To:Cc:Subject:References:X-My-GPG-KeyId:From; b=mg/ptGc6dXUGFsO2H5hLJjbsOQ/VgVQSZiexphZP1C1FRS1rwh7D7VzHbTc1W3NSr ZYM44/sJcvtiR+3pt+Zcn/oMif/DRC2uHY4PIssBohbuPYA/yCwbeSLTNZ7phlMH7m 3IsVRn3Rd/LOktCj5i5Z4/V1/9Qniz007k7EQ3dk= Date: Wed, 18 Sep 2019 17:23:09 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Maxime Ripard Subject: Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting Message-ID: <20190918152309.j2dbu63jaru6jn2t@core.my.home> Mail-Followup-To: Maxime Ripard , David Airlie , Daniel Vetter , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20190914220337.646719-1-megous@megous.com> <20190918141734.kerdbbaynwutrxf6@gilmour> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190918141734.kerdbbaynwutrxf6@gilmour> X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190918_082315_393795_4730A8E2 X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Sep 18, 2019 at 04:17:34PM +0200, Maxime Ripard wrote: > Hi, > > On Sun, Sep 15, 2019 at 12:03:37AM +0200, megous@megous.com wrote: > > From: Ondrej Jirman > > > > There are various issues that this re-work of sun8i_[uv]i_layer_enable > > function fixes: > > > > - Make sure that we re-initialize zpos on reset > > - Minimize register updates by doing them only when state changes > > - Fix issue where DE pipe might get disabled even if it is no longer > > used by the layer that's currently calling sun8i_ui_layer_enable > > - .atomic_disable callback is not really needed because .atomic_update > > can do the disable too, so drop the duplicate code > > > > Signed-off-by: Ondrej Jirman > > It looks like these fixes should be in separate patches. Is there any > reason it's not the case? Bullet points just describe the resulting effect/benefits of the change to fix the pipe control register update issue (see the referenced e-mail). I can maybe split off the first bullet point into a separate patch. But I can't guarantee it will not make the original issue worse, because it might have been hiding the other issue with register updates. The rest is just a result of the single logical change. It doesn't work individually, it all has the goal of fixing the issue as a whole. If I were to split it I would have to actually re-implement .atomic_disable callback only to remove it in the next patch. I don't see the benefit. regards, o. > Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel