From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D478C4CEC4 for ; Wed, 18 Sep 2019 20:53:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB00620665 for ; Wed, 18 Sep 2019 20:53:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731653AbfIRUxs (ORCPT ); Wed, 18 Sep 2019 16:53:48 -0400 Received: from muru.com ([72.249.23.125]:33750 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727814AbfIRUxs (ORCPT ); Wed, 18 Sep 2019 16:53:48 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id CD55B806C; Wed, 18 Sep 2019 20:54:18 +0000 (UTC) Date: Wed, 18 Sep 2019 13:53:44 -0700 From: Tony Lindgren To: Stephen Boyd Cc: Michael Turquette , Stephen Boyd , Tero Kristo , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-omap@vger.kernel.org, Rob Herring Subject: Re: [PATCH] clk: ti: clkctrl: Fix hidden dependency to node name with reg-names Message-ID: <20190918205344.GE5610@atomide.com> References: <20190905215532.8357-1-tony@atomide.com> <20190907035518.EB40C208C3@mail.kernel.org> <20190908194241.GL52127@atomide.com> <20190918180729.C2BB521907@mail.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190918180729.C2BB521907@mail.kernel.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi, * Stephen Boyd [190918 18:08]: > Quoting Tony Lindgren (2019-09-08 12:42:41) > > Or do you have some better ideas on how to name a clock controller > > in the device tree? > > > > Why does the name of the clock controller or clkdm_name matter? Using a > string from reg-names smells like a workaround to describe some sort of > linkage between things that isn't being described in DT today. Correct. This problem will eventually disappear with genpd handling the clockdomains. But currently the clockdomain name is parsed from the dt node name, which is not standard practise. Using reg-names is a standard binding, and it's usage follows the standand here to describe the reg range. Then eventually with genpd, the reg-names will just become optinoal. But until that happens the $subject patch fixes issues as described in the patch. Regards, Tony