From: Stephen Boyd <sboyd@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Tero Kristo <t-kristo@ti.com>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-omap@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] clk: ti: clkctrl: Fix hidden dependency to node name with reg-names
Date: Wed, 18 Sep 2019 16:28:42 -0700 [thread overview]
Message-ID: <20190918232842.E2CBB21907@mail.kernel.org> (raw)
In-Reply-To: <20190918205344.GE5610@atomide.com>
Quoting Tony Lindgren (2019-09-18 13:53:44)
> Hi,
>
> * Stephen Boyd <sboyd@kernel.org> [190918 18:08]:
> > Quoting Tony Lindgren (2019-09-08 12:42:41)
> > > Or do you have some better ideas on how to name a clock controller
> > > in the device tree?
> > >
> >
> > Why does the name of the clock controller or clkdm_name matter? Using a
> > string from reg-names smells like a workaround to describe some sort of
> > linkage between things that isn't being described in DT today.
>
> Correct. This problem will eventually disappear with genpd
> handling the clockdomains.
>
> But currently the clockdomain name is parsed from the dt node
> name, which is not standard practise. Using reg-names
> is a standard binding, and it's usage follows the standand
> here to describe the reg range.
>
> Then eventually with genpd, the reg-names will just become
> optinoal. But until that happens the $subject patch fixes
> issues as described in the patch.
>
Is anything broken? It looks like the hidden dependency on the node name
is being changed to be a slightly less hidden dependency on reg-names.
reg-names is supposed to be an optional property, so we're trading one
thing for another. I still don't understand the reasoning here, but if
Tero is happy to ack/review this change then I'm not too worried about
it assuming the reg-names property eventually becomes optional. Just
seems like more work and DT churn for no to little gain?
next prev parent reply other threads:[~2019-09-18 23:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 21:55 [PATCH] clk: ti: clkctrl: Fix hidden dependency to node name with reg-names Tony Lindgren
2019-09-07 3:55 ` Stephen Boyd
2019-09-08 19:42 ` Tony Lindgren
2019-09-18 18:07 ` Stephen Boyd
2019-09-18 20:53 ` Tony Lindgren
2019-09-18 23:28 ` Stephen Boyd [this message]
2019-09-19 0:01 ` Tony Lindgren
2019-09-19 6:46 ` Tero Kristo
2019-09-19 14:12 ` Tony Lindgren
2019-09-19 16:50 ` Stephen Boyd
2019-09-19 17:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918232842.E2CBB21907@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.