From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v1 1/9] ASoC: wm8994: Do not register inapplicable controls for WM1811 Date: Thu, 19 Sep 2019 09:38:32 +0200 Message-ID: <20190919073832.GA13195@pi3> References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-2-s.nawrocki@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190918104634.15216-2-s.nawrocki@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sylwester Nawrocki Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, ckeepax@opensource.cirrus.com, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com List-Id: devicetree@vger.kernel.org On Wed, Sep 18, 2019 at 12:46:26PM +0200, Sylwester Nawrocki wrote: > In case of WM1811 device there are currently being registered controls > referring to registers not existing on that device. > It has been noticed when getting values of "AIF1ADC2 Volume", "AIF1DAC2 > Volume" controls was failing during ALSA state restoring at boot time: > "amixer: Mixer hw:0 load error: Device or resource busy" > > Reading some registers through I2C was failing with EBUSY error and indeed > those registers were not available according to the datasheet. > > To fix this controls not available on WM1811 are moved to a separate array > and registered only for WM8994 and WM8958. > > There are some further differences between WM8994 and WM1811, e.g. registers > 603h, 604h, 605h, which are not covered in this patch. > > Signed-off-by: Sylwester Nawrocki > --- > sound/soc/codecs/wm8994.c | 43 +++++++++++++++++++++++---------------- > 1 file changed, 26 insertions(+), 17 deletions(-) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27452C3A5A6 for ; Thu, 19 Sep 2019 07:39:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24387222C4 for ; Thu, 19 Sep 2019 07:39:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="BA7t5mNb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24387222C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DEA8D1666; Thu, 19 Sep 2019 09:38:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DEA8D1666 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568878774; bh=Ose4De2dy+Vhbv9x6e0LU+TaOH+VP9XUv6to9bb7aXo=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BA7t5mNbzMThBJExzxCGKIRfv/z3it3ZlSkrocsKatwzj6lYQ7mZOY2l57CCxIvg5 wT3uk7GZgIcTyxc+y2zLbzn0VR2PYJrj3BEKeuKBHNu9ECN3F6YDZ7ukFbZbmPzI0g ojXDgloX6W4oTK9y68I6oAYLQ9ahX86jRVe6ud/k= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0FF07F80307; Thu, 19 Sep 2019 09:38:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4C8B3F80361; Thu, 19 Sep 2019 09:38:40 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1A0F5F80292 for ; Thu, 19 Sep 2019 09:38:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1A0F5F80292 Received: by mail-wm1-f65.google.com with SMTP id 3so2703036wmi.3 for ; Thu, 19 Sep 2019 00:38:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Y6zSWuxS8jgyDbyMqezvXVURezmzAxVKdd2OMOE7VDY=; b=pAdkWG5lxDZfugSx689zy18MuphaxtT1bepLja/FFb2kdaQiQnMXPBdFG9EYRbT56X IUNJ87uGJYepmpl4eBzwQovMq4isgV8uzyDuu/smHKJpD7sLsb6tRhJ1vJ3EMaIgfdir kDE9VcNXqF1uoGXTfGodRfnzhu6eELLmGJJIJIp2Jub2nC1K7iHYDRtqNP5IRoEIhKtL uq/9vkoU8kKN6lv2bpBduOh3RBJhwYKsoH3cbn2saSBjBPGSj2u7CBX91bEgKgewkUja EclTNKOukVzLF3JlgYf5RI5gWIkE2vFYqNjISGtZ1PV9hPXqrI8QVwDcVF+6IaaHJ1PL V4jA== X-Gm-Message-State: APjAAAXgmTYemhUFqgyUBgwb20d9maBqDXdYF680s4T8wFmnUgOks0Mr tr7tbJtv4Wq8FiTJWQlY0ME= X-Google-Smtp-Source: APXvYqzeq1U2LjJ1HD4/VWXclkN5qptlSoaU/lte93RCCam6t7j6L/Q8uKt9u97GzYcvPFW7th/KiA== X-Received: by 2002:a7b:c5ce:: with SMTP id n14mr1515680wmk.17.1568878715640; Thu, 19 Sep 2019 00:38:35 -0700 (PDT) Received: from pi3 ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id t203sm6892411wmf.42.2019.09.19.00.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2019 00:38:34 -0700 (PDT) Date: Thu, 19 Sep 2019 09:38:32 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Message-ID: <20190919073832.GA13195@pi3> References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-2-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190918104634.15216-2-s.nawrocki@samsung.com> User-Agent: Mutt/1.12.1 (2019-06-15) Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, ckeepax@opensource.cirrus.com, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Subject: Re: [alsa-devel] [PATCH v1 1/9] ASoC: wm8994: Do not register inapplicable controls for WM1811 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Sep 18, 2019 at 12:46:26PM +0200, Sylwester Nawrocki wrote: > In case of WM1811 device there are currently being registered controls > referring to registers not existing on that device. > It has been noticed when getting values of "AIF1ADC2 Volume", "AIF1DAC2 > Volume" controls was failing during ALSA state restoring at boot time: > "amixer: Mixer hw:0 load error: Device or resource busy" > > Reading some registers through I2C was failing with EBUSY error and indeed > those registers were not available according to the datasheet. > > To fix this controls not available on WM1811 are moved to a separate array > and registered only for WM8994 and WM8958. > > There are some further differences between WM8994 and WM1811, e.g. registers > 603h, 604h, 605h, which are not covered in this patch. > > Signed-off-by: Sylwester Nawrocki > --- > sound/soc/codecs/wm8994.c | 43 +++++++++++++++++++++++---------------- > 1 file changed, 26 insertions(+), 17 deletions(-) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E211AC3A5A6 for ; Thu, 19 Sep 2019 07:38:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B51B7222C4 for ; Thu, 19 Sep 2019 07:38:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YutwATPH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B51B7222C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tyQaw8v+RhijmE8Igw1wjwakcOKwEr18/pNy2ErBJEw=; b=YutwATPH23++7j JAalzZJElGghd2R3D8ONeRZUFZqWYELHiqy0aMwtVXu7adyFA2YF4VlRNfI7NMwt18x32i+cMkL5w Z3gSbZw0a8fKhmJEOH01q03W2yh3ZIe0xYR66nBVDrZmY4WtBljZT6anaaEYOpcgUdfD4a+pi8DtN CyIzM3zjfZHVIEVoXWkmUzKzJ1/3UW9Sp76JIfoELx0m8xdOOfA2KG2/9GrDHWQYjZAXfx6uVUnLO 40mId4biPif4IeOiK2OktqxEQS5cXqGoOtY2/OnslnZqLNMYI7J2hKrbIwkkQjRG1Pk6eF+zAxmQQ FyBxuVe4S6o6SmxMCGCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAr1U-0004du-Cc; Thu, 19 Sep 2019 07:38:40 +0000 Received: from mail-wm1-f65.google.com ([209.85.128.65]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAr1R-0004dU-Dn for linux-arm-kernel@lists.infradead.org; Thu, 19 Sep 2019 07:38:38 +0000 Received: by mail-wm1-f65.google.com with SMTP id f16so2711648wmb.2 for ; Thu, 19 Sep 2019 00:38:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Y6zSWuxS8jgyDbyMqezvXVURezmzAxVKdd2OMOE7VDY=; b=bLAXub9KaLkBFZGHhXTKpJ/eg1j0FYNJrsRwldyjQ9TFKC9FrRiGPIY6nKn9pJRK4W FXgmDFwBbuel5i1YkEUaE34Efy4Y7OA2QGssVyQtecNgEvWYkX2695l4Qp9WeTBYokTs 643s/zIfP1iHLj8c+iV5sTv4LnrUHMBy6/Bar1BjbYpKVZ5Ic6/XXiGd/2j7VlwrlJ/p jycCQRzGh6GgZV2ILLIUE0coo5YoqKyJTTFf7tRXEIv6tAnUgc4/ppGqmQe8As1UM0pO iOMHCZAKQBjNkTwE0QVH2kyIjlyXL4NNuNezmiM4+Q4t7npRYmyed5g8tTmLoNUfh1iN grww== X-Gm-Message-State: APjAAAXLLczHOwj0Y7bZ0D2aC+vaX56OPE8GIQq01ooJepELczkvRwvD xZ4qfu1mEvJF47hfIW1SNwM= X-Google-Smtp-Source: APXvYqzeq1U2LjJ1HD4/VWXclkN5qptlSoaU/lte93RCCam6t7j6L/Q8uKt9u97GzYcvPFW7th/KiA== X-Received: by 2002:a7b:c5ce:: with SMTP id n14mr1515680wmk.17.1568878715640; Thu, 19 Sep 2019 00:38:35 -0700 (PDT) Received: from pi3 ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id t203sm6892411wmf.42.2019.09.19.00.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2019 00:38:34 -0700 (PDT) Date: Thu, 19 Sep 2019 09:38:32 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Subject: Re: [PATCH v1 1/9] ASoC: wm8994: Do not register inapplicable controls for WM1811 Message-ID: <20190919073832.GA13195@pi3> References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-2-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190918104634.15216-2-s.nawrocki@samsung.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190919_003837_469564_A0D73236 X-CRM114-Status: GOOD ( 14.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, ckeepax@opensource.cirrus.com, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 18, 2019 at 12:46:26PM +0200, Sylwester Nawrocki wrote: > In case of WM1811 device there are currently being registered controls > referring to registers not existing on that device. > It has been noticed when getting values of "AIF1ADC2 Volume", "AIF1DAC2 > Volume" controls was failing during ALSA state restoring at boot time: > "amixer: Mixer hw:0 load error: Device or resource busy" > > Reading some registers through I2C was failing with EBUSY error and indeed > those registers were not available according to the datasheet. > > To fix this controls not available on WM1811 are moved to a separate array > and registered only for WM8994 and WM8958. > > There are some further differences between WM8994 and WM1811, e.g. registers > 603h, 604h, 605h, which are not covered in this patch. > > Signed-off-by: Sylwester Nawrocki > --- > sound/soc/codecs/wm8994.c | 43 +++++++++++++++++++++++---------------- > 1 file changed, 26 insertions(+), 17 deletions(-) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel