From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE08C3A5A6 for ; Thu, 19 Sep 2019 07:59:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03B7C207FC for ; Thu, 19 Sep 2019 07:59:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=osandov-com.20150623.gappssmtp.com header.i=@osandov-com.20150623.gappssmtp.com header.b="Ul06lNEn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388119AbfISH7x (ORCPT ); Thu, 19 Sep 2019 03:59:53 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:41416 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725320AbfISH7w (ORCPT ); Thu, 19 Sep 2019 03:59:52 -0400 Received: by mail-pg1-f195.google.com with SMTP id s1so290861pgv.8 for ; Thu, 19 Sep 2019 00:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=xYzaBzbX2wcXB1TeWPAv6aYBrsqEHonGHaTGJrjyg4c=; b=Ul06lNEn8+13Ctnds6ZvyhqjciDnEpVUAN4abDOAC21P8D2U1xPhfqZzi1+ppdVGFD n3ZmYBzvyH8YDotqAf5AJWJV8i+bQuXTp4EOeXlKLjbuxFkzYqpBandMFYDVlyGXN78B d6mbwFJoJh8WqughJIqLFiFp6yvEIsWmqUq7ewTFIoOBIw+ZIQpfCPlqlTRDNa5UCNkF 7zgKwWfEuh+Hxi7vB/8f2IKPsipSf/x/4Yy7ORTWwIRPZIvgQDkjVxAfz3KcuiMp/R6Z LzGr6L6Hb2eupJDSipHFCy+hXKiixS0YtXhC/YHXJtPieOt7BNupWEoPkX6sVSnFI9fg fwhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=xYzaBzbX2wcXB1TeWPAv6aYBrsqEHonGHaTGJrjyg4c=; b=SVxc/44qux+wIFhTj+Rh/uNyCqhL1tcdwBO5HrcvQPRnISGb1a151yNvA/PcKhj9q+ uBK6SyeeBjozp1quXf9eWkxHtRTW/qHnhv+RdbRQ2DBj2Cuf134OFvTpXcp0cfRqUhjJ Boq13L89cEo6c3MJ9SYKhhgNgyNsDW291xgRPcllQ4o1xyoo3GZOW5QBCIH6Nc89ENS2 vD20lqawRZETF2PaEae+EPuIUvaey+DgscR9B+x+Jhv+AW+K33n5uLNwoDU1UP8O6tyx N3OK/VnExm/Lu4ZKgB4sXDH5lygXur1Fsf2O6ESS4AsgIfW4vYtj2RUU4Pmai8X3dfTs oEpw== X-Gm-Message-State: APjAAAWb3pYdwB/x5boD0XfMekyoJL0i7ldnArnbX11H1e5FJ8Ojwt17 ens84j6qRX98UI5LxD35aSt4uA== X-Google-Smtp-Source: APXvYqwajJTOyNbm2XXB5KgYMEBD8ntikp49d9Rkb1z8pzFTSIMBNUBQF7HzSnikaP5Sy9uFns2yqQ== X-Received: by 2002:a63:741a:: with SMTP id p26mr7805828pgc.177.1568879991805; Thu, 19 Sep 2019 00:59:51 -0700 (PDT) Received: from vader ([2601:602:8b80:8e0:e6a7:a0ff:fe0b:c9a8]) by smtp.gmail.com with ESMTPSA id z20sm5575332pjn.12.2019.09.19.00.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2019 00:59:51 -0700 (PDT) Date: Thu, 19 Sep 2019 00:59:52 -0700 From: Omar Sandoval To: Nikolay Borisov Cc: kernel-team@fb.com, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/2] btrfs: add ioctl for directly writing compressed data Message-ID: <20190919075952.GA121676@vader> References: <8eae56abb90c0fe87c350322485ce8674e135074.1567623877.git.osandov@fb.com> <652f5971-2c82-e766-fde4-2076e65cf948@suse.com> <20190919061404.GA105652@vader> <625001e7-dd04-0550-cbb0-7437fe901944@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <625001e7-dd04-0550-cbb0-7437fe901944@suse.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Sep 19, 2019 at 09:46:31AM +0200, Nikolay Borisov wrote: > > > On 19.09.19 г. 9:14 ч., Omar Sandoval wrote: > > On Thu, Sep 05, 2019 at 01:33:56PM +0300, Nikolay Borisov wrote: > > > > >> > >> Won't btrfs_lock_and_flush_ordered_range suffice here? Perhaps call that > >> function + invalidate_inode_pages2_range ? > > > > No, btrfs_lock_and_flush_ordered_range() doesn't write out dirty pages, > > so it's not sufficient here. > > But it does - it calls btrfs_start_ordered_extent which calls > filemap_fdatawrite_range. It only calls that for ranges which already have an ordered extent, which we don't create until we're writing the dirty pages out (take a look at where we call btrfs_add_ordered_extent()).