From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v1 5/9] ASoC: samsung: arndale: Simplify DAI link initialization Date: Thu, 19 Sep 2019 10:01:31 +0200 Message-ID: <20190919080131.GD13195@pi3> References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-6-s.nawrocki@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190918104634.15216-6-s.nawrocki@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sylwester Nawrocki Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, ckeepax@opensource.cirrus.com, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com List-Id: devicetree@vger.kernel.org On Wed, Sep 18, 2019 at 12:46:30PM +0200, Sylwester Nawrocki wrote: > There is only one DAI link so we can drop an unnecessary loop statement. > Use card->dai_link in place of direct static arndale_rt5631_dai[] array > dereference as a prerequisite for adding support for other CODECs. > Unnecessary assignment of dai_link->codecs->name to NULL is removed. > > Signed-off-by: Sylwester Nawrocki > --- > sound/soc/samsung/arndale_rt5631.c | 42 ++++++++++++------------------ > 1 file changed, 17 insertions(+), 25 deletions(-) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A86DAC3A5A6 for ; Thu, 19 Sep 2019 08:02:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31D8E217D6 for ; Thu, 19 Sep 2019 08:02:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="JW47p/bW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31D8E217D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 30720166C; Thu, 19 Sep 2019 10:01:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 30720166C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568880161; bh=pULAgNhlaSudAG0g9pfqa0stf3Usb6KtFfObU11QYjU=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JW47p/bWIWJEx81BlMmNg2F6uRa/nSIPGvovYT8zzgzp213Ub4NTJ67FKSdipFKzf GOMRfS9I1Zj+h9C0qCFM+huQ/U2+e0Z7/WZsOYhCrfJvrEtj/b0PBDe2gnEhevIVVz YHCT/t4dS6avpGDC5RLWF1621hBSF0EUuu9VGtWY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AD7F1F80361; Thu, 19 Sep 2019 10:01:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9ED98F803D6; Thu, 19 Sep 2019 10:01:43 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 56907F80307 for ; Thu, 19 Sep 2019 10:01:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 56907F80307 Received: by mail-wm1-f66.google.com with SMTP id 3so2783949wmi.3 for ; Thu, 19 Sep 2019 01:01:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9l/Q4EUeY/MLFd+AQm4TkiqnhshHiOklBHU3BARdFdE=; b=oT5nJ7xVRM50e50Jl9jblwUevdembNw8UYiFZ8LpAnaNs0eSRN1gvaDn+xZw86N4rk toLPcrHB6cPaidqwzh3ak/jlvLP6n78juH/EjREYxkj6MdZzvnmHVLTMdXczVpKLLYTT Xi2J0LqWnDKKnWM0wgax5bAS4Pk0AsiU761i5chUXKNseip26PHKS8hH1achC4mE6npG f+hoVCY1f+5UfrhqtsTPvwOAqD/cfe8cT5pgBJJQfrkVZfE1hVzQp6ATvY777mRndWuM 23uHbbheipkJbSPedYapXSt2Pa2OTZZ92INpVlkkKmwo2AOIoIbPmDLstiZp6nbV7zw4 1IIw== X-Gm-Message-State: APjAAAXXUG+JaB03fj+oh7tjVlXDwwm0jg+dwkixIbxzLO90kMmieKL9 bC/oCvspLxB5jipi0KrXfIk= X-Google-Smtp-Source: APXvYqwkmLUV4hPJJcWaqDDccNR6SsgGU7jssMHyEYDdwsyrDM+pO+zL1vqcxlXKfE+aZippLMXTaw== X-Received: by 2002:a05:600c:291c:: with SMTP id i28mr1559297wmd.98.1568880094991; Thu, 19 Sep 2019 01:01:34 -0700 (PDT) Received: from pi3 ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id u10sm15352265wrg.55.2019.09.19.01.01.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2019 01:01:33 -0700 (PDT) Date: Thu, 19 Sep 2019 10:01:31 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Message-ID: <20190919080131.GD13195@pi3> References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-6-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190918104634.15216-6-s.nawrocki@samsung.com> User-Agent: Mutt/1.12.1 (2019-06-15) Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, ckeepax@opensource.cirrus.com, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Subject: Re: [alsa-devel] [PATCH v1 5/9] ASoC: samsung: arndale: Simplify DAI link initialization X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Sep 18, 2019 at 12:46:30PM +0200, Sylwester Nawrocki wrote: > There is only one DAI link so we can drop an unnecessary loop statement. > Use card->dai_link in place of direct static arndale_rt5631_dai[] array > dereference as a prerequisite for adding support for other CODECs. > Unnecessary assignment of dai_link->codecs->name to NULL is removed. > > Signed-off-by: Sylwester Nawrocki > --- > sound/soc/samsung/arndale_rt5631.c | 42 ++++++++++++------------------ > 1 file changed, 17 insertions(+), 25 deletions(-) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAAEBC4CEC4 for ; Thu, 19 Sep 2019 08:01:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DE8D217D6 for ; Thu, 19 Sep 2019 08:01:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZFDDvwqd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DE8D217D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xpYpIa93yM4yNzdIbBaItVjigdvPRbgqQ0z+JadCA80=; b=ZFDDvwqdLj8256 TiKMS69gKav1LjgzjQYlFSdWFo01Qv/sU6EwwrF21PXkXlhSukv16daaChTmR5M85Kl/k1xkodywz nr98d9jxDkbfJBUwJvvFcBwme6SJ8rtwlQat6sygf3/rufWJ8tQHCD6Q1YyNv23K9B4oDzi0Lo1X/ U4MIG6hVFwoIWGbVEzLU27ZrUh0kFEVUaLX5++SIJJaXE7oc1LnGmmETmHc++5bp4pFQkV0QWuzqR tGWm0eEW4VrBMeWjIAZh7KL6G57RQuc7vPnZVs6fJM4ZLSXskl6dadLTvtcqJa1UbTck6forIpLKS LXEiajJheDFvdhnm3ogA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iArNl-0005lA-Nl; Thu, 19 Sep 2019 08:01:41 +0000 Received: from mail-wm1-f67.google.com ([209.85.128.67]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iArNh-0005ie-I8 for linux-arm-kernel@lists.infradead.org; Thu, 19 Sep 2019 08:01:39 +0000 Received: by mail-wm1-f67.google.com with SMTP id b24so2763533wmj.5 for ; Thu, 19 Sep 2019 01:01:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9l/Q4EUeY/MLFd+AQm4TkiqnhshHiOklBHU3BARdFdE=; b=aFYNjyi1bpD4zDOo6VWRruxI1piOuLnaTC1t1DUnDGw7AFuKVjuV/D8KFSUsF5DAH2 hJmgy7mg8IAn8ld85OZXA0OF/39G3uerWOuwQ9MB8KYUYUuBOXFO2/N3kBS7fHv3moAF aJldwuDJTolJNNRmziAocZbDDobgviuLPh7YoMFNZh/qQeVwm7555HRINwmx/KpTgUlX jmnWD5K1R/ayLp4tSreuhZ7UD7XmDj3Aa5oJty/7BZhlpJv71XuVsLwjhYzvlc8uCTbC glxivUrzS0G7TjLkZ9Am1fqxmGXtUEXmPptpMwFowBIfhpZRO89wyy8MvhkpEBqPAA12 9IxQ== X-Gm-Message-State: APjAAAXlqYoVMrWafgFfe2zWFmYsDRo53ksLXduuEIzUYJGAtBoU8M3E Bn0NCPFEN+mIyrNQ+GYDkJk= X-Google-Smtp-Source: APXvYqwkmLUV4hPJJcWaqDDccNR6SsgGU7jssMHyEYDdwsyrDM+pO+zL1vqcxlXKfE+aZippLMXTaw== X-Received: by 2002:a05:600c:291c:: with SMTP id i28mr1559297wmd.98.1568880094991; Thu, 19 Sep 2019 01:01:34 -0700 (PDT) Received: from pi3 ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id u10sm15352265wrg.55.2019.09.19.01.01.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2019 01:01:33 -0700 (PDT) Date: Thu, 19 Sep 2019 10:01:31 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Subject: Re: [PATCH v1 5/9] ASoC: samsung: arndale: Simplify DAI link initialization Message-ID: <20190919080131.GD13195@pi3> References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-6-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190918104634.15216-6-s.nawrocki@samsung.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190919_010137_871419_F672AAC7 X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, ckeepax@opensource.cirrus.com, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 18, 2019 at 12:46:30PM +0200, Sylwester Nawrocki wrote: > There is only one DAI link so we can drop an unnecessary loop statement. > Use card->dai_link in place of direct static arndale_rt5631_dai[] array > dereference as a prerequisite for adding support for other CODECs. > Unnecessary assignment of dai_link->codecs->name to NULL is removed. > > Signed-off-by: Sylwester Nawrocki > --- > sound/soc/samsung/arndale_rt5631.c | 42 ++++++++++++------------------ > 1 file changed, 17 insertions(+), 25 deletions(-) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel