From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH v1 2/9] mfd: wm8994: Add support for MCLKn clock control Date: Thu, 19 Sep 2019 14:31:16 +0000 Message-ID: <20190919143116.GL10204@ediswmail.ad.cirrus.com> References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-3-s.nawrocki@samsung.com> <20190919075924.GB13195@pi3> <20190919125020.GJ3642@sirena.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190919125020.GJ3642@sirena.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mark Brown Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, lgirdwood@gmail.com, Krzysztof Kozlowski , robh+dt@kernel.org, Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com List-Id: devicetree@vger.kernel.org On Thu, Sep 19, 2019 at 01:50:20PM +0100, Mark Brown wrote: > On Thu, Sep 19, 2019 at 09:59:24AM +0200, Krzysztof Kozlowski wrote: > > On Wed, Sep 18, 2019 at 12:46:27PM +0200, Sylwester Nawrocki wrote: > > > The WM1811/WM8994/WM8958 audio CODEC DT bindings specify two optional > > > clocks: "MCLK1", "MCLK2". Add code for getting those clocks in the MFD > > > part of the wm8994 driver so they can be further handled in the audio > > > CODEC part. > > > I think these are needed only for the codec so how about getting them in > > codec's probe? > > Yeah. IIRC when these were added a machine driver was grabbing them. I > don't think that machine driver ever made it's way upstream though. If you mean for the Arizona stuff, the machine driver using that was sound/soc/samsung/tm2_wm5110.c. Sylwester upstreamed it along with the patches. I think on wm8994 the clocks probably are only needed by the audio part of the driver, so probably can be moved in there, although as a disclaimer I have done a lot less with parts of that era. However on Arizona the clocking is needed from various parts of the driver so couldn't be moved exclusively to the codec driver. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53350C3A5A6 for ; Thu, 19 Sep 2019 14:32:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDA4E2067B for ; Thu, 19 Sep 2019 14:32:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="AFZKWblV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="J9buVC0Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDA4E2067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id ED1781673; Thu, 19 Sep 2019 16:31:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz ED1781673 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568903537; bh=raE76SwMH9w9qXrll75B0oXLsTnbPPrLnJlgoYeAtaI=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AFZKWblVasQGUiY5CNJnVVGFF/ZVrzK6tycEaGyoaucvlg3rXNu0nSx9ayHXKMKHH 51NFt9Fikw+kIAwzXrPDYtTPoV++gJ3wAql4qmsaZEy9tujYjJOsJFvFHyXg7KkLxP TiFWJ/qL7hl00LMAX47SIN/sZwCDKCbfSwuQai70= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 79EF4F80307; Thu, 19 Sep 2019 16:31:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C6058F80361; Thu, 19 Sep 2019 16:31:25 +0200 (CEST) Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BDDC5F80307 for ; Thu, 19 Sep 2019 16:31:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BDDC5F80307 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="J9buVC0Z" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8JETFWh020368; Thu, 19 Sep 2019 09:31:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=PupjcNRQ2lxRP0e4ia7WEj2POWDctVOG0nBQBB08VYk=; b=J9buVC0Zz24St63xLUxx42wcaPWcFSJ06NxtMhirEAqaTpZowp4vkWR5cyxEhD72qaHS 3TC0FbJNBs9vblA8iPqYlUzVKbJbU8h3HPyGK22qQEmqOnrx5OrzgICPi8MZV9bkw7Zd MyF8HadxeGI/zSooHeNn7CVWfP5YJk28OpEwNECWgPcoXdswkiCGwTiRMMj9CUGyAaYt maRdCjfHS1q54R3kZ0p1D7Q6PEu0SjGTDTro5S8Ix5D0eCw9+dpLMOTeNz9GfBMfsLtG XBbcorQdVMC6a/kI7lJ2FDP/gZ1fiR35zzOGoP/5x8flkvVYRTsoVDxx8p3Ee/ehlmHo GA== Authentication-Results: ppops.net; spf=fail smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from ediex02.ad.cirrus.com ([87.246.76.36]) by mx0a-001ae601.pphosted.com with ESMTP id 2v3vbhs7sk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 19 Sep 2019 09:31:19 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Thu, 19 Sep 2019 15:31:16 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1591.10 via Frontend Transport; Thu, 19 Sep 2019 15:31:16 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id BD7042C3; Thu, 19 Sep 2019 14:31:16 +0000 (UTC) Date: Thu, 19 Sep 2019 14:31:16 +0000 From: Charles Keepax To: Mark Brown Message-ID: <20190919143116.GL10204@ediswmail.ad.cirrus.com> References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-3-s.nawrocki@samsung.com> <20190919075924.GB13195@pi3> <20190919125020.GJ3642@sirena.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190919125020.GJ3642@sirena.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-SPF-Result: fail X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com include:spf.protection.outlook.com -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 priorityscore=1501 malwarescore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=938 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1909190137 Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, lgirdwood@gmail.com, Krzysztof Kozlowski , robh+dt@kernel.org, Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Subject: Re: [alsa-devel] [PATCH v1 2/9] mfd: wm8994: Add support for MCLKn clock control X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Sep 19, 2019 at 01:50:20PM +0100, Mark Brown wrote: > On Thu, Sep 19, 2019 at 09:59:24AM +0200, Krzysztof Kozlowski wrote: > > On Wed, Sep 18, 2019 at 12:46:27PM +0200, Sylwester Nawrocki wrote: > > > The WM1811/WM8994/WM8958 audio CODEC DT bindings specify two optional > > > clocks: "MCLK1", "MCLK2". Add code for getting those clocks in the MFD > > > part of the wm8994 driver so they can be further handled in the audio > > > CODEC part. > > > I think these are needed only for the codec so how about getting them in > > codec's probe? > > Yeah. IIRC when these were added a machine driver was grabbing them. I > don't think that machine driver ever made it's way upstream though. If you mean for the Arizona stuff, the machine driver using that was sound/soc/samsung/tm2_wm5110.c. Sylwester upstreamed it along with the patches. I think on wm8994 the clocks probably are only needed by the audio part of the driver, so probably can be moved in there, although as a disclaimer I have done a lot less with parts of that era. However on Arizona the clocking is needed from various parts of the driver so couldn't be moved exclusively to the codec driver. Thanks, Charles _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18268C3A5A6 for ; Thu, 19 Sep 2019 14:31:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF0BB2067B for ; Thu, 19 Sep 2019 14:31:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aU4Q6M3X"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="J9buVC0Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF0BB2067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CBl4j8JHicRxfOP+Nn5C4MAsN2EdLkgJvDvtyAFAWig=; b=aU4Q6M3XwNJzC6 4DAosf6ioMBOaXfCr59af0KnCsPTsOozobsAiyq1BJe0A8rGJSa2+zKrZe3+yGflPo77Bu8RriiiB c996SYLyf5Tsi/O1iUSjlbYV+sMjZG/Wg3XZq8+gL0Hgr/grq52nq9bIRK+5Uy12W6G5C7lnjtYEW P+hTsaptkwV6l+f3IUjYHca+OlK0MnlFJ8lF6G3HOQSK7N+kkPebqOf1C1jnJJVXKKI1B3rtRkikw wiyJHIVK8s5rL7G5Y/feGPZ2/UJL2W3dEvCrJ/p6Y9aGhBiu2CZSgzQYJGJP5nMzjNvpORAAyQqKd JSUiJOX7Za8ZGxvxqlhQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAxT1-0004Jf-3q; Thu, 19 Sep 2019 14:31:31 +0000 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25] helo=mx0b-001ae601.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAxSy-0004JF-90 for linux-arm-kernel@lists.infradead.org; Thu, 19 Sep 2019 14:31:29 +0000 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8JETFWh020368; Thu, 19 Sep 2019 09:31:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=PupjcNRQ2lxRP0e4ia7WEj2POWDctVOG0nBQBB08VYk=; b=J9buVC0Zz24St63xLUxx42wcaPWcFSJ06NxtMhirEAqaTpZowp4vkWR5cyxEhD72qaHS 3TC0FbJNBs9vblA8iPqYlUzVKbJbU8h3HPyGK22qQEmqOnrx5OrzgICPi8MZV9bkw7Zd MyF8HadxeGI/zSooHeNn7CVWfP5YJk28OpEwNECWgPcoXdswkiCGwTiRMMj9CUGyAaYt maRdCjfHS1q54R3kZ0p1D7Q6PEu0SjGTDTro5S8Ix5D0eCw9+dpLMOTeNz9GfBMfsLtG XBbcorQdVMC6a/kI7lJ2FDP/gZ1fiR35zzOGoP/5x8flkvVYRTsoVDxx8p3Ee/ehlmHo GA== Authentication-Results: ppops.net; spf=fail smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from ediex02.ad.cirrus.com ([87.246.76.36]) by mx0a-001ae601.pphosted.com with ESMTP id 2v3vbhs7sk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 19 Sep 2019 09:31:19 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Thu, 19 Sep 2019 15:31:16 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1591.10 via Frontend Transport; Thu, 19 Sep 2019 15:31:16 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id BD7042C3; Thu, 19 Sep 2019 14:31:16 +0000 (UTC) Date: Thu, 19 Sep 2019 14:31:16 +0000 From: Charles Keepax To: Mark Brown Subject: Re: [PATCH v1 2/9] mfd: wm8994: Add support for MCLKn clock control Message-ID: <20190919143116.GL10204@ediswmail.ad.cirrus.com> References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-3-s.nawrocki@samsung.com> <20190919075924.GB13195@pi3> <20190919125020.GJ3642@sirena.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190919125020.GJ3642@sirena.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-SPF-Result: fail X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com include:spf.protection.outlook.com -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 priorityscore=1501 malwarescore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=938 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1909190137 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190919_073128_382169_09C8DB11 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, lgirdwood@gmail.com, Krzysztof Kozlowski , robh+dt@kernel.org, Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 19, 2019 at 01:50:20PM +0100, Mark Brown wrote: > On Thu, Sep 19, 2019 at 09:59:24AM +0200, Krzysztof Kozlowski wrote: > > On Wed, Sep 18, 2019 at 12:46:27PM +0200, Sylwester Nawrocki wrote: > > > The WM1811/WM8994/WM8958 audio CODEC DT bindings specify two optional > > > clocks: "MCLK1", "MCLK2". Add code for getting those clocks in the MFD > > > part of the wm8994 driver so they can be further handled in the audio > > > CODEC part. > > > I think these are needed only for the codec so how about getting them in > > codec's probe? > > Yeah. IIRC when these were added a machine driver was grabbing them. I > don't think that machine driver ever made it's way upstream though. If you mean for the Arizona stuff, the machine driver using that was sound/soc/samsung/tm2_wm5110.c. Sylwester upstreamed it along with the patches. I think on wm8994 the clocks probably are only needed by the audio part of the driver, so probably can be moved in there, although as a disclaimer I have done a lot less with parts of that era. However on Arizona the clocking is needed from various parts of the driver so couldn't be moved exclusively to the codec driver. Thanks, Charles _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel