From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E77FC49ED7 for ; Thu, 19 Sep 2019 14:41:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AE542067B for ; Thu, 19 Sep 2019 14:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568904095; bh=TJHkQTtaGQHKS5CUibyY3os9gYsyoVt2bCM2nr2IE3I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=AiE1A9TKaxjnciGicBYtM5ndOUpB/jYqJZprNR7WpW5/WIdejLpNv+Zt9ljd5lWfr 5uER+Jo/gwFj19fpZHkMwg0uhc/5/TcQfDcBZivzv930h6ZR0nzMJTn7BTwspB7Tw4 NsKA//eVzYaqdo0OQc1kPFkIE+ULGj0hycetPBcU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732680AbfISOla (ORCPT ); Thu, 19 Sep 2019 10:41:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:43520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732606AbfISOla (ORCPT ); Thu, 19 Sep 2019 10:41:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9CEF62067B; Thu, 19 Sep 2019 14:41:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568904089; bh=TJHkQTtaGQHKS5CUibyY3os9gYsyoVt2bCM2nr2IE3I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YK7tcTHra9Le/h5CmSNa6LtWZSL5o4cwJ5rVAf2P+1X+wlsuAy/k+IOGQEI6mrRXo NX6UgrRnJtjB5Tjxdh20rmvLJCYDLM1AjucKjmmdkioeymP65FUmeYdUixedjjrzog rf26ghS7hGTSkoavOfnR5yDqRvo+1cLM2ntxQSpI= Date: Thu, 19 Sep 2019 16:41:26 +0200 From: Greg Kroah-Hartman To: Jerome Pouiller Cc: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , David Le Goff , "David S . Miller" , Kalle Valo Subject: Re: [PATCH v3 00/20] Add support for Silicon Labs WiFi chip WF200 and further Message-ID: <20190919144126.GA3997726@kroah.com> References: <20190919142527.31797-1-Jerome.Pouiller@silabs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190919142527.31797-1-Jerome.Pouiller@silabs.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Sep 19, 2019 at 02:25:36PM +0000, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Hello all, > > This series add support for Silicon Labs WiFi chip WF200 and further: > > https://www.silabs.com/documents/public/data-sheets/wf200-datasheet.pdf > > This driver is an export from: > > https://github.com/SiliconLabs/wfx-linux-driver/ > > I squashed all commits from github (it definitely does not make sense to > import history). Then I split it in comprehensible (at least try to be) > commits. I hope it will help readers to understand driver architecture. > IMHO, firsts commits are clean enough to be reviewed. Things get more > difficult when I introduce mac8011 API. I tried to extract important > parts like Rx/Tx process but, big and complex patches seem unavoidable > in this part. > > Architecture itself is described in commit messages. > > The series below is aligned on version 2.3.1 on github. If compare this > series with github, you will find traditional differences between > external and a in-tree driver: Documentation, build infrastructure, > compatibility with older kernel revisions, etc... In add, I dropped all > code in CONFIG_WFX_SECURE_LINK. Indeed, "Secure Link" feature depends > on mbedtls and I don't think to pull mbedtls in kernel is an option > (see "TODO" file in first commit). > > v3: > - Fill commit log of patches 18, 19 and 20 > > v2: > - Add TODO file (and dropped todo list from cover letter) > - Drop code relative to compatibility with older kernels dude, slow down. wait for others to look at this. there's nothing I can do until after 5.4-rc1 is out, so there is no rush at all... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A362FC49ED7 for ; Thu, 19 Sep 2019 14:41:33 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 798512067B for ; Thu, 19 Sep 2019 14:41:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YK7tcTHr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 798512067B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 2BE34847BE; Thu, 19 Sep 2019 14:41:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7uMqXxHoTTgz; Thu, 19 Sep 2019 14:41:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 1FE2A865D3; Thu, 19 Sep 2019 14:41:31 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 0299E1BF23C for ; Thu, 19 Sep 2019 14:41:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id EFE42865D3 for ; Thu, 19 Sep 2019 14:41:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id le3yEOX7nBjm for ; Thu, 19 Sep 2019 14:41:29 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 58F21847BE for ; Thu, 19 Sep 2019 14:41:29 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9CEF62067B; Thu, 19 Sep 2019 14:41:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568904089; bh=TJHkQTtaGQHKS5CUibyY3os9gYsyoVt2bCM2nr2IE3I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YK7tcTHra9Le/h5CmSNa6LtWZSL5o4cwJ5rVAf2P+1X+wlsuAy/k+IOGQEI6mrRXo NX6UgrRnJtjB5Tjxdh20rmvLJCYDLM1AjucKjmmdkioeymP65FUmeYdUixedjjrzog rf26ghS7hGTSkoavOfnR5yDqRvo+1cLM2ntxQSpI= Date: Thu, 19 Sep 2019 16:41:26 +0200 From: Greg Kroah-Hartman To: Jerome Pouiller Subject: Re: [PATCH v3 00/20] Add support for Silicon Labs WiFi chip WF200 and further Message-ID: <20190919144126.GA3997726@kroah.com> References: <20190919142527.31797-1-Jerome.Pouiller@silabs.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190919142527.31797-1-Jerome.Pouiller@silabs.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devel@driverdev.osuosl.org" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , David Le Goff , "David S . Miller" , Kalle Valo Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, Sep 19, 2019 at 02:25:36PM +0000, Jerome Pouiller wrote: > From: J=E9r=F4me Pouiller > = > Hello all, > = > This series add support for Silicon Labs WiFi chip WF200 and further: > = > https://www.silabs.com/documents/public/data-sheets/wf200-datasheet.pdf > = > This driver is an export from: > = > https://github.com/SiliconLabs/wfx-linux-driver/ > = > I squashed all commits from github (it definitely does not make sense to > import history). Then I split it in comprehensible (at least try to be) > commits. I hope it will help readers to understand driver architecture. > IMHO, firsts commits are clean enough to be reviewed. Things get more > difficult when I introduce mac8011 API. I tried to extract important > parts like Rx/Tx process but, big and complex patches seem unavoidable > in this part. > = > Architecture itself is described in commit messages. > = > The series below is aligned on version 2.3.1 on github. If compare this > series with github, you will find traditional differences between > external and a in-tree driver: Documentation, build infrastructure, > compatibility with older kernel revisions, etc... In add, I dropped all > code in CONFIG_WFX_SECURE_LINK. Indeed, "Secure Link" feature depends > on mbedtls and I don't think to pull mbedtls in kernel is an option > (see "TODO" file in first commit). > = > v3: > - Fill commit log of patches 18, 19 and 20 > = > v2: > - Add TODO file (and dropped todo list from cover letter) > - Drop code relative to compatibility with older kernels dude, slow down. wait for others to look at this. there's nothing I can do until after 5.4-rc1 is out, so there is no rush at all... thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel