From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3666BC4CEC4 for ; Thu, 19 Sep 2019 17:07:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18DE62196E for ; Thu, 19 Sep 2019 17:07:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391852AbfISRHQ (ORCPT ); Thu, 19 Sep 2019 13:07:16 -0400 Received: from verein.lst.de ([213.95.11.211]:42808 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390733AbfISRHQ (ORCPT ); Thu, 19 Sep 2019 13:07:16 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B3C0968BE1; Thu, 19 Sep 2019 19:07:11 +0200 (CEST) Date: Thu, 19 Sep 2019 19:07:11 +0200 From: Christoph Hellwig To: Linus Torvalds Cc: "Darrick J. Wong" , "Darrick J. Wong" , linux-fsdevel , linux-xfs , Dave Chinner , Linux Kernel Mailing List , Eric Sandeen , Christoph Hellwig , Andreas Gruenbacher , Bob Peterson , cluster-devel Subject: Re: [GIT PULL] iomap: new code for 5.4 Message-ID: <20190919170711.GA9065@lst.de> References: <20190917152140.GU2229799@magnolia> <20190919034502.GJ2229799@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 19, 2019 at 10:03:30AM -0700, Linus Torvalds wrote: > It's just that we've survived three decades without that list_pop(), > and I don't want to make our header files even bigger and more complex > unless we actually have multiple real users. I personally surived with it, but really hated writing the open coded list_for_each_entry + list_del or while list_first_entry_or_null + ┐ist_del when I could have a nice primitive for it. I finally decided to just add that helper.. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Thu, 19 Sep 2019 19:07:11 +0200 Subject: [Cluster-devel] [GIT PULL] iomap: new code for 5.4 In-Reply-To: References: <20190917152140.GU2229799@magnolia> <20190919034502.GJ2229799@magnolia> Message-ID: <20190919170711.GA9065@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Sep 19, 2019 at 10:03:30AM -0700, Linus Torvalds wrote: > It's just that we've survived three decades without that list_pop(), > and I don't want to make our header files even bigger and more complex > unless we actually have multiple real users. I personally surived with it, but really hated writing the open coded list_for_each_entry + list_del or while list_first_entry_or_null + ?ist_del when I could have a nice primitive for it. I finally decided to just add that helper..