From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6581EC49ED7 for ; Thu, 19 Sep 2019 22:26:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B5C220640 for ; Thu, 19 Sep 2019 22:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568932013; bh=xTImHa+Fw+hcY0JKhsE+/yBCH+214SuUveX5vVfK+MQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GUOD5QDQ/JIAcx+b3ltgylNJNbtj2ZPKXPLd4MAu+dZs3zaNsIZhV0llygHj2C+7m DVZfi0o5amWUmGcjVjSYusk3k1l1mxZ1Exk7tlFewyXgRvFMkTylS+4KOApFDBuXut BfpCfd4XIlnO6YNYkjOQsBjqY6jTTDU9kpv7FxOY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394226AbfISW0w (ORCPT ); Thu, 19 Sep 2019 18:26:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:36332 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394064AbfISWVn (ORCPT ); Thu, 19 Sep 2019 18:21:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 842DD21929; Thu, 19 Sep 2019 22:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568931703; bh=xTImHa+Fw+hcY0JKhsE+/yBCH+214SuUveX5vVfK+MQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h63iTYV13MD7jJJCrNWzH2wnE/VEQxjiKiKDzafch1EwGTrg3XQKDtmyVuQD2Fbh1 QPYvJFX6xY2Qk0g4KmK7DGYYiiUWbHFF4bjkbGvYCcSqNZ9v802ufdsfWFPB73f1I9 cWunprg+BE1YdaMJX8c7WHPbxhqp9vx8NSxdfGE8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nikolay Aleksandrov , Nicolas Dichtel , "David S. Miller" Subject: [PATCH 4.4 01/56] bridge/mdb: remove wrong use of NLM_F_MULTI Date: Fri, 20 Sep 2019 00:03:42 +0200 Message-Id: <20190919214743.107531741@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919214742.483643642@linuxfoundation.org> References: <20190919214742.483643642@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicolas Dichtel [ Upstream commit 94a72b3f024fc7e9ab640897a1e38583a470659d ] NLM_F_MULTI must be used only when a NLMSG_DONE message is sent at the end. In fact, NLMSG_DONE is sent only at the end of a dump. Libraries like libnl will wait forever for NLMSG_DONE. Fixes: 949f1e39a617 ("bridge: mdb: notify on router port add and del") CC: Nikolay Aleksandrov Signed-off-by: Nicolas Dichtel Acked-by: Nikolay Aleksandrov Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/bridge/br_mdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -256,7 +256,7 @@ static int nlmsg_populate_rtr_fill(struc struct nlmsghdr *nlh; struct nlattr *nest; - nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), NLM_F_MULTI); + nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), 0); if (!nlh) return -EMSGSIZE;