All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: mingo@kernel.org
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	brendanhiggins@google.com, torvalds@linux-foundation.org,
	rdunlap@infradead.org
Subject: Re: [GIT PULL] Kselftest update for Linux 5.4-rc1
Date: Sun, 22 Sep 2019 15:29:36 +0300	[thread overview]
Message-ID: <20190922122936.GA31964@avx2> (raw)

> Beyond the muscle memory aspect, nonsensical naming and inanely flat file
> hierarchies annoy kernel developers

Flat(ish) file hierarchies are good -- less typing.
If you're copy-pasting then it doesn't matter much (it still matters a
little because long filename occupy more space on the screen and in logs).

> makes it harder for newbies to understand the kernel source as well.

That's fine too.

>   drwxr-xr-x    crypto          # move to kernel/crypto/ or security/crypto/

No, crypto/ is fine.

If everything arch independent should live at kernel/ then why should kernel/
exist at all? It should be trimmed and everything moved to the top level
directory (OK, I'm not really suggesting that).

>   drwxr-xr-x    ipc             # move to kernel/ipc/

No, same reason. It was there since time immemorial.

>   drwxr-xr-x    samples         # move to Documentation/samples/

Just delete it. Best API usage samples are in modern parts of main tree,
actively maintained/updated.

>  drwxr-xr-x    scripts         # move to build/scripts/

eh

> drwxr-xr-x    sound           # move to drivers/sound/

NO! it has hw independent part and pretty big one.

>  drwxr-xr-x    tools

If tools/ people could somewhow stop duplicating large parts of include/linux
and arch/x86/include/asm it will be very much appreciated.

>  - 'block' could in principle move to drivers/block/core/ but it's fine
>    at the top level too I think.

It is fine indeed. Short name, top level dir, arch and hw independent
code -- it is perfect.

> I'm volunteering to do this (in a scripted, repeatable, reviewable,
> tweakable and "easy to execute in a quiet moment" fashion), although
> I also expect you to balk at the churn. :-)

Can I pay you $100 to not do this ever?

In Russia we say "what has grown has grown" and it is not like Linux is
perfect example of intelligent design.

             reply	other threads:[~2019-09-22 12:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-22 12:29 Alexey Dobriyan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-09-23 22:40 [GIT PULL] Kselftest update for Linux 5.4-rc1 Shuah Khan
2019-09-26 20:10 ` pr-tracker-bot
2019-09-17 19:26 Shuah Khan
2019-09-20 16:17 ` Linus Torvalds
2019-09-20 16:26   ` Randy Dunlap
     [not found]   ` <CAKRRn-edxk9Du70A27V=d3Na73fh=fVvGEVsQRGROrQm05YRrA@mail.gmail.com>
2019-09-20 16:35     ` Brendan Higgins
2019-09-20 16:51       ` Linus Torvalds
2019-09-20 18:03         ` Brendan Higgins
2019-09-20 18:14           ` Linus Torvalds
2019-09-20 18:16             ` Brendan Higgins
2019-09-20 18:06         ` Shuah Khan
2019-09-22 11:25         ` Ingo Molnar
2019-09-22 11:52           ` Greg KH
2019-09-23 14:44             ` Shuah Khan
2019-09-23 19:43               ` Ingo Molnar
2019-09-23 19:52                 ` Randy Dunlap
2019-09-23 20:29                   ` Shuah Khan
2019-09-23 20:53                     ` Ingo Molnar
2019-09-23 21:11                       ` Shuah Khan
2019-09-23 23:54           ` Tim.Bird
2019-09-24  8:07             ` Ingo Molnar
2019-09-26 12:52           ` David Sterba
2019-09-27 13:52           ` Pavel Machek
2019-10-03  9:08           ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190922122936.GA31964@avx2 \
    --to=adobriyan@gmail.com \
    --cc=brendanhiggins@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.