From: Gwendal Grignou <gwendal@chromium.org> To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, lee.jones@linaro.org, bleung@chromium.org, enric.balletbo@collabora.com, dianders@chromium.org, groeck@chromium.org, fabien.lahoudere@collabora.com Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Gwendal Grignou <gwendal@chromium.org> Subject: [PATCH 01/13] mfd: cros_ec: Add sensor_count and make check_features public Date: Sun, 22 Sep 2019 10:50:09 -0700 [thread overview] Message-ID: <20190922175021.53449-2-gwendal@chromium.org> (raw) In-Reply-To: <20190922175021.53449-1-gwendal@chromium.org> Add a new function to return the number of MEMS sensors available in a ChromeOS Embedded Controller. It uses MOTIONSENSE_CMD_DUMP if available or a specific memory map ACPI registers to find out. Also, make check_features public as it can be useful for other drivers to know whant the Embedded Controller supports. Signed-off-by: Gwendal Grignou <gwendal@chromium.org> --- drivers/mfd/cros_ec_dev.c | 61 ++++++++++++++++++++++++++++++++++++- include/linux/mfd/cros_ec.h | 17 +++++++++++ 2 files changed, 77 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 6e6dfd6c1871..3be80183ccaa 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -112,7 +112,7 @@ static const struct mfd_cell cros_ec_vbc_cells[] = { { .name = "cros-ec-vbc", } }; -static int cros_ec_check_features(struct cros_ec_dev *ec, int feature) +int cros_ec_check_features(struct cros_ec_dev *ec, int feature) { struct cros_ec_command *msg; int ret; @@ -143,12 +143,71 @@ static int cros_ec_check_features(struct cros_ec_dev *ec, int feature) return ec->features[feature / 32] & EC_FEATURE_MASK_0(feature); } +EXPORT_SYMBOL_GPL(cros_ec_check_features); static void cros_ec_class_release(struct device *dev) { kfree(to_cros_ec_dev(dev)); } +int cros_ec_get_sensor_count(struct cros_ec_dev *ec) +{ + /* + * Issue a command to get the number of sensor reported. + * If not supported, check for legacy mode. + */ + int ret, sensor_count; + struct ec_params_motion_sense *params; + struct ec_response_motion_sense *resp; + struct cros_ec_command *msg; + struct cros_ec_device *ec_dev = ec->ec_dev; + u8 status; + + msg = kzalloc(sizeof(struct cros_ec_command) + + max(sizeof(*params), sizeof(*resp)), GFP_KERNEL); + if (msg == NULL) + return -ENOMEM; + + msg->version = 1; + msg->command = EC_CMD_MOTION_SENSE_CMD + ec->cmd_offset; + msg->outsize = sizeof(*params); + msg->insize = sizeof(*resp); + + params = (struct ec_params_motion_sense *)msg->data; + params->cmd = MOTIONSENSE_CMD_DUMP; + + ret = cros_ec_cmd_xfer(ec->ec_dev, msg); + if (ret < 0) { + sensor_count = ret; + } else if (msg->result != EC_RES_SUCCESS) { + sensor_count = -EPROTO; + } else { + resp = (struct ec_response_motion_sense *)msg->data; + sensor_count = resp->dump.sensor_count; + } + kfree(msg); + + /* + * Check legacy mode: Let's find out if sensors are accessible + * via LPC interface. + */ + if (sensor_count == -EPROTO && + ec->cmd_offset == 0 && + ec_dev->cmd_readmem) { + ret = ec_dev->cmd_readmem(ec_dev, EC_MEMMAP_ACC_STATUS, + 1, &status); + if ((ret >= 0) && + (status & EC_MEMMAP_ACC_STATUS_PRESENCE_BIT)) { + /* + * We have 2 sensors, one in the lid, one in the base. + */ + sensor_count = 2; + } + } + return sensor_count; +} +EXPORT_SYMBOL_GPL(cros_ec_get_sensor_count); + static void cros_ec_sensors_register(struct cros_ec_dev *ec) { /* diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h index 61c2875c2a40..578e0bbcafdc 100644 --- a/include/linux/mfd/cros_ec.h +++ b/include/linux/mfd/cros_ec.h @@ -32,4 +32,21 @@ struct cros_ec_dev { #define to_cros_ec_dev(dev) container_of(dev, struct cros_ec_dev, class_dev) +/** + * cros_ec_check_features - Test for the presence of EC features + * + * Call this function to test whether the ChromeOS EC supports a feature. + * + * @ec_dev: EC device + * @msg: One of ec_feature_code values + * @return: 1 if supported, 0 if not + */ +int cros_ec_check_features(struct cros_ec_dev *ec, int feature); + +/* + * Return the number of MEMS sensors supported. + * Return < 0 in case of error. + */ +int cros_ec_get_sensor_count(struct cros_ec_dev *ec); + #endif /* __LINUX_MFD_CROS_EC_H */ -- 2.23.0.351.gc4317032e6-goog
next prev parent reply other threads:[~2019-09-22 17:52 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-22 17:50 [PATCH 00/13] cros_ec: Add sensorhub driver and FIFO processing Gwendal Grignou 2019-09-22 17:50 ` Gwendal Grignou [this message] 2019-09-30 13:15 ` [PATCH 01/13] mfd: cros_ec: Add sensor_count and make check_features public Enric Balletbo i Serra 2019-09-30 16:24 ` Gwendal Grignou 2019-10-05 15:26 ` Jonathan Cameron 2019-09-22 17:50 ` [PATCH 02/13] platform: cros_ec: Add cros_ec_sensor_hub driver Gwendal Grignou 2019-10-01 10:31 ` Enric Balletbo i Serra 2019-10-05 15:35 ` Jonathan Cameron 2019-10-05 15:36 ` Jonathan Cameron 2019-09-22 17:50 ` [PATCH 03/13] platform/mfd:iio: cros_ec: Register sensor through sensorhub Gwendal Grignou 2019-10-05 15:41 ` Jonathan Cameron 2019-09-22 17:50 ` [PATCH 04/13] platform: chrome: cros-ec: record event timestamp in the hard irq Gwendal Grignou 2019-10-01 10:32 ` Enric Balletbo i Serra 2019-10-05 15:44 ` Jonathan Cameron 2019-09-22 17:50 ` [PATCH 05/13] platform: chrome: cros_ec: Do not attempt to register a non-positive IRQ number Gwendal Grignou 2019-10-01 10:32 ` Enric Balletbo i Serra 2019-09-22 17:50 ` [PATCH 06/13] platform: chrome: cros_ec: handle MKBP more events flag Gwendal Grignou 2019-10-01 10:32 ` Enric Balletbo i Serra 2019-10-05 15:52 ` Jonathan Cameron 2019-09-22 17:50 ` [PATCH 07/13] platform: chrome: sensorhub: Add FIFO support Gwendal Grignou 2019-10-05 16:08 ` Jonathan Cameron 2019-10-05 16:14 ` Jonathan Cameron 2019-09-22 17:50 ` [PATCH 08/13] platform: chrome: sensorhub: Add code to spread timestmap Gwendal Grignou 2019-10-05 16:16 ` Jonathan Cameron 2019-09-22 17:50 ` [PATCH 09/13] platform: chrome: sensorhub: Add median filter Gwendal Grignou 2019-10-05 16:24 ` Jonathan Cameron 2019-09-22 17:50 ` [PATCH 10/13] iio: cros_ec: Use triggered buffer only when EC does not support FIFO Gwendal Grignou 2019-10-05 16:30 ` Jonathan Cameron 2019-09-22 17:50 ` [PATCH 11/13] iio: cros_ec: Expose hwfifo_timeout Gwendal Grignou 2019-10-05 16:35 ` Jonathan Cameron 2019-09-22 17:50 ` [PATCH 12/13] iio: cros_ec: Report hwfifo_watermark_max Gwendal Grignou 2019-10-05 16:37 ` Jonathan Cameron 2019-09-22 17:50 ` [PATCH 13/13] iio: cros_ec: Use Hertz as unit for sampling frequency Gwendal Grignou 2019-10-05 16:39 ` Jonathan Cameron 2019-10-05 15:39 ` [PATCH 00/13] cros_ec: Add sensorhub driver and FIFO processing Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190922175021.53449-2-gwendal@chromium.org \ --to=gwendal@chromium.org \ --cc=bleung@chromium.org \ --cc=dianders@chromium.org \ --cc=enric.balletbo@collabora.com \ --cc=fabien.lahoudere@collabora.com \ --cc=groeck@chromium.org \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=lee.jones@linaro.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ --subject='Re: [PATCH 01/13] mfd: cros_ec: Add sensor_count and make check_features public' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.