From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 730A1C04EBF for ; Mon, 23 Sep 2019 13:35:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4609320B7C for ; Mon, 23 Sep 2019 13:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569245703; bh=hXQkKliC0S2X43voVjhiTVkMxCC4tIPV9acNAETqUso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CzXqC4gjbGJBX+z+xpkh5DTv/cYXFpduuDy8oOm0dp7qc12WtL/BnLCWuR+Z2lL1R y+4fHG4GZhW2q/mL3XDfVVs2CwzVaArvGRn69IEQFtCt8PJge12DZJ4lCofZQQogbv 6QFy9DNnvmYQm9fKRYwr89/tjXQgf4f0qcOjErAU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408090AbfIWNfC (ORCPT ); Mon, 23 Sep 2019 09:35:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:58664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404581AbfIWNfC (ORCPT ); Mon, 23 Sep 2019 09:35:02 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45C0920820; Mon, 23 Sep 2019 13:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569245701; bh=hXQkKliC0S2X43voVjhiTVkMxCC4tIPV9acNAETqUso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FeeJhFEYpa8NQNgnmMZ03oC875vWZGIk2sDIDJW6viNc1wFklKbOaxWAIJZiDv3z9 VPL+5mYyMBGkryM57asvTYICU4x115rVu0DFVAjBJvQeXxR61BtdSSXkhiv2dR+/em 4ofSqLwfC02dVakvOgrS63rQNTOJczJ7yNnUIGkc= Date: Mon, 23 Sep 2019 09:35:00 -0400 From: Sasha Levin To: Laurent Pinchart Cc: Sakari Ailus , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.3 084/203] media: omap3isp: Don't set streaming state on random subdevs Message-ID: <20190923133500.GF8171@sasha-vm> References: <20190922184350.30563-1-sashal@kernel.org> <20190922184350.30563-84-sashal@kernel.org> <20190923071942.GJ5525@valkosipuli.retiisi.org.uk> <20190923072503.GA5056@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190923072503.GA5056@pendragon.ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2019 at 10:25:03AM +0300, Laurent Pinchart wrote: >On Mon, Sep 23, 2019 at 10:19:42AM +0300, Sakari Ailus wrote: >> Hi Sasha, >> >> On Sun, Sep 22, 2019 at 02:41:50PM -0400, Sasha Levin wrote: >> > From: Sakari Ailus >> > >> > [ Upstream commit 7ef57be07ac146e70535747797ef4aee0f06e9f9 ] >> > >> > The streaming state should be set to the first upstream sub-device only, >> > not everywhere, for a sub-device driver itself knows how to best control >> > the streaming state of its own upstream sub-devices. >> > >> > Signed-off-by: Sakari Ailus >> > Reviewed-by: Laurent Pinchart >> > Signed-off-by: Mauro Carvalho Chehab >> > Signed-off-by: Sasha Levin >> >> I don't disagree with this going to the stable trees as well, but in that >> case it *must* be accompanied by commit e9eb103f0277 ("media: omap3isp: Set >> device on omap3isp subdevs") or the driver will mostly cease to work. >> >> Could you pick that up as well? > >While I don't disagree either, I also think there's no requirement to >get this commit backported to stable branches. It seems to be the result >of a too aggressive auto-selection. I'd very much agree that AUTOSEL is trying to be aggressive with it's patch selection (it's actually sort of like a "dial" I can adjust and now it's adjusted pretty high). However, please don't see it as something that is forced on you; if the maintainers disagree with patch selection please just let me know and it will dropped. The only reason I'm being aggressive with AUTOSEL is that I'm hopefull it will provide better experience for our users. -- Thanks, Sasha