From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E9EC432C1 for ; Tue, 24 Sep 2019 16:45:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C7DD217D9 for ; Tue, 24 Sep 2019 16:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569343511; bh=oZ/CdR4pk54TSdx6nW2duEampafCF/90uNe4q3GZa9I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=R4B/SRhxI8HUaTxxbiaJKyD1KgldD1tGJyDEOhxi8coPmSTXTS6rOKi/JuojKn75u I4XueQsjPEt0H2fUTppkse8wjyY7ueD9DTF9jJY2m719P76KFnGmLcIMma8+fjdESQ kiwFfBNRZeRLCAFsZup+RQO5ykj6f24OtZW6BeTA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2633230AbfIXQpJ (ORCPT ); Tue, 24 Sep 2019 12:45:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:34626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2409942AbfIXQpG (ORCPT ); Tue, 24 Sep 2019 12:45:06 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 71FBA21783; Tue, 24 Sep 2019 16:45:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569343505; bh=oZ/CdR4pk54TSdx6nW2duEampafCF/90uNe4q3GZa9I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aSJ18mwEt4NMbKAZ/DLAYDkZlowLqWnxG3x8UNVTBPYQYWbXCC4Ko1DDzrrSAEuiQ 8IiQ9ed6L6mnmwQ923jY0dlRzuGglrDk3WZZz76D6C1L1HbcDXU7Mue+wc0DtpwOGd nEdgmGzDtSs9nvWrU2BfwlpQbWcO/BkgbAEkc82Q= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Linus Walleij , Mark Brown , Arnd Bergmann , Sasha Levin , devicetree@vger.kernel.org Subject: [PATCH AUTOSEL 5.3 74/87] ARM: dts: dir685: Drop spi-cpol from the display Date: Tue, 24 Sep 2019 12:41:30 -0400 Message-Id: <20190924164144.25591-74-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190924164144.25591-1-sashal@kernel.org> References: <20190924164144.25591-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Walleij [ Upstream commit 2a7326caab479ca257c4b9bd67db42d1d49079bf ] The D-Link DIR-685 had its clock polarity set as active low using the special SPI "spi-cpol" property. This is not correct: the datasheet clearly states: "Fix SCL to GND level when not in use" which is indicative that this line is active high. After a recent fix making the GPIO-based SPI driver force the clock line de-asserted at the beginning of each SPI transaction this reared its ugly head: now de-asserted was taken to mean the line should be driven high, but it should be driven low. Fix this up in the DTS file and the display works again. Link: https://lore.kernel.org/r/20190915135444.11066-1-linus.walleij@linaro.org Cc: Mark Brown Fixes: 2922d1cc1696 ("spi: gpio: Add SPI_MASTER_GPIO_SS flag") Signed-off-by: Linus Walleij Signed-off-by: Arnd Bergmann Signed-off-by: Sasha Levin --- arch/arm/boot/dts/gemini-dlink-dir-685.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/gemini-dlink-dir-685.dts b/arch/arm/boot/dts/gemini-dlink-dir-685.dts index bfaa2de63a100..e2030ba16512f 100644 --- a/arch/arm/boot/dts/gemini-dlink-dir-685.dts +++ b/arch/arm/boot/dts/gemini-dlink-dir-685.dts @@ -72,7 +72,6 @@ reg = <0>; /* 50 ns min period = 20 MHz */ spi-max-frequency = <20000000>; - spi-cpol; /* Clock active low */ vcc-supply = <&vdisp>; iovcc-supply = <&vdisp>; vci-supply = <&vdisp>; -- 2.20.1