From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: robh+dt@kernel.org, devicetree@vger.kernel.org, frowand.list@gmail.com, linux-arm-kernel@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-tegra@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org Cc: mbrugger@suse.com, robin.murphy@arm.com, f.fainelli@gmail.com, james.quinlan@broadcom.com, wahrenst@gmx.net, Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Subject: [PATCH 01/11] of: address: clean-up unused variable in of_dma_get_range() Date: Tue, 24 Sep 2019 20:12:32 +0200 [thread overview] Message-ID: <20190924181244.7159-2-nsaenzjulienne@suse.de> (raw) In-Reply-To: <20190924181244.7159-1-nsaenzjulienne@suse.de> 'len' in of_dma_get_range() is used to check the 'dma-ranges' property length. After the fact, some calculations are run on the variable to be then left unused. Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- drivers/of/address.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/of/address.c b/drivers/of/address.c index 978427a9d5e6..0f898756199d 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -922,7 +922,7 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz { struct device_node *node = of_node_get(np); const __be32 *ranges = NULL; - int len, naddr, nsize, pna; + int naddr, nsize, pna; int ret = 0; u64 dmaaddr; @@ -931,6 +931,7 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz while (1) { struct device_node *parent; + int len; naddr = of_n_addr_cells(node); nsize = of_n_size_cells(node); @@ -962,8 +963,6 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz goto out; } - len /= sizeof(u32); - pna = of_n_addr_cells(node); /* dma-ranges format: -- 2.23.0
WARNING: multiple messages have this Message-ID
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: robh+dt@kernel.org, devicetree@vger.kernel.org, frowand.list@gmail.com, linux-arm-kernel@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-tegra@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org Cc: f.fainelli@gmail.com, mbrugger@suse.com, wahrenst@gmx.net, james.quinlan@broadcom.com, robin.murphy@arm.com, Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Subject: [PATCH 01/11] of: address: clean-up unused variable in of_dma_get_range() Date: Tue, 24 Sep 2019 20:12:32 +0200 [thread overview] Message-ID: <20190924181244.7159-2-nsaenzjulienne@suse.de> (raw) In-Reply-To: <20190924181244.7159-1-nsaenzjulienne@suse.de> 'len' in of_dma_get_range() is used to check the 'dma-ranges' property length. After the fact, some calculations are run on the variable to be then left unused. Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- drivers/of/address.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/of/address.c b/drivers/of/address.c index 978427a9d5e6..0f898756199d 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -922,7 +922,7 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz { struct device_node *node = of_node_get(np); const __be32 *ranges = NULL; - int len, naddr, nsize, pna; + int naddr, nsize, pna; int ret = 0; u64 dmaaddr; @@ -931,6 +931,7 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz while (1) { struct device_node *parent; + int len; naddr = of_n_addr_cells(node); nsize = of_n_size_cells(node); @@ -962,8 +963,6 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz goto out; } - len /= sizeof(u32); - pna = of_n_addr_cells(node); /* dma-ranges format: -- 2.23.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: robh+dt@kernel.org, devicetree@vger.kernel.org, frowand.list@gmail.com, linux-arm-kernel@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-tegra@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org Cc: f.fainelli@gmail.com, mbrugger@suse.com, wahrenst@gmx.net, james.quinlan@broadcom.com, robin.murphy@arm.com, Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Subject: [Xen-devel] [PATCH 01/11] of: address: clean-up unused variable in of_dma_get_range() Date: Tue, 24 Sep 2019 20:12:32 +0200 [thread overview] Message-ID: <20190924181244.7159-2-nsaenzjulienne@suse.de> (raw) In-Reply-To: <20190924181244.7159-1-nsaenzjulienne@suse.de> 'len' in of_dma_get_range() is used to check the 'dma-ranges' property length. After the fact, some calculations are run on the variable to be then left unused. Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- drivers/of/address.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/of/address.c b/drivers/of/address.c index 978427a9d5e6..0f898756199d 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -922,7 +922,7 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz { struct device_node *node = of_node_get(np); const __be32 *ranges = NULL; - int len, naddr, nsize, pna; + int naddr, nsize, pna; int ret = 0; u64 dmaaddr; @@ -931,6 +931,7 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz while (1) { struct device_node *parent; + int len; naddr = of_n_addr_cells(node); nsize = of_n_size_cells(node); @@ -962,8 +963,6 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz goto out; } - len /= sizeof(u32); - pna = of_n_addr_cells(node); /* dma-ranges format: -- 2.23.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-24 18:12 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-24 18:12 [PATCH 00/11] of: Fix DMA configuration for non-DT masters Nicolas Saenz Julienne 2019-09-24 18:12 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne [this message] 2019-09-24 18:12 ` [Xen-devel] [PATCH 01/11] of: address: clean-up unused variable in of_dma_get_range() Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 18:12 ` [PATCH 02/11] of: base: introduce __of_n_*_cells_parent() Nicolas Saenz Julienne 2019-09-24 18:12 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 18:12 ` [PATCH 03/11] of: address: use parent DT node in bus->count_cells() Nicolas Saenz Julienne 2019-09-24 18:12 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 18:12 ` [PATCH 04/11] of: address: introduce of_translate_dma_address_parent() Nicolas Saenz Julienne 2019-09-24 18:12 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 18:12 ` [PATCH 05/11] of: expose __of_get_dma_parent() to OF subsystem Nicolas Saenz Julienne 2019-09-24 18:12 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 18:12 ` [PATCH 06/11] of: address: use parent OF node in of_dma_get_range() Nicolas Saenz Julienne 2019-09-24 18:12 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 18:12 ` [PATCH 07/11] dts: arm64: layerscape: add dma-ranges property to qoric-mc node Nicolas Saenz Julienne 2019-09-24 18:12 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-10-14 8:28 ` Shawn Guo 2019-10-14 8:28 ` [Xen-devel] " Shawn Guo 2019-10-14 8:28 ` Shawn Guo 2019-10-14 10:00 ` Nicolas Saenz Julienne 2019-10-14 10:00 ` [Xen-devel] " Nicolas Saenz Julienne 2019-10-14 10:00 ` Nicolas Saenz Julienne 2019-10-14 11:09 ` Shawn Guo 2019-10-14 11:09 ` [Xen-devel] " Shawn Guo 2019-10-14 11:09 ` Shawn Guo 2019-10-14 11:09 ` Shawn Guo 2019-09-24 18:12 ` [PATCH 08/11] dts: arm64: layerscape: add dma-ranges property to pcie nodes Nicolas Saenz Julienne 2019-09-24 18:12 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-10-14 8:29 ` Shawn Guo 2019-10-14 8:29 ` [Xen-devel] " Shawn Guo 2019-10-14 8:29 ` Shawn Guo 2019-09-24 18:12 ` [PATCH 09/11] of: device: remove comment in of_dma_configure() Nicolas Saenz Julienne 2019-09-24 18:12 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 18:12 ` [PATCH 10/11] of: device: introduce of_dma_configure_parent() Nicolas Saenz Julienne 2019-09-24 18:12 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 18:12 ` [PATCH 11/11] of: simplify of_dma_config()'s arguments Nicolas Saenz Julienne 2019-09-24 18:12 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 18:12 ` Nicolas Saenz Julienne 2019-09-24 21:59 ` [PATCH 00/11] of: Fix DMA configuration for non-DT masters Rob Herring 2019-09-24 21:59 ` [Xen-devel] " Rob Herring 2019-09-24 21:59 ` Rob Herring 2019-09-24 21:59 ` Rob Herring 2019-09-25 14:52 ` Nicolas Saenz Julienne 2019-09-25 14:52 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-25 14:52 ` Nicolas Saenz Julienne 2019-09-25 14:52 ` Nicolas Saenz Julienne 2019-09-25 15:09 ` Robin Murphy 2019-09-25 15:09 ` [Xen-devel] " Robin Murphy 2019-09-25 15:09 ` Robin Murphy 2019-09-25 15:09 ` Robin Murphy 2019-09-25 15:30 ` Nicolas Saenz Julienne 2019-09-25 15:30 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-25 15:30 ` Nicolas Saenz Julienne 2019-09-25 15:30 ` Nicolas Saenz Julienne 2019-09-25 16:16 ` Rob Herring 2019-09-25 16:16 ` [Xen-devel] " Rob Herring 2019-09-25 16:16 ` Rob Herring 2019-09-25 16:16 ` Rob Herring 2019-09-25 16:52 ` Robin Murphy 2019-09-25 16:52 ` [Xen-devel] " Robin Murphy 2019-09-25 16:52 ` Robin Murphy 2019-09-25 16:52 ` Robin Murphy 2019-09-25 21:33 ` Rob Herring 2019-09-25 21:33 ` [Xen-devel] " Rob Herring 2019-09-25 21:33 ` Rob Herring 2019-09-25 21:33 ` Rob Herring 2019-09-26 10:44 ` Nicolas Saenz Julienne 2019-09-26 10:44 ` [Xen-devel] " Nicolas Saenz Julienne 2019-09-26 10:44 ` Nicolas Saenz Julienne 2019-09-26 10:44 ` Nicolas Saenz Julienne 2019-09-26 11:20 ` Robin Murphy 2019-09-26 11:20 ` [Xen-devel] " Robin Murphy 2019-09-26 11:20 ` Robin Murphy 2019-09-26 11:20 ` Robin Murphy 2019-10-02 18:28 ` Florian Fainelli 2019-10-02 18:28 ` [Xen-devel] " Florian Fainelli 2019-10-02 18:28 ` Florian Fainelli 2019-10-02 18:28 ` Florian Fainelli 2019-09-25 16:07 ` Rob Herring 2019-09-25 16:07 ` [Xen-devel] " Rob Herring 2019-09-25 16:07 ` Rob Herring 2019-09-25 16:07 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190924181244.7159-2-nsaenzjulienne@suse.de \ --to=nsaenzjulienne@suse.de \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=etnaviv@lists.freedesktop.org \ --cc=f.fainelli@gmail.com \ --cc=frowand.list@gmail.com \ --cc=james.quinlan@broadcom.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=mbrugger@suse.com \ --cc=robh+dt@kernel.org \ --cc=robin.murphy@arm.com \ --cc=wahrenst@gmx.net \ --cc=xen-devel@lists.xenproject.org \ --subject='Re: [PATCH 01/11] of: address: clean-up unused variable in of_dma_get_range()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.