From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D053AC432C2 for ; Wed, 25 Sep 2019 21:50:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1FCA2146E for ; Wed, 25 Sep 2019 21:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569448209; bh=f2VsHzDgfHKPQJjy5uERfWdkVE2F7Dh1mkiKR8+QDtg=; h=From:To:Cc:Subject:Date:List-ID:From; b=U9b0QDoLYEUVI6YGfBfC4+aEDqTY7yal1PBzcTD7kzWoQDFnqn90pEvERvo8KMA+W PayKM0gEn+XCHiwPiAOA1dS3dB75yuwfXoeZOlDzGzNBqohgnut8ixWJuMhB8llEBL 3r5wGzwUCb0i2J4C0rQ85g7RRZ+ukAsFsHKHgbIY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727810AbfIYVuJ (ORCPT ); Wed, 25 Sep 2019 17:50:09 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:41955 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727054AbfIYVuI (ORCPT ); Wed, 25 Sep 2019 17:50:08 -0400 Received: by mail-ot1-f66.google.com with SMTP id g13so149743otp.8 for ; Wed, 25 Sep 2019 14:50:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6cXLFB02TykvVAB5VHeIiQg5E1YhhmuVezg1VTNWACM=; b=Mr87FURxyUahuC89iivXotmIn3m9jsmffi3rhXRNZ8IdIgXnL/diQe+jBm+8n9PIqR PJ9ihUaiySlzjUZUhs61IRTO0qulcP/lQ0ZQYZ+DgNXNdEBRdPNT1MaeeuOQPjVle92I oSZgkbahIb4Ok2TN0MKBqnRNUjq+UkHoLvW9NRk7R6tWGm81JGB5zz3bN3trCpJO8LNe SWjRwvmyZmIo8ziq0KZQ+odJhydcehQIJ/ZfGsNzaclJYarKndIZ6HrMLCE1kfLwlIfh /03yGK8RZqSpCYkqP3uq4baEnccATioYqSCI5caMyQ2/g9umY8z4jeS5c8LKiAGF0cQW k6oA== X-Gm-Message-State: APjAAAVoNwaAdE+n05X7txQ8GOBysvRx7eBJM/BDt+3PcZsNSaKhcUqu BnHOuv50BaWRBJLvhESQwg== X-Google-Smtp-Source: APXvYqyz7lSYS26abdEhCGr1U2uy0uBmZ56y9Lbe3N7QnPUQ3gDyYFxELSUCIBwmOSdt/05qrxpCYg== X-Received: by 2002:a05:6830:1d8:: with SMTP id r24mr215060ota.217.1569448207485; Wed, 25 Sep 2019 14:50:07 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id q199sm78792oic.16.2019.09.25.14.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 14:50:06 -0700 (PDT) From: Rob Herring To: Oleksandr Andrushchenko , Boris Ostrovsky Cc: linux-kernel@vger.kernel.org, Robin Murphy , Julien Grall , Nicolas Saenz Julienne , Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: [RFC PATCH] xen/gntdev: Stop abusing DT of_dma_configure API Date: Wed, 25 Sep 2019 16:50:06 -0500 Message-Id: <20190925215006.12056-1-robh@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As the comment says, this isn't a DT based device. of_dma_configure() is going to stop allowing a NULL DT node, so this needs to be fixed. Not sure exactly what setup besides arch_setup_dma_ops is needed... Cc: Robin Murphy Cc: Julien Grall Cc: Nicolas Saenz Julienne Cc: Oleksandr Andrushchenko Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-devel@lists.xenproject.org Signed-off-by: Rob Herring --- drivers/xen/gntdev.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index a446a7221e13..59906f9a40e4 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -34,9 +34,6 @@ #include #include #include -#ifdef CONFIG_XEN_GRANT_DMA_ALLOC -#include -#endif #include #include @@ -625,14 +622,6 @@ static int gntdev_open(struct inode *inode, struct file *flip) flip->private_data = priv; #ifdef CONFIG_XEN_GRANT_DMA_ALLOC priv->dma_dev = gntdev_miscdev.this_device; - - /* - * The device is not spawn from a device tree, so arch_setup_dma_ops - * is not called, thus leaving the device with dummy DMA ops. - * Fix this by calling of_dma_configure() with a NULL node to set - * default DMA ops. - */ - of_dma_configure(priv->dma_dev, NULL, true); #endif pr_debug("priv %p\n", priv); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70343C432C2 for ; Wed, 25 Sep 2019 21:50:42 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 436B42146E for ; Wed, 25 Sep 2019 21:50:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 436B42146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iDFAo-0004dp-Uq; Wed, 25 Sep 2019 21:50:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iDFAn-0004dk-F8 for xen-devel@lists.xenproject.org; Wed, 25 Sep 2019 21:50:09 +0000 X-Inumbo-ID: 70c37ea8-dfde-11e9-963a-12813bfff9fa Received: from mail-ot1-f66.google.com (unknown [209.85.210.66]) by localhost (Halon) with ESMTPS id 70c37ea8-dfde-11e9-963a-12813bfff9fa; Wed, 25 Sep 2019 21:50:08 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id f21so124914otl.13 for ; Wed, 25 Sep 2019 14:50:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6cXLFB02TykvVAB5VHeIiQg5E1YhhmuVezg1VTNWACM=; b=ZbFv5Rn8e0VL0ADJr8YuTx7oGjrZEl1s0j11FAHKyby9RAV9iAFCK3i2rMnIB1AaWc 8eGLz4yThyDws5UD/NgQ3r79MwafRW8O5zsNJP5EVNP8Mf+K+DZdl+c0b8wCXpnWc1Ig i65wsX7s6mCpd9r7LnBNJiMfBjdLcch4E+rQ7LG2pFk45PCAU/9s/ukslWFGsDIQP5q+ nWt5r4iXCg3hLagzI983iazlsKadDrGRaaAbktGJHr2ttQySJsgumgpw9kLqePi5EhZF vnivyMAhDhHq2vSasgKD6vD1hdI9Ku9mU5fCz31vvsARYrAYCiN5HVrHDR9l4JWhY3HQ TXWw== X-Gm-Message-State: APjAAAVpzahMAjzPsvx5HjcU0HyZ6eyJcrgb8ZBDkSXr2E2/U+G1AQAj BmjXkd0ym6sWG3G/+CvkOw== X-Google-Smtp-Source: APXvYqyz7lSYS26abdEhCGr1U2uy0uBmZ56y9Lbe3N7QnPUQ3gDyYFxELSUCIBwmOSdt/05qrxpCYg== X-Received: by 2002:a05:6830:1d8:: with SMTP id r24mr215060ota.217.1569448207485; Wed, 25 Sep 2019 14:50:07 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id q199sm78792oic.16.2019.09.25.14.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 14:50:06 -0700 (PDT) From: Rob Herring To: Oleksandr Andrushchenko , Boris Ostrovsky Date: Wed, 25 Sep 2019 16:50:06 -0500 Message-Id: <20190925215006.12056-1-robh@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Xen-devel] [RFC PATCH] xen/gntdev: Stop abusing DT of_dma_configure API X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , linux-kernel@vger.kernel.org, Julien Grall , xen-devel@lists.xenproject.org, Robin Murphy , Nicolas Saenz Julienne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" QXMgdGhlIGNvbW1lbnQgc2F5cywgdGhpcyBpc24ndCBhIERUIGJhc2VkIGRldmljZS4gb2ZfZG1h X2NvbmZpZ3VyZSgpCmlzIGdvaW5nIHRvIHN0b3AgYWxsb3dpbmcgYSBOVUxMIERUIG5vZGUsIHNv IHRoaXMgbmVlZHMgdG8gYmUgZml4ZWQuCgpOb3Qgc3VyZSBleGFjdGx5IHdoYXQgc2V0dXAgYmVz aWRlcyBhcmNoX3NldHVwX2RtYV9vcHMgaXMgbmVlZGVkLi4uCgpDYzogUm9iaW4gTXVycGh5IDxy b2Jpbi5tdXJwaHlAYXJtLmNvbT4KQ2M6IEp1bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5j b20+CkNjOiBOaWNvbGFzIFNhZW56IEp1bGllbm5lIDxuc2FlbnpqdWxpZW5uZUBzdXNlLmRlPgpD YzogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0u Y29tPgpDYzogQm9yaXMgT3N0cm92c2t5IDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT4KQ2M6 IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KQ2M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8 c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4KQ2M6IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9y ZwpTaWduZWQtb2ZmLWJ5OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgotLS0KIGRyaXZl cnMveGVuL2dudGRldi5jIHwgMTEgLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMSBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9nbnRkZXYuYyBiL2RyaXZlcnMveGVu L2dudGRldi5jCmluZGV4IGE0NDZhNzIyMWUxMy4uNTk5MDZmOWE0MGU0IDEwMDY0NAotLS0gYS9k cml2ZXJzL3hlbi9nbnRkZXYuYworKysgYi9kcml2ZXJzL3hlbi9nbnRkZXYuYwpAQCAtMzQsOSAr MzQsNiBAQAogI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KICNpbmNsdWRlIDxsaW51eC9oaWdobWVt Lmg+CiAjaW5jbHVkZSA8bGludXgvcmVmY291bnQuaD4KLSNpZmRlZiBDT05GSUdfWEVOX0dSQU5U X0RNQV9BTExPQwotI2luY2x1ZGUgPGxpbnV4L29mX2RldmljZS5oPgotI2VuZGlmCiAKICNpbmNs dWRlIDx4ZW4veGVuLmg+CiAjaW5jbHVkZSA8eGVuL2dyYW50X3RhYmxlLmg+CkBAIC02MjUsMTQg KzYyMiw2IEBAIHN0YXRpYyBpbnQgZ250ZGV2X29wZW4oc3RydWN0IGlub2RlICppbm9kZSwgc3Ry dWN0IGZpbGUgKmZsaXApCiAJZmxpcC0+cHJpdmF0ZV9kYXRhID0gcHJpdjsKICNpZmRlZiBDT05G SUdfWEVOX0dSQU5UX0RNQV9BTExPQwogCXByaXYtPmRtYV9kZXYgPSBnbnRkZXZfbWlzY2Rldi50 aGlzX2RldmljZTsKLQotCS8qCi0JICogVGhlIGRldmljZSBpcyBub3Qgc3Bhd24gZnJvbSBhIGRl dmljZSB0cmVlLCBzbyBhcmNoX3NldHVwX2RtYV9vcHMKLQkgKiBpcyBub3QgY2FsbGVkLCB0aHVz IGxlYXZpbmcgdGhlIGRldmljZSB3aXRoIGR1bW15IERNQSBvcHMuCi0JICogRml4IHRoaXMgYnkg Y2FsbGluZyBvZl9kbWFfY29uZmlndXJlKCkgd2l0aCBhIE5VTEwgbm9kZSB0byBzZXQKLQkgKiBk ZWZhdWx0IERNQSBvcHMuCi0JICovCi0Jb2ZfZG1hX2NvbmZpZ3VyZShwcml2LT5kbWFfZGV2LCBO VUxMLCB0cnVlKTsKICNlbmRpZgogCXByX2RlYnVnKCJwcml2ICVwXG4iLCBwcml2KTsKIAotLSAK Mi4yMC4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K WGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0 cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==