From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A6BCC4360C for ; Thu, 26 Sep 2019 15:22:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59359222C8 for ; Thu, 26 Sep 2019 15:22:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727280AbfIZPWP (ORCPT ); Thu, 26 Sep 2019 11:22:15 -0400 Received: from foss.arm.com ([217.140.110.172]:52750 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727170AbfIZPWP (ORCPT ); Thu, 26 Sep 2019 11:22:15 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F1DB215A2; Thu, 26 Sep 2019 08:22:14 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EF4FA3F534; Thu, 26 Sep 2019 08:22:13 -0700 (PDT) Date: Thu, 26 Sep 2019 16:22:11 +0100 From: Catalin Marinas To: Vincenzo Frascino Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org, ndesaulniers@google.com, will@kernel.org, tglx@linutronix.de Subject: Re: [PATCH v2 3/4] arm64: vdso32: Fix compilation warning Message-ID: <20190926152210.GI9689@arrakis.emea.arm.com> References: <20190926133805.52348-1-vincenzo.frascino@arm.com> <20190926133805.52348-4-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190926133805.52348-4-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 26, 2019 at 02:38:04PM +0100, Vincenzo Frascino wrote: > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > index b61b50bf68b1..cfa9cd87af14 100644 > --- a/arch/arm64/include/asm/memory.h > +++ b/arch/arm64/include/asm/memory.h > @@ -228,11 +228,16 @@ static inline unsigned long kaslr_offset(void) > #define __tag_get(addr) 0 > #endif /* CONFIG_KASAN_SW_TAGS */ > > +#ifdef __aarch64__ > static inline const void *__tag_set(const void *addr, u8 tag) > { > u64 __addr = (u64)addr & ~__tag_shifted(0xff); > return (const void *)(__addr | __tag_shifted(tag)); > } > +#else > +/* Unused in compat vdso */ > +#define __tag_set(addr, tag) 0 > +#endif Do we actually need an #else block here? I think the #ifdef is sufficient, with a comment along the lines of "Do not attempt to compile when included in the compat vdso" (or pick some better wording). -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2820C352AA for ; Thu, 26 Sep 2019 15:22:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A379C21D56 for ; Thu, 26 Sep 2019 15:22:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n+J7+EWs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A379C21D56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vbfM/a6Qay5ZMx4JcjoBPhoqfo/dufAEB9ch3Y8GaZ8=; b=n+J7+EWsukHWqx J2Xnan7IUV8uAGDKKMSZMG/NeAj1jlJ3/MaNdCX4bPWVJLNyE8d3RosnHKaGomxFr6Bk5+5qoNJKJ /Me6QyFPdWHusmz4jOqw3fy2H5KeMClrkdLtJA3xMUurdOLnOrVykKbNjoIZODGqTJvqd2rbFs9Zk q/Ie0VFZV8iNbm1mg7eoAZqSmebMPIOtUMVUoKIkQ1AAtUCuDBqj7FoNJEQ7xCHUL9xMnDkmOEMKr ZLlMkjzTgSJihu8AeOsa4+81ptNRKrBkcrD9h5anAdStloyISXTFhbJAfAslHSLWN1Wb1U8eYU2Fk c4iUvf11lj64cC7164Ig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDVb0-0003ZT-9y; Thu, 26 Sep 2019 15:22:18 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDVax-0003YF-JY for linux-arm-kernel@lists.infradead.org; Thu, 26 Sep 2019 15:22:16 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F1DB215A2; Thu, 26 Sep 2019 08:22:14 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EF4FA3F534; Thu, 26 Sep 2019 08:22:13 -0700 (PDT) Date: Thu, 26 Sep 2019 16:22:11 +0100 From: Catalin Marinas To: Vincenzo Frascino Subject: Re: [PATCH v2 3/4] arm64: vdso32: Fix compilation warning Message-ID: <20190926152210.GI9689@arrakis.emea.arm.com> References: <20190926133805.52348-1-vincenzo.frascino@arm.com> <20190926133805.52348-4-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190926133805.52348-4-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190926_082215_687995_39EF9B19 X-CRM114-Status: GOOD ( 11.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ard.biesheuvel@linaro.org, ndesaulniers@google.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 26, 2019 at 02:38:04PM +0100, Vincenzo Frascino wrote: > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > index b61b50bf68b1..cfa9cd87af14 100644 > --- a/arch/arm64/include/asm/memory.h > +++ b/arch/arm64/include/asm/memory.h > @@ -228,11 +228,16 @@ static inline unsigned long kaslr_offset(void) > #define __tag_get(addr) 0 > #endif /* CONFIG_KASAN_SW_TAGS */ > > +#ifdef __aarch64__ > static inline const void *__tag_set(const void *addr, u8 tag) > { > u64 __addr = (u64)addr & ~__tag_shifted(0xff); > return (const void *)(__addr | __tag_shifted(tag)); > } > +#else > +/* Unused in compat vdso */ > +#define __tag_set(addr, tag) 0 > +#endif Do we actually need an #else block here? I think the #ifdef is sufficient, with a comment along the lines of "Do not attempt to compile when included in the compat vdso" (or pick some better wording). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel