From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: bitbake-devel@lists.openembedded.org
Subject: [PATCH 8/9] runqueue: Small performance optimisation
Date: Fri, 27 Sep 2019 13:33:46 +0100 [thread overview]
Message-ID: <20190927123347.19276-8-richard.purdie@linuxfoundation.org> (raw)
In-Reply-To: <20190927123347.19276-1-richard.purdie@linuxfoundation.org>
A minor performance optmisation to keep lists smaller when running large
builds. We can do this since once a task has been built, we don't need
to worry about it. This improves a major bottleneck that shows up on
performance profile charts in dryruns.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/runqueue.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py
index 31de3ed1cf..18049436fd 100644
--- a/lib/bb/runqueue.py
+++ b/lib/bb/runqueue.py
@@ -207,6 +207,8 @@ class RunQueueScheduler(object):
def newbuildable(self, task):
self.buildable.add(task)
+ # Once tasks are running we don't need to worry about them again
+ self.buildable.difference_update(self.rq.runq_running)
def removebuildable(self, task):
self.buildable.remove(task)
--
2.20.1
next prev parent reply other threads:[~2019-09-27 12:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 12:33 [PATCH 1/9] hashserv: Don't daemonize server process Richard Purdie
2019-09-27 12:33 ` [PATCH 2/9] runqueue: Fix task migration problems Richard Purdie
2019-09-27 12:33 ` [PATCH 3/9] siggen: Ensure setscenetasks list is available to worker context Richard Purdie
2019-09-27 12:33 ` [PATCH 4/9] runqueue: Change task migration behaviour for rerunning setscene tasks Richard Purdie
2019-09-27 12:33 ` [PATCH 5/9] siggen/runqueue: Fix signature mismatch issues Richard Purdie
2019-09-27 13:35 ` Joshua Watt
2019-10-03 15:34 ` Richard Purdie
2019-09-27 12:33 ` [PATCH 6/9] siggen: Avoid writing misleading sigdata files Richard Purdie
2019-09-27 12:33 ` [PATCH 7/9] runqueue: Save unihashes more frequently Richard Purdie
2019-09-27 12:33 ` Richard Purdie [this message]
2019-09-27 12:33 ` [PATCH 9/9] siggen: Remove full path from unitaskhashes keys Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927123347.19276-8-richard.purdie@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.