From: Andrew Murray <andrew.murray@arm.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: bhelgaas@google.com, zenglu@loongson.cn,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Add Loongson vendor ID and device IDs
Date: Mon, 30 Sep 2019 15:02:17 +0100 [thread overview]
Message-ID: <20190930140217.GB38576@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <279cbe32-a44b-3190-aaf7-a277a1220720@loongson.cn>
On Mon, Sep 30, 2019 at 12:55:20PM +0800, Tiezhu Yang wrote:
> Add the Loongson vendor ID and device IDs to pci_ids.h
> to be used in the future.
>
> The Loongson IDs can be found at the following link:
> https://git.kernel.org/pub/scm/utils/pciutils/pciutils.git/tree/pci.ids
>
> Co-developed-by: Lu Zeng <zenglu@loongson.cn>
> Signed-off-by: Lu Zeng <zenglu@loongson.cn>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> include/linux/pci_ids.h | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 21a5724..119639d 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -3111,4 +3111,23 @@
>
> #define PCI_VENDOR_ID_NCUBE 0x10ff
>
> +#define PCI_VENDOR_ID_LOONGSON 0x0014
> +#define PCI_DEVICE_ID_LOONGSON_HT 0x7a00
> +#define PCI_DEVICE_ID_LOONGSON_APB 0x7a02
> +#define PCI_DEVICE_ID_LOONGSON_GMAC 0x7a03
> +#define PCI_DEVICE_ID_LOONGSON_OTG 0x7a04
> +#define PCI_DEVICE_ID_LOONGSON_GPU_2K1000 0x7a05
> +#define PCI_DEVICE_ID_LOONGSON_DC 0x7a06
> +#define PCI_DEVICE_ID_LOONGSON_HDA 0x7a07
> +#define PCI_DEVICE_ID_LOONGSON_SATA 0x7a08
> +#define PCI_DEVICE_ID_LOONGSON_PCIE_X1 0x7a09
> +#define PCI_DEVICE_ID_LOONGSON_SPI 0x7a0b
> +#define PCI_DEVICE_ID_LOONGSON_LPC 0x7a0c
> +#define PCI_DEVICE_ID_LOONGSON_DMA 0x7a0f
> +#define PCI_DEVICE_ID_LOONGSON_EHCI 0x7a14
> +#define PCI_DEVICE_ID_LOONGSON_GPU_7A1000 0x7a15
> +#define PCI_DEVICE_ID_LOONGSON_PCIE_X4 0x7a19
> +#define PCI_DEVICE_ID_LOONGSON_OHCI 0x7a24
> +#define PCI_DEVICE_ID_LOONGSON_PCIE_X8 0x7a29
Hi Tiezhu,
Thanks for the patch - however it is preferred to provide new PCI definitions
along with the drivers that use them. They don't provide any useful value
without drivers that use them.
Thanks,
Andrew Murray
> +
> #endif /* _LINUX_PCI_IDS_H */
> --
> 2.1.0
>
>
next prev parent reply other threads:[~2019-09-30 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 4:55 [PATCH] PCI: Add Loongson vendor ID and device IDs Tiezhu Yang
2019-09-30 14:02 ` Andrew Murray [this message]
2019-10-01 2:53 ` Tiezhu Yang
2019-10-01 12:50 ` Bjorn Helgaas
2019-10-02 0:53 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930140217.GB38576@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yangtiezhu@loongson.cn \
--cc=zenglu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.