From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42DDC352AA for ; Tue, 1 Oct 2019 14:18:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BE9F21855 for ; Tue, 1 Oct 2019 14:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569939529; bh=BZoLkO7pPzU3r96BwmjE8Yk+cfOBfvTp6vVFJajgGi0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=s+g+ecUIoffxE/iOhDqLq5B3qlBFGCYnz224C2ecu5Sita54CvX/4zbuDokxPMecT Ht+eRO0yomI5xGOIwHmUmSPmLhiR2+iCiYgQtKq2MYodRA1GHBatWDySyR/pBUtBeC IAWxy5khjCVtkFWRr0NxwdyOkCXWBjVSl8w93/Yo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388941AbfJAOSt (ORCPT ); Tue, 1 Oct 2019 10:18:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:33274 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727055AbfJAOSs (ORCPT ); Tue, 1 Oct 2019 10:18:48 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F78E2086A; Tue, 1 Oct 2019 14:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569939528; bh=BZoLkO7pPzU3r96BwmjE8Yk+cfOBfvTp6vVFJajgGi0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LuvHpqFnQEAf2BjLJouneSSWDpXnphl0go8fxpv4Np+kR/D7JMIYeMixWOcgAGOtR Z4z06rexQ5MhaJ1WtOeaYIX/aSmVcJA3YLsYIAciSbfVbyhs1akYxuTApsNlVSoSCh tSX8x5tbdGjsvyvGROQLF2Ptws9GzIE+lgDBmphs= Date: Tue, 1 Oct 2019 10:18:46 -0400 From: Sasha Levin To: Jerome Brunet Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mark Brown , linux-amlogic@lists.infradead.org Subject: Re: [PATCH AUTOSEL 5.3 034/203] ASoC: meson: g12a-tohdmitx: override codec2codec params Message-ID: <20191001141846.GU8171@sasha-vm> References: <20190922184350.30563-1-sashal@kernel.org> <20190922184350.30563-34-sashal@kernel.org> <1j7e5ztnoo.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1j7e5ztnoo.fsf@starbuckisacylon.baylibre.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2019 at 10:35:35AM +0200, Jerome Brunet wrote: >On Sun 22 Sep 2019 at 14:41, Sasha Levin wrote: > >> From: Jerome Brunet >> >> [ Upstream commit 2c4956bc1e9062e5e3c5ea7612294f24e6d4fbdd ] >> >> So far, forwarding the hw_params of the input to output relied on the >> .hw_params() callback of the cpu side of the codec2codec link to be called >> first. This is a bit weak. >> >> Instead, override the stream params of the codec2codec to link to set it up >> correctly. > >Hi Sasha > >This change depends on the following series in ASoC: >https://lore.kernel.org/r/20190725165949.29699-1-jbrunet@baylibre.com >which has also been merged in this merge window. > >With this change, things are done (IMO) in a better way but there was no >known issue before that. > >I don't think it is worth backporting the mentioned ASoC series to >5.3. I would suggest to just drop this change from stable. I've dropped it, thank you. -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AD0FECE587 for ; Tue, 1 Oct 2019 14:19:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BA412086A for ; Tue, 1 Oct 2019 14:19:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B0P4bBDK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LuvHpqFn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BA412086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p2KIm4ruIVAt/Yuf5oGIy77bPAvb8bDMy8Cyi5spbgw=; b=B0P4bBDKyYaFA3hpmUX2qvkSo 2GlyJXa0FT1zDXCfFwA0ITloY9WmbpMEFjHpebAvJfnqW5f7Ede3xGsWYdTqD0sWedz/TBIjBhfgD X4FpFLMOFGDxLihdTxLgTyWCMmt4v7ZuGj1LK/qCvsq5VJdvuATPFMhTpDrpTIGzYUnXw7Zle+9Yp k03a8OdujpMiINAFaSGrpR6TCTYemjoTYtIIzRUuDecwaScIkdyPZCLNFyFdYuOD0KEH5FHsL7T3R VLaeYQfrz1UNStV0rSZQf/ovilCNhyuWYnxnfPXEAy9FrICY1DX+tI9hUqQcIpxDlU5d+UpSsMQ9n IupIMYh/g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFIzL-0006Ed-Tq; Tue, 01 Oct 2019 14:18:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFIzJ-0006D1-7L for linux-amlogic@lists.infradead.org; Tue, 01 Oct 2019 14:18:50 +0000 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F78E2086A; Tue, 1 Oct 2019 14:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569939528; bh=BZoLkO7pPzU3r96BwmjE8Yk+cfOBfvTp6vVFJajgGi0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LuvHpqFnQEAf2BjLJouneSSWDpXnphl0go8fxpv4Np+kR/D7JMIYeMixWOcgAGOtR Z4z06rexQ5MhaJ1WtOeaYIX/aSmVcJA3YLsYIAciSbfVbyhs1akYxuTApsNlVSoSCh tSX8x5tbdGjsvyvGROQLF2Ptws9GzIE+lgDBmphs= Date: Tue, 1 Oct 2019 10:18:46 -0400 From: Sasha Levin To: Jerome Brunet Subject: Re: [PATCH AUTOSEL 5.3 034/203] ASoC: meson: g12a-tohdmitx: override codec2codec params Message-ID: <20191001141846.GU8171@sasha-vm> References: <20190922184350.30563-1-sashal@kernel.org> <20190922184350.30563-34-sashal@kernel.org> <1j7e5ztnoo.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1j7e5ztnoo.fsf@starbuckisacylon.baylibre.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191001_071849_286019_F925255F X-CRM114-Status: UNSURE ( 9.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, Mark Brown , linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, Sep 23, 2019 at 10:35:35AM +0200, Jerome Brunet wrote: >On Sun 22 Sep 2019 at 14:41, Sasha Levin wrote: > >> From: Jerome Brunet >> >> [ Upstream commit 2c4956bc1e9062e5e3c5ea7612294f24e6d4fbdd ] >> >> So far, forwarding the hw_params of the input to output relied on the >> .hw_params() callback of the cpu side of the codec2codec link to be called >> first. This is a bit weak. >> >> Instead, override the stream params of the codec2codec to link to set it up >> correctly. > >Hi Sasha > >This change depends on the following series in ASoC: >https://lore.kernel.org/r/20190725165949.29699-1-jbrunet@baylibre.com >which has also been merged in this merge window. > >With this change, things are done (IMO) in a better way but there was no >known issue before that. > >I don't think it is worth backporting the mentioned ASoC series to >5.3. I would suggest to just drop this change from stable. I've dropped it, thank you. -- Thanks, Sasha _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic