From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rohit Sarkar <rohitsarkar5398@gmail.com>
Cc: larry.finger@lwfiner.net, gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
florian.c.schilhabel@googlemail.com
Subject: Re: [PATCH] staging: rtl8712: Replace snprintf with scnprintf
Date: Tue, 1 Oct 2019 22:00:56 +0300 [thread overview]
Message-ID: <20191001185852.GJ22609@kadam> (raw)
In-Reply-To: <20191001173926.GA11819@SARKAR>
On Tue, Oct 01, 2019 at 11:09:26PM +0530, Rohit Sarkar wrote:
> On Tue, Oct 01, 2019 at 11:45:14AM +0300, Dan Carpenter wrote:
> > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > index b08b9a191a34..ff5edcaba64d 100644
> > > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > @@ -142,7 +142,7 @@ static noinline_for_stack char *translate_scan_wpa(struct iw_request_info *info,
> > > memset(buf, 0, MAX_WPA_IE_LEN);
> > > n = sprintf(buf, "wpa_ie=");
> > > for (i = 0; i < wpa_len; i++) {
> > > - n += snprintf(buf + n, MAX_WPA_IE_LEN - n,
> > > + n += scnprintf(buf + n, MAX_WPA_IE_LEN - n,
> > > "%02x", wpa_ie[i]);
> > > if (n >= MAX_WPA_IE_LEN)
> > ^^^^^^^^^^^^^^^^^^^
> > It checks for overflow here. This check is impossible now and doesn't
> > make sense. The other loop is similar.
>
> Good catch! I must have overlooked this.
> "n" cannot be greater than MAX_WPA_IE_LEN but it can be equal to that
> value. We can replace the '>=' with '==' so that we don't loop
> unnecessarily when n has reached it's threshold.
No. scnprintf() returns the number of characters *not counting the
NUL terminator*. So it can be a maximum of MAX_WPA_IE_LEN - 1.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-10-01 19:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 18:49 [PATCH] staging: rtl8712: Replace snprintf with scnprintf Rohit Sarkar
2019-09-10 18:55 ` Rohit Sarkar
2019-10-01 14:14 ` Dan Carpenter
2019-10-01 8:45 ` Dan Carpenter
2019-10-01 17:39 ` Rohit Sarkar
2019-10-01 19:00 ` Dan Carpenter [this message]
2019-10-02 4:33 ` Rohit Sarkar
2019-10-02 10:57 ` Dan Carpenter
2019-10-02 11:42 ` Rohit Sarkar
2019-10-02 12:06 ` Dan Carpenter
2019-10-02 12:10 ` Rohit Sarkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001185852.GJ22609@kadam \
--to=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=larry.finger@lwfiner.net \
--cc=rohitsarkar5398@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.