All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sudhakar.dindukurti@oracle.com
Cc: netdev@vger.kernel.org, santosh.shilimkar@oracle.com,
	rds-devel@oss.oracle.com, dotanb@dev.mellanox.co.il
Subject: Re: [PATCH net] net/rds: Fix error handling in rds_ib_add_one()
Date: Wed, 02 Oct 2019 12:18:09 -0400 (EDT)	[thread overview]
Message-ID: <20191002.121809.873130939496092066.davem@davemloft.net> (raw)
In-Reply-To: <1569950462-37680-1-git-send-email-sudhakar.dindukurti@oracle.com>

From: Sudhakar Dindukurti <sudhakar.dindukurti@oracle.com>
Date: Tue,  1 Oct 2019 10:21:02 -0700

> From: Dotan Barak <dotanb@dev.mellanox.co.il>
> 
> rds_ibdev:ipaddr_list and rds_ibdev:conn_list are initialized
> after allocation some resources such as protection domain.
> If allocation of such resources fail, then these uninitialized
> variables are accessed in rds_ib_dev_free() in failure path. This
> can potentially crash the system. The code has been updated to
> initialize these variables very early in the function.
> 
> Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>
> Signed-off-by: Sudhakar Dindukurti <sudhakar.dindukurti@oracle.com>

Applied.

      parent reply	other threads:[~2019-10-02 16:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01 17:21 [PATCH net] net/rds: Fix error handling in rds_ib_add_one() Sudhakar Dindukurti
2019-10-01 17:47 ` santosh.shilimkar
2019-10-02 16:18 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191002.121809.873130939496092066.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dotanb@dev.mellanox.co.il \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    --cc=santosh.shilimkar@oracle.com \
    --cc=sudhakar.dindukurti@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.