[PATCH] soundwire: slave: Fix unused function warning on !ACPI

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] soundwire: slave: Fix unused function warning on !ACPI
@ 2019-08-30 18:52 ` Michal Suchanek
  0 siblings, 0 replies; 31+ messages in thread
From: Michal Suchanek @ 2019-08-30 18:52 UTC (permalink / raw)
  To: alsa-devel
  Cc: Michal Suchanek, Vinod Koul, Sanyog Kale, Pierre-Louis Bossart,
	linux-kernel

Fixes the following warning on !ACPI systems:

drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
not used [-Wunused-function]
 static int sdw_slave_add(struct sdw_bus *bus,
            ^~~~~~~~~~~~~

Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/slave.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
index f39a5815e25d..34c7e65831d1 100644
--- a/drivers/soundwire/slave.c
+++ b/drivers/soundwire/slave.c
@@ -6,6 +6,7 @@
 #include <linux/soundwire/sdw_type.h>
 #include "bus.h"
 
+#if IS_ENABLED(CONFIG_ACPI)
 static void sdw_slave_release(struct device *dev)
 {
 	struct sdw_slave *slave = dev_to_sdw_dev(dev);
@@ -60,7 +61,6 @@ static int sdw_slave_add(struct sdw_bus *bus,
 	return ret;
 }
 
-#if IS_ENABLED(CONFIG_ACPI)
 /*
  * sdw_acpi_find_slaves() - Find Slave devices in Master ACPI node
  * @bus: SDW bus instance
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 31+ messages in thread

* [alsa-devel] [PATCH] soundwire: slave: Fix unused function warning on !ACPI
@ 2019-08-30 18:52 ` Michal Suchanek
  0 siblings, 0 replies; 31+ messages in thread
From: Michal Suchanek @ 2019-08-30 18:52 UTC (permalink / raw)
  To: alsa-devel
  Cc: linux-kernel, Vinod Koul, Michal Suchanek, Sanyog Kale,
	Pierre-Louis Bossart

Fixes the following warning on !ACPI systems:

drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
not used [-Wunused-function]
 static int sdw_slave_add(struct sdw_bus *bus,
            ^~~~~~~~~~~~~

Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/slave.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
index f39a5815e25d..34c7e65831d1 100644
--- a/drivers/soundwire/slave.c
+++ b/drivers/soundwire/slave.c
@@ -6,6 +6,7 @@
 #include <linux/soundwire/sdw_type.h>
 #include "bus.h"
 
+#if IS_ENABLED(CONFIG_ACPI)
 static void sdw_slave_release(struct device *dev)
 {
 	struct sdw_slave *slave = dev_to_sdw_dev(dev);
@@ -60,7 +61,6 @@ static int sdw_slave_add(struct sdw_bus *bus,
 	return ret;
 }
 
-#if IS_ENABLED(CONFIG_ACPI)
 /*
  * sdw_acpi_find_slaves() - Find Slave devices in Master ACPI node
  * @bus: SDW bus instance
-- 
2.22.0

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 31+ messages in thread

* Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI
@ 2019-08-30 18:56   ` Randy Dunlap
  0 siblings, 0 replies; 31+ messages in thread
From: Randy Dunlap @ 2019-08-30 18:56 UTC (permalink / raw)
  To: Michal Suchanek, alsa-devel
  Cc: Vinod Koul, Sanyog Kale, Pierre-Louis Bossart, linux-kernel

On 8/30/19 11:52 AM, Michal Suchanek wrote:
> Fixes the following warning on !ACPI systems:
> 
> drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> not used [-Wunused-function]
>  static int sdw_slave_add(struct sdw_bus *bus,
>             ^~~~~~~~~~~~~
> 
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

I was about to send the same patch.
Thanks.

> ---
>  drivers/soundwire/slave.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
> index f39a5815e25d..34c7e65831d1 100644
> --- a/drivers/soundwire/slave.c
> +++ b/drivers/soundwire/slave.c
> @@ -6,6 +6,7 @@
>  #include <linux/soundwire/sdw_type.h>
>  #include "bus.h"
>  
> +#if IS_ENABLED(CONFIG_ACPI)
>  static void sdw_slave_release(struct device *dev)
>  {
>  	struct sdw_slave *slave = dev_to_sdw_dev(dev);
> @@ -60,7 +61,6 @@ static int sdw_slave_add(struct sdw_bus *bus,
>  	return ret;
>  }
>  
> -#if IS_ENABLED(CONFIG_ACPI)
>  /*
>   * sdw_acpi_find_slaves() - Find Slave devices in Master ACPI node
>   * @bus: SDW bus instance
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH] soundwire: slave: Fix unused function warning on !ACPI
@ 2019-08-30 18:56   ` Randy Dunlap
  0 siblings, 0 replies; 31+ messages in thread
From: Randy Dunlap @ 2019-08-30 18:56 UTC (permalink / raw)
  To: Michal Suchanek, alsa-devel
  Cc: linux-kernel, Vinod Koul, Sanyog Kale, Pierre-Louis Bossart

On 8/30/19 11:52 AM, Michal Suchanek wrote:
> Fixes the following warning on !ACPI systems:
> 
> drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> not used [-Wunused-function]
>  static int sdw_slave_add(struct sdw_bus *bus,
>             ^~~~~~~~~~~~~
> 
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

I was about to send the same patch.
Thanks.

> ---
>  drivers/soundwire/slave.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
> index f39a5815e25d..34c7e65831d1 100644
> --- a/drivers/soundwire/slave.c
> +++ b/drivers/soundwire/slave.c
> @@ -6,6 +6,7 @@
>  #include <linux/soundwire/sdw_type.h>
>  #include "bus.h"
>  
> +#if IS_ENABLED(CONFIG_ACPI)
>  static void sdw_slave_release(struct device *dev)
>  {
>  	struct sdw_slave *slave = dev_to_sdw_dev(dev);
> @@ -60,7 +61,6 @@ static int sdw_slave_add(struct sdw_bus *bus,
>  	return ret;
>  }
>  
> -#if IS_ENABLED(CONFIG_ACPI)
>  /*
>   * sdw_acpi_find_slaves() - Find Slave devices in Master ACPI node
>   * @bus: SDW bus instance
> 


-- 
~Randy
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI
  2019-08-30 18:56   ` [alsa-devel] " Randy Dunlap
@ 2019-09-04  9:30     ` Vinod Koul
  -1 siblings, 0 replies; 31+ messages in thread
From: Vinod Koul @ 2019-09-04  9:30 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Michal Suchanek, alsa-devel, Sanyog Kale, Pierre-Louis Bossart,
	linux-kernel

On 30-08-19, 11:56, Randy Dunlap wrote:
> On 8/30/19 11:52 AM, Michal Suchanek wrote:
> > Fixes the following warning on !ACPI systems:
> > 
> > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> > not used [-Wunused-function]
> >  static int sdw_slave_add(struct sdw_bus *bus,
> >             ^~~~~~~~~~~~~
> > 
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> 
> I was about to send the same patch.

So I have applied Srini's patches which add DT support and they use
sdw_slave_add(). So next tomorrow should not see this error as it is now
used by DT parts as well.

So dropping this patch

-- 
~Vinod

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH] soundwire: slave: Fix unused function warning on !ACPI
@ 2019-09-04  9:30     ` Vinod Koul
  0 siblings, 0 replies; 31+ messages in thread
From: Vinod Koul @ 2019-09-04  9:30 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, alsa-devel, Michal Suchanek, Sanyog Kale,
	Pierre-Louis Bossart

On 30-08-19, 11:56, Randy Dunlap wrote:
> On 8/30/19 11:52 AM, Michal Suchanek wrote:
> > Fixes the following warning on !ACPI systems:
> > 
> > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> > not used [-Wunused-function]
> >  static int sdw_slave_add(struct sdw_bus *bus,
> >             ^~~~~~~~~~~~~
> > 
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> 
> I was about to send the same patch.

So I have applied Srini's patches which add DT support and they use
sdw_slave_add(). So next tomorrow should not see this error as it is now
used by DT parts as well.

So dropping this patch

-- 
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI
  2019-09-04  9:30     ` [alsa-devel] " Vinod Koul
@ 2019-09-04 10:48       ` Michal Suchánek
  -1 siblings, 0 replies; 31+ messages in thread
From: Michal Suchánek @ 2019-09-04 10:48 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Randy Dunlap, alsa-devel, Sanyog Kale, Pierre-Louis Bossart,
	linux-kernel

On Wed, 4 Sep 2019 15:00:52 +0530
Vinod Koul <vkoul@kernel.org> wrote:

> On 30-08-19, 11:56, Randy Dunlap wrote:
> > On 8/30/19 11:52 AM, Michal Suchanek wrote:  
> > > Fixes the following warning on !ACPI systems:
> > > 
> > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> > > not used [-Wunused-function]
> > >  static int sdw_slave_add(struct sdw_bus *bus,
> > >             ^~~~~~~~~~~~~
> > > 
> > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>  
> > 
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > 
> > I was about to send the same patch.  
> 
> So I have applied Srini's patches which add DT support and they use
> sdw_slave_add(). So next tomorrow should not see this error as it is now
> used by DT parts as well.
> 
> So dropping this patch
> 

That should fix the issue for me. I wonder if !ACPI !DT platforms are
still a thing.

Thanks

Michal

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH] soundwire: slave: Fix unused function warning on !ACPI
@ 2019-09-04 10:48       ` Michal Suchánek
  0 siblings, 0 replies; 31+ messages in thread
From: Michal Suchánek @ 2019-09-04 10:48 UTC (permalink / raw)
  To: Vinod Koul
  Cc: linux-kernel, alsa-devel, Randy Dunlap, Sanyog Kale,
	Pierre-Louis Bossart

On Wed, 4 Sep 2019 15:00:52 +0530
Vinod Koul <vkoul@kernel.org> wrote:

> On 30-08-19, 11:56, Randy Dunlap wrote:
> > On 8/30/19 11:52 AM, Michal Suchanek wrote:  
> > > Fixes the following warning on !ACPI systems:
> > > 
> > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> > > not used [-Wunused-function]
> > >  static int sdw_slave_add(struct sdw_bus *bus,
> > >             ^~~~~~~~~~~~~
> > > 
> > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>  
> > 
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > 
> > I was about to send the same patch.  
> 
> So I have applied Srini's patches which add DT support and they use
> sdw_slave_add(). So next tomorrow should not see this error as it is now
> used by DT parts as well.
> 
> So dropping this patch
> 

That should fix the issue for me. I wonder if !ACPI !DT platforms are
still a thing.

Thanks

Michal
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI
  2019-09-04 10:48       ` [alsa-devel] " Michal Suchánek
@ 2019-09-04 11:40         ` Vinod Koul
  -1 siblings, 0 replies; 31+ messages in thread
From: Vinod Koul @ 2019-09-04 11:40 UTC (permalink / raw)
  To: Michal Suchánek
  Cc: Randy Dunlap, alsa-devel, Sanyog Kale, Pierre-Louis Bossart,
	linux-kernel

On 04-09-19, 12:48, Michal Suchánek wrote:
> On Wed, 4 Sep 2019 15:00:52 +0530
> Vinod Koul <vkoul@kernel.org> wrote:
> 
> > On 30-08-19, 11:56, Randy Dunlap wrote:
> > > On 8/30/19 11:52 AM, Michal Suchanek wrote:  
> > > > Fixes the following warning on !ACPI systems:
> > > > 
> > > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> > > > not used [-Wunused-function]
> > > >  static int sdw_slave_add(struct sdw_bus *bus,
> > > >             ^~~~~~~~~~~~~
> > > > 
> > > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>  
> > > 
> > > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > > 
> > > I was about to send the same patch.  
> > 
> > So I have applied Srini's patches which add DT support and they use
> > sdw_slave_add(). So next tomorrow should not see this error as it is now
> > used by DT parts as well.
> > 
> > So dropping this patch
> > 
> 
> That should fix the issue for me. I wonder if !ACPI !DT platforms are
> still a thing.

Heh that should trigger this if we have one :D so should a lot more
which depend on some firmware!

-- 
~Vinod

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH] soundwire: slave: Fix unused function warning on !ACPI
@ 2019-09-04 11:40         ` Vinod Koul
  0 siblings, 0 replies; 31+ messages in thread
From: Vinod Koul @ 2019-09-04 11:40 UTC (permalink / raw)
  To: Michal Suchánek
  Cc: linux-kernel, alsa-devel, Randy Dunlap, Sanyog Kale,
	Pierre-Louis Bossart

On 04-09-19, 12:48, Michal Suchánek wrote:
> On Wed, 4 Sep 2019 15:00:52 +0530
> Vinod Koul <vkoul@kernel.org> wrote:
> 
> > On 30-08-19, 11:56, Randy Dunlap wrote:
> > > On 8/30/19 11:52 AM, Michal Suchanek wrote:  
> > > > Fixes the following warning on !ACPI systems:
> > > > 
> > > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> > > > not used [-Wunused-function]
> > > >  static int sdw_slave_add(struct sdw_bus *bus,
> > > >             ^~~~~~~~~~~~~
> > > > 
> > > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>  
> > > 
> > > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > > 
> > > I was about to send the same patch.  
> > 
> > So I have applied Srini's patches which add DT support and they use
> > sdw_slave_add(). So next tomorrow should not see this error as it is now
> > used by DT parts as well.
> > 
> > So dropping this patch
> > 
> 
> That should fix the issue for me. I wonder if !ACPI !DT platforms are
> still a thing.

Heh that should trigger this if we have one :D so should a lot more
which depend on some firmware!

-- 
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI
  2019-09-04 11:40         ` [alsa-devel] " Vinod Koul
@ 2019-10-02  8:20           ` Michal Suchánek
  -1 siblings, 0 replies; 31+ messages in thread
From: Michal Suchánek @ 2019-10-02  8:20 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Randy Dunlap, alsa-devel, Sanyog Kale, Pierre-Louis Bossart,
	linux-kernel

On Wed, Sep 04, 2019 at 05:10:59PM +0530, Vinod Koul wrote:
> On 04-09-19, 12:48, Michal Suchánek wrote:
> > On Wed, 4 Sep 2019 15:00:52 +0530
> > Vinod Koul <vkoul@kernel.org> wrote:
> > 
> > > On 30-08-19, 11:56, Randy Dunlap wrote:
> > > > On 8/30/19 11:52 AM, Michal Suchanek wrote:  
> > > > > Fixes the following warning on !ACPI systems:
> > > > > 
> > > > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> > > > > not used [-Wunused-function]
> > > > >  static int sdw_slave_add(struct sdw_bus *bus,
> > > > >             ^~~~~~~~~~~~~
> > > > > 
> > > > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>  
> > > > 
> > > > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > > > 
> > > > I was about to send the same patch.  
> > > 
> > > So I have applied Srini's patches which add DT support and they use
> > > sdw_slave_add(). So next tomorrow should not see this error as it is now
> > > used by DT parts as well.
> > > 
> > > So dropping this patch
> > > 
> > 
> > That should fix the issue for me. I wonder if !ACPI !DT platforms are
> > still a thing.
> 
> Heh that should trigger this if we have one :D so should a lot more
> which depend on some firmware!

Actually s390x is built with !ACPI and !OF. While it supports PCI an
virtio in practice only sound devices emulated by qemu are available.
Also AFAICT the sounwire driver is useless without ACPI or OF so it
should depend on them.

Thanks

Michal

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH] soundwire: slave: Fix unused function warning on !ACPI
@ 2019-10-02  8:20           ` Michal Suchánek
  0 siblings, 0 replies; 31+ messages in thread
From: Michal Suchánek @ 2019-10-02  8:20 UTC (permalink / raw)
  To: Vinod Koul
  Cc: linux-kernel, alsa-devel, Randy Dunlap, Sanyog Kale,
	Pierre-Louis Bossart

On Wed, Sep 04, 2019 at 05:10:59PM +0530, Vinod Koul wrote:
> On 04-09-19, 12:48, Michal Suchánek wrote:
> > On Wed, 4 Sep 2019 15:00:52 +0530
> > Vinod Koul <vkoul@kernel.org> wrote:
> > 
> > > On 30-08-19, 11:56, Randy Dunlap wrote:
> > > > On 8/30/19 11:52 AM, Michal Suchanek wrote:  
> > > > > Fixes the following warning on !ACPI systems:
> > > > > 
> > > > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> > > > > not used [-Wunused-function]
> > > > >  static int sdw_slave_add(struct sdw_bus *bus,
> > > > >             ^~~~~~~~~~~~~
> > > > > 
> > > > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>  
> > > > 
> > > > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > > > 
> > > > I was about to send the same patch.  
> > > 
> > > So I have applied Srini's patches which add DT support and they use
> > > sdw_slave_add(). So next tomorrow should not see this error as it is now
> > > used by DT parts as well.
> > > 
> > > So dropping this patch
> > > 
> > 
> > That should fix the issue for me. I wonder if !ACPI !DT platforms are
> > still a thing.
> 
> Heh that should trigger this if we have one :D so should a lot more
> which depend on some firmware!

Actually s390x is built with !ACPI and !OF. While it supports PCI an
virtio in practice only sound devices emulated by qemu are available.
Also AFAICT the sounwire driver is useless without ACPI or OF so it
should depend on them.

Thanks

Michal
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 31+ messages in thread

* [PATCH 1/2] soundwire: depend on ACPI
  2019-10-02  8:20           ` [alsa-devel] " Michal Suchánek
@ 2019-10-02  8:33             ` Michal Suchanek
  -1 siblings, 0 replies; 31+ messages in thread
From: Michal Suchanek @ 2019-10-02  8:33 UTC (permalink / raw)
  To: alsa-devel
  Cc: Michal Suchanek, Vinod Koul, Sanyog Kale, Pierre-Louis Bossart,
	stable, linux-kernel

The device cannot be probed on !ACPI and gives this warning:

drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
not used [-Wunused-function]
 static int sdw_slave_add(struct sdw_bus *bus,
            ^~~~~~~~~~~~~

Fixes: 7c3cd189b86d ("soundwire: Add Master registration")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index f518273cfbe3..c73bfbaa2659 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -5,6 +5,7 @@
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
+	depends on ACPI
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 31+ messages in thread

* [alsa-devel] [PATCH 1/2] soundwire: depend on ACPI
@ 2019-10-02  8:33             ` Michal Suchanek
  0 siblings, 0 replies; 31+ messages in thread
From: Michal Suchanek @ 2019-10-02  8:33 UTC (permalink / raw)
  To: alsa-devel
  Cc: linux-kernel, stable, Pierre-Louis Bossart, Vinod Koul,
	Sanyog Kale, Michal Suchanek

The device cannot be probed on !ACPI and gives this warning:

drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
not used [-Wunused-function]
 static int sdw_slave_add(struct sdw_bus *bus,
            ^~~~~~~~~~~~~

Fixes: 7c3cd189b86d ("soundwire: Add Master registration")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index f518273cfbe3..c73bfbaa2659 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -5,6 +5,7 @@
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
+	depends on ACPI
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
-- 
2.23.0

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 31+ messages in thread

* Re: [PATCH 1/2] soundwire: depend on ACPI
  2019-10-02  8:33             ` [alsa-devel] " Michal Suchanek
@ 2019-10-02  8:36               ` Greg KH
  -1 siblings, 0 replies; 31+ messages in thread
From: Greg KH @ 2019-10-02  8:36 UTC (permalink / raw)
  To: Michal Suchanek
  Cc: alsa-devel, Vinod Koul, Sanyog Kale, Pierre-Louis Bossart,
	stable, linux-kernel

On Wed, Oct 02, 2019 at 10:33:29AM +0200, Michal Suchanek wrote:
> The device cannot be probed on !ACPI and gives this warning:
> 
> drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> not used [-Wunused-function]
>  static int sdw_slave_add(struct sdw_bus *bus,
>             ^~~~~~~~~~~~~
> 
> Fixes: 7c3cd189b86d ("soundwire: Add Master registration")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
>  drivers/soundwire/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH 1/2] soundwire: depend on ACPI
@ 2019-10-02  8:36               ` Greg KH
  0 siblings, 0 replies; 31+ messages in thread
From: Greg KH @ 2019-10-02  8:36 UTC (permalink / raw)
  To: Michal Suchanek
  Cc: alsa-devel, linux-kernel, stable, Pierre-Louis Bossart,
	Vinod Koul, Sanyog Kale

On Wed, Oct 02, 2019 at 10:33:29AM +0200, Michal Suchanek wrote:
> The device cannot be probed on !ACPI and gives this warning:
> 
> drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> not used [-Wunused-function]
>  static int sdw_slave_add(struct sdw_bus *bus,
>             ^~~~~~~~~~~~~
> 
> Fixes: 7c3cd189b86d ("soundwire: Add Master registration")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
>  drivers/soundwire/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 31+ messages in thread

* [PATCH 2/2] soundwire: depend on ACPI || OF
  2019-10-02  8:20           ` [alsa-devel] " Michal Suchánek
@ 2019-10-02  8:33             ` Michal Suchanek
  -1 siblings, 0 replies; 31+ messages in thread
From: Michal Suchanek @ 2019-10-02  8:33 UTC (permalink / raw)
  To: alsa-devel
  Cc: Michal Suchanek, Vinod Koul, Sanyog Kale, Pierre-Louis Bossart,
	stable, linux-kernel

Now devicetree is supposrted for probing sondwire as well.

Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index c73bfbaa2659..c8c80df090d1 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -5,7 +5,7 @@
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
-	depends on ACPI
+	depends on ACPI || OF
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 31+ messages in thread

* [alsa-devel] [PATCH 2/2] soundwire: depend on ACPI || OF
@ 2019-10-02  8:33             ` Michal Suchanek
  0 siblings, 0 replies; 31+ messages in thread
From: Michal Suchanek @ 2019-10-02  8:33 UTC (permalink / raw)
  To: alsa-devel
  Cc: linux-kernel, stable, Pierre-Louis Bossart, Vinod Koul,
	Sanyog Kale, Michal Suchanek

Now devicetree is supposrted for probing sondwire as well.

Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index c73bfbaa2659..c8c80df090d1 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -5,7 +5,7 @@
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
-	depends on ACPI
+	depends on ACPI || OF
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
-- 
2.23.0

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 31+ messages in thread

* Re: [PATCH 2/2] soundwire: depend on ACPI || OF
  2019-10-02  8:33             ` [alsa-devel] " Michal Suchanek
@ 2019-10-02  8:36               ` Greg KH
  -1 siblings, 0 replies; 31+ messages in thread
From: Greg KH @ 2019-10-02  8:36 UTC (permalink / raw)
  To: Michal Suchanek
  Cc: alsa-devel, Vinod Koul, Sanyog Kale, Pierre-Louis Bossart,
	stable, linux-kernel

On Wed, Oct 02, 2019 at 10:33:30AM +0200, Michal Suchanek wrote:
> Now devicetree is supposrted for probing sondwire as well.
> 
> Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
>  drivers/soundwire/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> index c73bfbaa2659..c8c80df090d1 100644
> --- a/drivers/soundwire/Kconfig
> +++ b/drivers/soundwire/Kconfig
> @@ -5,7 +5,7 @@
>  
>  menuconfig SOUNDWIRE
>  	tristate "SoundWire support"
> -	depends on ACPI
> +	depends on ACPI || OF
>  	help
>  	  SoundWire is a 2-Pin interface with data and clock line ratified
>  	  by the MIPI Alliance. SoundWire is used for transporting data
> -- 
> 2.23.0
> 


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH 2/2] soundwire: depend on ACPI || OF
@ 2019-10-02  8:36               ` Greg KH
  0 siblings, 0 replies; 31+ messages in thread
From: Greg KH @ 2019-10-02  8:36 UTC (permalink / raw)
  To: Michal Suchanek
  Cc: alsa-devel, linux-kernel, stable, Pierre-Louis Bossart,
	Vinod Koul, Sanyog Kale

On Wed, Oct 02, 2019 at 10:33:30AM +0200, Michal Suchanek wrote:
> Now devicetree is supposrted for probing sondwire as well.
> 
> Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
>  drivers/soundwire/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> index c73bfbaa2659..c8c80df090d1 100644
> --- a/drivers/soundwire/Kconfig
> +++ b/drivers/soundwire/Kconfig
> @@ -5,7 +5,7 @@
>  
>  menuconfig SOUNDWIRE
>  	tristate "SoundWire support"
> -	depends on ACPI
> +	depends on ACPI || OF
>  	help
>  	  SoundWire is a 2-Pin interface with data and clock line ratified
>  	  by the MIPI Alliance. SoundWire is used for transporting data
> -- 
> 2.23.0
> 


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH 2/2] soundwire: depend on ACPI || OF
  2019-10-02  8:33             ` [alsa-devel] " Michal Suchanek
@ 2019-10-02 16:06               ` Pierre-Louis Bossart
  -1 siblings, 0 replies; 31+ messages in thread
From: Pierre-Louis Bossart @ 2019-10-02 16:06 UTC (permalink / raw)
  To: Michal Suchanek, alsa-devel; +Cc: linux-kernel, stable, Vinod Koul, Sanyog Kale

On 10/2/19 3:33 AM, Michal Suchanek wrote:
> Now devicetree is supposrted for probing sondwire as well.

typos...

also it'd be simpler to squash the two patches together and add in the 
commit message a mention that the s390 builds without ACPI and without OF.

> 
> Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
>   drivers/soundwire/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> index c73bfbaa2659..c8c80df090d1 100644
> --- a/drivers/soundwire/Kconfig
> +++ b/drivers/soundwire/Kconfig
> @@ -5,7 +5,7 @@
>   
>   menuconfig SOUNDWIRE
>   	tristate "SoundWire support"
> -	depends on ACPI
> +	depends on ACPI || OF
>   	help
>   	  SoundWire is a 2-Pin interface with data and clock line ratified
>   	  by the MIPI Alliance. SoundWire is used for transporting data
> 


^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH 2/2] soundwire: depend on ACPI || OF
@ 2019-10-02 16:06               ` Pierre-Louis Bossart
  0 siblings, 0 replies; 31+ messages in thread
From: Pierre-Louis Bossart @ 2019-10-02 16:06 UTC (permalink / raw)
  To: Michal Suchanek, alsa-devel; +Cc: Sanyog Kale, Vinod Koul, linux-kernel, stable

On 10/2/19 3:33 AM, Michal Suchanek wrote:
> Now devicetree is supposrted for probing sondwire as well.

typos...

also it'd be simpler to squash the two patches together and add in the 
commit message a mention that the s390 builds without ACPI and without OF.

> 
> Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
>   drivers/soundwire/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> index c73bfbaa2659..c8c80df090d1 100644
> --- a/drivers/soundwire/Kconfig
> +++ b/drivers/soundwire/Kconfig
> @@ -5,7 +5,7 @@
>   
>   menuconfig SOUNDWIRE
>   	tristate "SoundWire support"
> -	depends on ACPI
> +	depends on ACPI || OF
>   	help
>   	  SoundWire is a 2-Pin interface with data and clock line ratified
>   	  by the MIPI Alliance. SoundWire is used for transporting data
> 

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH 2/2] soundwire: depend on ACPI || OF
  2019-10-02 16:06               ` Pierre-Louis Bossart
@ 2019-10-03 10:15                 ` Michal Suchánek
  -1 siblings, 0 replies; 31+ messages in thread
From: Michal Suchánek @ 2019-10-03 10:15 UTC (permalink / raw)
  To: Pierre-Louis Bossart
  Cc: alsa-devel, linux-kernel, stable, Vinod Koul, Sanyog Kale

On Wed, Oct 02, 2019 at 11:06:14AM -0500, Pierre-Louis Bossart wrote:
> On 10/2/19 3:33 AM, Michal Suchanek wrote:
> > Now devicetree is supposrted for probing sondwire as well.
> 
> typos...
> 
> also it'd be simpler to squash the two patches together and add in the

Except we have kernels with one or both of the patches these patches
fix.

> commit message a mention that the s390 builds without ACPI and without OF.
Makes sense.

Thanks

Michal
> 
> > 
> > Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > ---
> >   drivers/soundwire/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> > index c73bfbaa2659..c8c80df090d1 100644
> > --- a/drivers/soundwire/Kconfig
> > +++ b/drivers/soundwire/Kconfig
> > @@ -5,7 +5,7 @@
> >   menuconfig SOUNDWIRE
> >   	tristate "SoundWire support"
> > -	depends on ACPI
> > +	depends on ACPI || OF
> >   	help
> >   	  SoundWire is a 2-Pin interface with data and clock line ratified
> >   	  by the MIPI Alliance. SoundWire is used for transporting data
> > 
> 

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH 2/2] soundwire: depend on ACPI || OF
@ 2019-10-03 10:15                 ` Michal Suchánek
  0 siblings, 0 replies; 31+ messages in thread
From: Michal Suchánek @ 2019-10-03 10:15 UTC (permalink / raw)
  To: Pierre-Louis Bossart
  Cc: Vinod Koul, alsa-devel, linux-kernel, stable, Sanyog Kale

On Wed, Oct 02, 2019 at 11:06:14AM -0500, Pierre-Louis Bossart wrote:
> On 10/2/19 3:33 AM, Michal Suchanek wrote:
> > Now devicetree is supposrted for probing sondwire as well.
> 
> typos...
> 
> also it'd be simpler to squash the two patches together and add in the

Except we have kernels with one or both of the patches these patches
fix.

> commit message a mention that the s390 builds without ACPI and without OF.
Makes sense.

Thanks

Michal
> 
> > 
> > Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > ---
> >   drivers/soundwire/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> > index c73bfbaa2659..c8c80df090d1 100644
> > --- a/drivers/soundwire/Kconfig
> > +++ b/drivers/soundwire/Kconfig
> > @@ -5,7 +5,7 @@
> >   menuconfig SOUNDWIRE
> >   	tristate "SoundWire support"
> > -	depends on ACPI
> > +	depends on ACPI || OF
> >   	help
> >   	  SoundWire is a 2-Pin interface with data and clock line ratified
> >   	  by the MIPI Alliance. SoundWire is used for transporting data
> > 
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 31+ messages in thread

* [PATCH v2 1/2] soundwire: depend on ACPI
  2019-10-02  8:20           ` [alsa-devel] " Michal Suchánek
@ 2019-10-03 10:13             ` Michal Suchanek
  -1 siblings, 0 replies; 31+ messages in thread
From: Michal Suchanek @ 2019-10-03 10:13 UTC (permalink / raw)
  To: alsa-devel
  Cc: Michal Suchanek, Vinod Koul, Sanyog Kale, Pierre-Louis Bossart,
	linux-kernel, stable

The device cannot be probed on !ACPI and gives this warning:

drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
not used [-Wunused-function]
 static int sdw_slave_add(struct sdw_bus *bus,
            ^~~~~~~~~~~~~

Cc: stable@vger.kernel.org
Fixes: 7c3cd189b86d ("soundwire: Add Master registration")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index f518273cfbe3..c73bfbaa2659 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -5,6 +5,7 @@
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
+	depends on ACPI
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 31+ messages in thread

* [alsa-devel] [PATCH v2 1/2] soundwire: depend on ACPI
@ 2019-10-03 10:13             ` Michal Suchanek
  0 siblings, 0 replies; 31+ messages in thread
From: Michal Suchanek @ 2019-10-03 10:13 UTC (permalink / raw)
  To: alsa-devel
  Cc: linux-kernel, stable, Pierre-Louis Bossart, Vinod Koul,
	Sanyog Kale, Michal Suchanek

The device cannot be probed on !ACPI and gives this warning:

drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
not used [-Wunused-function]
 static int sdw_slave_add(struct sdw_bus *bus,
            ^~~~~~~~~~~~~

Cc: stable@vger.kernel.org
Fixes: 7c3cd189b86d ("soundwire: Add Master registration")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index f518273cfbe3..c73bfbaa2659 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -5,6 +5,7 @@
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
+	depends on ACPI
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
-- 
2.23.0

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH v2 1/2] soundwire: depend on ACPI
  2019-10-03 10:13             ` [alsa-devel] " Michal Suchanek
  (?)
@ 2019-10-06 12:07             ` Sasha Levin
  -1 siblings, 0 replies; 31+ messages in thread
From: Sasha Levin @ 2019-10-06 12:07 UTC (permalink / raw)
  To: Sasha Levin, Michal Suchanek, alsa-devel
  Cc: , Vinod Koul, Michal Suchanek, stable

Hi,

[This is an automated email]

This commit has been processed because it contains a "Fixes:" tag,
fixing commit: 7c3cd189b86d soundwire: Add Master registration.

The bot has tested the following trees: v5.3.2, v5.2.18, v4.19.76.

v5.3.2: Build OK!
v5.2.18: Failed to apply! Possible dependencies:
    8676b3ca4673 ("soundwire: fix regmap dependencies and align with other serial links")

v4.19.76: Failed to apply! Possible dependencies:
    8676b3ca4673 ("soundwire: fix regmap dependencies and align with other serial links")
    9d7cd9d50082 ("soundwire: Kconfig: fix help format")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks,
Sasha
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PATCH v2 1/2] soundwire: depend on ACPI
  2019-10-03 10:13             ` [alsa-devel] " Michal Suchanek
@ 2019-10-15 10:45               ` Vinod Koul
  -1 siblings, 0 replies; 31+ messages in thread
From: Vinod Koul @ 2019-10-15 10:45 UTC (permalink / raw)
  To: Michal Suchanek
  Cc: alsa-devel, Sanyog Kale, Pierre-Louis Bossart, linux-kernel, stable

On 03-10-19, 12:13, Michal Suchanek wrote:
> The device cannot be probed on !ACPI and gives this warning:
> 
> drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> not used [-Wunused-function]
>  static int sdw_slave_add(struct sdw_bus *bus,

Applied both, thanks
-- 
~Vinod

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [alsa-devel] [PATCH v2 1/2] soundwire: depend on ACPI
@ 2019-10-15 10:45               ` Vinod Koul
  0 siblings, 0 replies; 31+ messages in thread
From: Vinod Koul @ 2019-10-15 10:45 UTC (permalink / raw)
  To: Michal Suchanek
  Cc: linux-kernel, alsa-devel, Sanyog Kale, stable, Pierre-Louis Bossart

On 03-10-19, 12:13, Michal Suchanek wrote:
> The device cannot be probed on !ACPI and gives this warning:
> 
> drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> not used [-Wunused-function]
>  static int sdw_slave_add(struct sdw_bus *bus,

Applied both, thanks
-- 
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 31+ messages in thread

* [PATCH v2 2/2] soundwire: depend on ACPI || OF
  2019-10-02  8:20           ` [alsa-devel] " Michal Suchánek
@ 2019-10-03 10:13             ` Michal Suchanek
  -1 siblings, 0 replies; 31+ messages in thread
From: Michal Suchanek @ 2019-10-03 10:13 UTC (permalink / raw)
  To: alsa-devel
  Cc: Michal Suchanek, Vinod Koul, Sanyog Kale, Pierre-Louis Bossart,
	linux-kernel, stable

Now devicetree is supported for probing soundwire as well.

On platforms built with !ACPI !OF (ie s390x) the device still cannot be
probed and gives a build warning.

Cc: stable@vger.kernel.org
Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index c73bfbaa2659..c8c80df090d1 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -5,7 +5,7 @@
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
-	depends on ACPI
+	depends on ACPI || OF
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 31+ messages in thread

* [alsa-devel] [PATCH v2 2/2] soundwire: depend on ACPI || OF
@ 2019-10-03 10:13             ` Michal Suchanek
  0 siblings, 0 replies; 31+ messages in thread
From: Michal Suchanek @ 2019-10-03 10:13 UTC (permalink / raw)
  To: alsa-devel
  Cc: linux-kernel, stable, Pierre-Louis Bossart, Vinod Koul,
	Sanyog Kale, Michal Suchanek

Now devicetree is supported for probing soundwire as well.

On platforms built with !ACPI !OF (ie s390x) the device still cannot be
probed and gives a build warning.

Cc: stable@vger.kernel.org
Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index c73bfbaa2659..c8c80df090d1 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -5,7 +5,7 @@
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
-	depends on ACPI
+	depends on ACPI || OF
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
-- 
2.23.0

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 31+ messages in thread

end of thread, other threads:[~2019-10-15 10:46 UTC | newest]

Thread overview: 31+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-30 18:52 [PATCH] soundwire: slave: Fix unused function warning on !ACPI Michal Suchanek
2019-08-30 18:52 ` [alsa-devel] " Michal Suchanek
2019-08-30 18:56 ` Randy Dunlap
2019-08-30 18:56   ` [alsa-devel] " Randy Dunlap
2019-09-04  9:30   ` Vinod Koul
2019-09-04  9:30     ` [alsa-devel] " Vinod Koul
2019-09-04 10:48     ` Michal Suchánek
2019-09-04 10:48       ` [alsa-devel] " Michal Suchánek
2019-09-04 11:40       ` Vinod Koul
2019-09-04 11:40         ` [alsa-devel] " Vinod Koul
2019-10-02  8:20         ` Michal Suchánek
2019-10-02  8:20           ` [alsa-devel] " Michal Suchánek
2019-10-02  8:33           ` [PATCH 1/2] soundwire: depend on ACPI Michal Suchanek
2019-10-02  8:33             ` [alsa-devel] " Michal Suchanek
2019-10-02  8:36             ` Greg KH
2019-10-02  8:36               ` [alsa-devel] " Greg KH
2019-10-02  8:33           ` [PATCH 2/2] soundwire: depend on ACPI || OF Michal Suchanek
2019-10-02  8:33             ` [alsa-devel] " Michal Suchanek
2019-10-02  8:36             ` Greg KH
2019-10-02  8:36               ` [alsa-devel] " Greg KH
2019-10-02 16:06             ` Pierre-Louis Bossart
2019-10-02 16:06               ` Pierre-Louis Bossart
2019-10-03 10:15               ` Michal Suchánek
2019-10-03 10:15                 ` Michal Suchánek
2019-10-03 10:13           ` [PATCH v2 1/2] soundwire: depend on ACPI Michal Suchanek
2019-10-03 10:13             ` [alsa-devel] " Michal Suchanek
2019-10-06 12:07             ` Sasha Levin
2019-10-15 10:45             ` Vinod Koul
2019-10-15 10:45               ` [alsa-devel] " Vinod Koul
2019-10-03 10:13           ` [PATCH v2 2/2] soundwire: depend on ACPI || OF Michal Suchanek
2019-10-03 10:13             ` [alsa-devel] " Michal Suchanek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.