From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9499C35280 for ; Wed, 2 Oct 2019 10:16:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 949F020700 for ; Wed, 2 Oct 2019 10:16:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727720AbfJBKQe (ORCPT ); Wed, 2 Oct 2019 06:16:34 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:35071 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727695AbfJBKQe (ORCPT ); Wed, 2 Oct 2019 06:16:34 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iFbgI-0007V7-6C; Wed, 02 Oct 2019 12:16:26 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iFbgG-0003J6-MW; Wed, 02 Oct 2019 12:16:24 +0200 Date: Wed, 2 Oct 2019 12:16:24 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Colin King Cc: Thierry Reding , Maxime Ripard , Chen-Yu Tsai , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pwm: sun4i: redundant assignment to variable pval Message-ID: <20191002101624.gljyf7g4nia2rcbx@pengutronix.de> References: <20191002100844.10490-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191002100844.10490-1-colin.king@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 02, 2019 at 11:08:44AM +0100, Colin King wrote: > From: Colin Ian King > > Variable pval is being assigned a value that is never read. The > assignment is redundant and hence can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/pwm/pwm-sun4i.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index 6f5840a1a82d..53970d4ba695 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -156,7 +156,6 @@ static int sun4i_pwm_calculate(struct sun4i_pwm_chip *sun4i_pwm, > if (sun4i_pwm->data->has_prescaler_bypass) { > /* First, test without any prescaler when available */ > prescaler = PWM_PRESCAL_MASK; > - pval = 1; > /* > * When not using any prescaler, the clock period in nanoseconds > * is not an integer so round it half up instead of Looks fine, the issue exists since deb9c462f4e539cc7f8389b9855eb7a507c78e7e. You can even make pval a local variable for the second for loop. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Date: Wed, 02 Oct 2019 10:16:24 +0000 Subject: Re: [PATCH] pwm: sun4i: redundant assignment to variable pval Message-Id: <20191002101624.gljyf7g4nia2rcbx@pengutronix.de> List-Id: References: <20191002100844.10490-1-colin.king@canonical.com> In-Reply-To: <20191002100844.10490-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Colin King Cc: linux-pwm@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Thierry Reding , linux-arm-kernel@lists.infradead.org On Wed, Oct 02, 2019 at 11:08:44AM +0100, Colin King wrote: > From: Colin Ian King >=20 > Variable pval is being assigned a value that is never read. The > assignment is redundant and hence can be removed. >=20 > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/pwm/pwm-sun4i.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index 6f5840a1a82d..53970d4ba695 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -156,7 +156,6 @@ static int sun4i_pwm_calculate(struct sun4i_pwm_chip = *sun4i_pwm, > if (sun4i_pwm->data->has_prescaler_bypass) { > /* First, test without any prescaler when available */ > prescaler =3D PWM_PRESCAL_MASK; > - pval =3D 1; > /* > * When not using any prescaler, the clock period in nanoseconds > * is not an integer so round it half up instead of Looks fine, the issue exists since deb9c462f4e539cc7f8389b9855eb7a507c78e7e. You can even make pval a local variable for the second for loop. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5179C352AA for ; Wed, 2 Oct 2019 10:16:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5C8F20700 for ; Wed, 2 Oct 2019 10:16:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Cl+dxpzR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5C8F20700 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZbaeMWDcc5MJYUQrqjDMUAs+t8tn3unmPyUFjbhX3NI=; b=Cl+dxpzRwOQNhS FQnBp29z3krZJgvDPghRujO0lVbGMNVG+MpuEOnYmMzxDVNEomTRUhho5lkhvP/44Ju5nUvRgaE36 /pBnhvLBKV46gWO5vlmL7HfCCghF3sfO7hYpfic6Cyp8Z4JQjTAYpXDj4st8/zmFop4S+n05E5BEH JZs7FTewBj7Bua7023JVivfmQoyeo1enkMyNd3VISj1OjxaMa6tLAKvQ5bFb6cEph9TmzRl7B8ynt npNkaZn9sD+xV/7xLHQwxh08rTxLz4Aizq7cJQSXYalxZaLonZGQB/Ye24pRd4HUZcG8E/jooV6GJ Iog0V0cTHaqOiDpVbSkA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFbgQ-0002ov-Gv; Wed, 02 Oct 2019 10:16:34 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFbgM-0002oV-KK for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2019 10:16:32 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iFbgI-0007V7-6C; Wed, 02 Oct 2019 12:16:26 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iFbgG-0003J6-MW; Wed, 02 Oct 2019 12:16:24 +0200 Date: Wed, 2 Oct 2019 12:16:24 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Colin King Subject: Re: [PATCH] pwm: sun4i: redundant assignment to variable pval Message-ID: <20191002101624.gljyf7g4nia2rcbx@pengutronix.de> References: <20191002100844.10490-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191002100844.10490-1-colin.king@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191002_031630_664264_9020A6A1 X-CRM114-Status: GOOD ( 14.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Thierry Reding , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 02, 2019 at 11:08:44AM +0100, Colin King wrote: > From: Colin Ian King > = > Variable pval is being assigned a value that is never read. The > assignment is redundant and hence can be removed. > = > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/pwm/pwm-sun4i.c | 1 - > 1 file changed, 1 deletion(-) > = > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index 6f5840a1a82d..53970d4ba695 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -156,7 +156,6 @@ static int sun4i_pwm_calculate(struct sun4i_pwm_chip = *sun4i_pwm, > if (sun4i_pwm->data->has_prescaler_bypass) { > /* First, test without any prescaler when available */ > prescaler =3D PWM_PRESCAL_MASK; > - pval =3D 1; > /* > * When not using any prescaler, the clock period in nanoseconds > * is not an integer so round it half up instead of Looks fine, the issue exists since deb9c462f4e539cc7f8389b9855eb7a507c78e7e. You can even make pval a local variable for the second for loop. Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel