All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] trace-cmd: Add initial infrastructure for trace-cmd specific plugins.
Date: Wed, 2 Oct 2019 20:12:29 -0400	[thread overview]
Message-ID: <20191002201229.1b96751a@gandalf.local.home> (raw)
In-Reply-To: <20191002114152.30048-6-tz.stoyanov@gmail.com>

On Wed,  2 Oct 2019 14:41:52 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:

>  
> -$(LIBTRACEEVENT_SHARED): force $(obj)/lib/traceevent/plugins/traceevent_plugin_dir
> +$(LIBTRACEEVENT_SHARED): force $(obj)/lib/traceevent/plugins/python_dir \
> +			 $(obj)/lib/traceevent/plugins/traceevent_plugin_dir
>  	$(Q)$(MAKE) -C $(src)/lib/traceevent $@
>  
> -$(LIBTRACEEVENT_STATIC): force $(obj)/lib/traceevent/plugins/traceevent_plugin_dir
> +$(LIBTRACEEVENT_STATIC): force $(obj)/lib/traceevent/plugins/python_dir \
> +			 $(obj)/lib/traceevent/plugins/traceevent_plugin_dir
>  	$(Q)$(MAKE) -C $(src)/lib/traceevent $@
>  
>  $(LIBTRACECMD_STATIC): force
> @@ -290,13 +301,22 @@ libtracecmd.so: $(LIBTRACECMD_SHARED)
>  
>  libs: $(LIBTRACECMD_SHARED) $(LIBTRACEEVENT_SHARED)
>  
> -plugins: force $(obj)/lib/traceevent/plugins/traceevent_plugin_dir $(obj)/lib/traceevent/plugins/trace_python_dir
> +plugins_traceevent: force $(obj)/lib/traceevent/plugins/traceevent_plugin_dir \
> +		   $(obj)/lib/traceevent/plugins/python_dir
>  	$(Q)$(MAKE) -C $(src)/lib/traceevent/plugins
>  

Hmm, I'm getting this:

$ make
make[1]: *** No rule to make target '/work/git/trace-cmd.git/lib/traceevent/plugins/python_dir'.  Stop.
make: *** [Makefile:320: /work/git/trace-cmd.git/lib/traceevent/plugins/python_dir] Error 2

It works if I manually create the missing python_dir.

-- Steve

      reply	other threads:[~2019-10-03  0:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 11:41 [PATCH v3 0/5] Remove redundant trace-cmd plugin handling logic Tzvetomir Stoyanov (VMware)
2019-10-02 11:41 ` [PATCH v3 1/5] trace-cmd: Move libtraceevent plugins in its own directory Tzvetomir Stoyanov (VMware)
2019-10-02 11:41 ` [PATCH v3 2/5] trace-cmd: Rename plugin_python to plugin_python_loader Tzvetomir Stoyanov (VMware)
2019-10-02 11:41 ` [PATCH v3 3/5] trace-cmd: Load libtraceevent plugins from build folder, if exists Tzvetomir Stoyanov (VMware)
2019-10-02 23:49   ` Steven Rostedt
2019-10-04  8:32     ` Tzvetomir Stoyanov
2019-10-03  0:01   ` Steven Rostedt
2019-10-02 11:41 ` [PATCH v3 4/5] trace-cmd: Change plugin install directories Tzvetomir Stoyanov (VMware)
2019-10-02 11:41 ` [PATCH v3 5/5] trace-cmd: Add initial infrastructure for trace-cmd specific plugins Tzvetomir Stoyanov (VMware)
2019-10-03  0:12   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191002201229.1b96751a@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.