From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A97DC32792 for ; Thu, 3 Oct 2019 15:57:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E7F0222C2 for ; Thu, 3 Oct 2019 15:57:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118236; bh=74yDVWR/ILsO2aE70U+M2wJKsF551xYFuOmbv1Er/4I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oElUfJy+sXBD9X+Nage1W7rLAjb6/7doLnD+302DhdFZdlMfiliXnsYO7gOZvIplo kMaZxQjKJsJnrZWNiVoRBUyQP+Gl5cj3HBgMymzFDCLClCTJXyiUM9WwteQdlx3Sga RRCU0Q36WMR4VZ1Xz3MrqzN0bOgyU1GNKXREj/X0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730914AbfJCP5P (ORCPT ); Thu, 3 Oct 2019 11:57:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:39574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730895AbfJCP5O (ORCPT ); Thu, 3 Oct 2019 11:57:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E8D50207FF; Thu, 3 Oct 2019 15:57:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118233; bh=74yDVWR/ILsO2aE70U+M2wJKsF551xYFuOmbv1Er/4I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WFvxC6UMLP5nBLRqIL6rsZIrcSMq5qi1eYiDBXMAD6S7stc20aLqzdZi0HSBKCDfp NOo43vgI1JWGfT3cNDyWmsIiMKWbq2lUYeC92nhK6Y67K930brTwhOpTNnSTrdcFys xFGYmugVZS4VF4dDe2VPRgi9BPeRHY+GSQbr+v1g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nick Stoughton , Pavel Machek , Jacek Anaszewski , Sasha Levin Subject: [PATCH 4.4 36/99] leds: leds-lp5562 allow firmware files up to the maximum length Date: Thu, 3 Oct 2019 17:52:59 +0200 Message-Id: <20191003154312.340633690@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154252.297991283@linuxfoundation.org> References: <20191003154252.297991283@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nick Stoughton [ Upstream commit ed2abfebb041473092b41527903f93390d38afa7 ] Firmware files are in ASCII, using 2 hex characters per byte. The maximum length of a firmware string is therefore 16 (commands) * 2 (bytes per command) * 2 (characters per byte) = 64 Fixes: ff45262a85db ("leds: add new LP5562 LED driver") Signed-off-by: Nick Stoughton Acked-by: Pavel Machek Signed-off-by: Jacek Anaszewski Signed-off-by: Sasha Levin --- drivers/leds/leds-lp5562.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c index 0360c59dbdc91..fc8b2e7bcfef6 100644 --- a/drivers/leds/leds-lp5562.c +++ b/drivers/leds/leds-lp5562.c @@ -263,7 +263,11 @@ static void lp5562_firmware_loaded(struct lp55xx_chip *chip) { const struct firmware *fw = chip->fw; - if (fw->size > LP5562_PROGRAM_LENGTH) { + /* + * the firmware is encoded in ascii hex character, with 2 chars + * per byte + */ + if (fw->size > (LP5562_PROGRAM_LENGTH * 2)) { dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n", fw->size); return; -- 2.20.1