From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06635C32792 for ; Thu, 3 Oct 2019 15:58:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6C9F21A4C for ; Thu, 3 Oct 2019 15:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118297; bh=22NbU2ULCWVXqeZj+g5k5KVDG+WB3nR9I3dWlexGVM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oGt4B20aSBCY/AC6krKd4GGHVHR3lQy1VCxUt80U3io4vbj4YexzrlojfK5Peday/ zETzFbUbR8zLJEX5UYphqmU/evThRc0lBfTWez//Tgz+qxRmNG2GVD8zWPWDCC5e4R UPMqnK+JJDiJWGt9ZFz2lQHbK+8Zp9Z+hei9MHa0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729087AbfJCP6R (ORCPT ); Thu, 3 Oct 2019 11:58:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:40820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730000AbfJCP6J (ORCPT ); Thu, 3 Oct 2019 11:58:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B351F20700; Thu, 3 Oct 2019 15:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118289; bh=22NbU2ULCWVXqeZj+g5k5KVDG+WB3nR9I3dWlexGVM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=loeaSyaI54hGF+4BsnTj0v2Dsjc3FPY4Tv+eRhLixIiQ5tF+WBND1w7mqJqMEHp3H Ctl6KbRk8HCmYlS+ATdTncYCS+LRBV9bXftX6Nl/rWU0oANCQDdrmhrbxutV5HNvlh 2XYd080d3XNuchIqLmMiIcqhVP2LiEm/OdANNZdw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 58/99] media: saa7146: add cleanup in hexium_attach() Date: Thu, 3 Oct 2019 17:53:21 +0200 Message-Id: <20191003154323.924349672@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154252.297991283@linuxfoundation.org> References: <20191003154252.297991283@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenwen Wang [ Upstream commit 42e64117d3b4a759013f77bbcf25ab6700e55de7 ] If saa7146_register_device() fails, no cleanup is executed, leading to memory/resource leaks. To fix this issue, perform necessary cleanup work before returning the error. Signed-off-by: Wenwen Wang Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/saa7146/hexium_gemini.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/pci/saa7146/hexium_gemini.c b/drivers/media/pci/saa7146/hexium_gemini.c index d4b3ce8282856..343cd75fcd8d1 100644 --- a/drivers/media/pci/saa7146/hexium_gemini.c +++ b/drivers/media/pci/saa7146/hexium_gemini.c @@ -304,6 +304,9 @@ static int hexium_attach(struct saa7146_dev *dev, struct saa7146_pci_extension_d ret = saa7146_register_device(&hexium->video_dev, dev, "hexium gemini", VFL_TYPE_GRABBER); if (ret < 0) { pr_err("cannot register capture v4l2 device. skipping.\n"); + saa7146_vv_release(dev); + i2c_del_adapter(&hexium->i2c_adapter); + kfree(hexium); return ret; } -- 2.20.1