From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25712C4CED1 for ; Thu, 3 Oct 2019 16:10:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E177020865 for ; Thu, 3 Oct 2019 16:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119013; bh=e0OsJVXdRup6T509mAuK/fbZ1RieDXJfxSYWGYLNNhw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=AYAqWkfRy8+bCAMXop4LRVvtrQ2DlZPw3M8KxrTkQg/u322/4/Z17euzWoBQZXZpo 6BRsSLw37Aop5y2bDZR3XFNiH/b3epXLxCrIyZ223HKPz5SXeyrSQzbaamnCWnLDwS h8gXY5bdR1JbY436teWIFD4ImMCDVazJc1by9rbs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731370AbfJCQKL (ORCPT ); Thu, 3 Oct 2019 12:10:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:59302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732251AbfJCQKI (ORCPT ); Thu, 3 Oct 2019 12:10:08 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B43D21848; Thu, 3 Oct 2019 16:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119007; bh=e0OsJVXdRup6T509mAuK/fbZ1RieDXJfxSYWGYLNNhw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hGot3dzNYyRdNEutHiTJ26Mh1+53gv1Nf75UsGrAxavHeKYuOH4VDztD6vs9gqmwL 1Z8U+DELwA3awlkTJe+2FJXKPAn/eJKXSpTRbSStPjv0owgt1EFHqMUHow8Nb4Hunz 9WCDuzIf/7oeC0Xiw5Yy04MTyz9wQFsE8eMUkqEE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 092/185] media: omap3isp: Dont set streaming state on random subdevs Date: Thu, 3 Oct 2019 17:52:50 +0200 Message-Id: <20191003154459.161016085@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154437.541662648@linuxfoundation.org> References: <20191003154437.541662648@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sakari Ailus [ Upstream commit 7ef57be07ac146e70535747797ef4aee0f06e9f9 ] The streaming state should be set to the first upstream sub-device only, not everywhere, for a sub-device driver itself knows how to best control the streaming state of its own upstream sub-devices. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/omap3isp/isp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index c834fea5f9b00..b34b6a604f92f 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -727,6 +727,10 @@ static int isp_pipeline_enable(struct isp_pipeline *pipe, s_stream, mode); pipe->do_propagation = true; } + + /* Stop at the first external sub-device. */ + if (subdev->dev != isp->dev) + break; } return 0; @@ -841,6 +845,10 @@ static int isp_pipeline_disable(struct isp_pipeline *pipe) &subdev->entity); failure = -ETIMEDOUT; } + + /* Stop at the first external sub-device. */ + if (subdev->dev != isp->dev) + break; } return failure; -- 2.20.1