From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43025C32792 for ; Thu, 3 Oct 2019 16:10:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F065222C8 for ; Thu, 3 Oct 2019 16:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119031; bh=BmCxRh3AFZo6roUst32OqGMBUYL85uQbOxwAP4cI02Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TwbKOUcjWgtzNxFvUtt7kDAf+mxJt5lviXsikj2ObRH5geO4vefcEHADCeyTeL8rg FRKZpNCzgOgoZwc4eynT/0pwIEb+xwwSeLH5xbKQSEtzT/MF0fb5zZNCPdzS3e53Lg sFqg04+uLXimdPLNJbS2Jm6kfjwaXieDCEjY9jHk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387657AbfJCQKa (ORCPT ); Thu, 3 Oct 2019 12:10:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:59852 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387637AbfJCQK1 (ORCPT ); Thu, 3 Oct 2019 12:10:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D19FD215EA; Thu, 3 Oct 2019 16:10:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119026; bh=BmCxRh3AFZo6roUst32OqGMBUYL85uQbOxwAP4cI02Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lHQcf8bFOdZZmxTLvcWPAN41GCLLvS5XCFZnXMgEvpZ6OslTNx67zj0L0BmAsyYR1 2zWvXwXZF76neMlCF3w4395zIqXIbKOpWNpZ7U5hxbdwISBnK0+mEjMy7T6kS6HC1i VOqyLwAUXbIkFizatYgUJJt0Pg4FR9XaXmhKZjiY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 099/185] media: dvb-core: fix a memory leak bug Date: Thu, 3 Oct 2019 17:52:57 +0200 Message-Id: <20191003154501.005669722@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154437.541662648@linuxfoundation.org> References: <20191003154437.541662648@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenwen Wang [ Upstream commit fcd5ce4b3936242e6679875a4d3c3acfc8743e15 ] In dvb_create_media_entity(), 'dvbdev->entity' is allocated through kzalloc(). Then, 'dvbdev->pads' is allocated through kcalloc(). However, if kcalloc() fails, the allocated 'dvbdev->entity' is not deallocated, leading to a memory leak bug. To fix this issue, free 'dvbdev->entity' before returning -ENOMEM. Signed-off-by: Wenwen Wang Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/dvb-core/dvbdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c index 41aad0f99d73c..ba3c68fb9676b 100644 --- a/drivers/media/dvb-core/dvbdev.c +++ b/drivers/media/dvb-core/dvbdev.c @@ -316,8 +316,10 @@ static int dvb_create_media_entity(struct dvb_device *dvbdev, if (npads) { dvbdev->pads = kcalloc(npads, sizeof(*dvbdev->pads), GFP_KERNEL); - if (!dvbdev->pads) + if (!dvbdev->pads) { + kfree(dvbdev->entity); return -ENOMEM; + } } switch (type) { -- 2.20.1