From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44889C10F14 for ; Thu, 3 Oct 2019 17:30:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19EAF20830 for ; Thu, 3 Oct 2019 17:30:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570123858; bh=wNr6pegQhACiQ4qzoUw117XMXI00XuVxmvoZN5YDoVM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=l4TY5hbetY0PATqstIQ91WJLPc6AgJIWfGo/4Wnf7gJD9M+MJsqad+mtlRgck0/S5 gzfJBuKre1Q6KRUbjwwwx/RqN1V+sEtZZz3E3rxjOPbIcZ4lWhf9NC2XRkUXesLn6a MFtRU5k5Uof5nlzUmOVbnKOnV5RIAxi17wV8fPc0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731515AbfJCRa4 (ORCPT ); Thu, 3 Oct 2019 13:30:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:60372 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730776AbfJCQKs (ORCPT ); Thu, 3 Oct 2019 12:10:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 290E020865; Thu, 3 Oct 2019 16:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119047; bh=wNr6pegQhACiQ4qzoUw117XMXI00XuVxmvoZN5YDoVM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N85YpfA7kJz17bmDrXS2pALRrN8V57Hio7xYDffJLDmi/98v4D+4Vzvp3OiYr3rfy ykJ9JDZk7O4Ij6zbfJsUBz931mjvpLtMGOyS6XP92iXUcy0vZMguTBFp46M1zZigW4 WPW6Wo4wzKUlU7JgKVy4poqDB34CPrwqYMyiH80g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 106/185] media: saa7146: add cleanup in hexium_attach() Date: Thu, 3 Oct 2019 17:53:04 +0200 Message-Id: <20191003154502.905323119@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154437.541662648@linuxfoundation.org> References: <20191003154437.541662648@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenwen Wang [ Upstream commit 42e64117d3b4a759013f77bbcf25ab6700e55de7 ] If saa7146_register_device() fails, no cleanup is executed, leading to memory/resource leaks. To fix this issue, perform necessary cleanup work before returning the error. Signed-off-by: Wenwen Wang Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/saa7146/hexium_gemini.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/pci/saa7146/hexium_gemini.c b/drivers/media/pci/saa7146/hexium_gemini.c index 934332f1fd8e6..a527d86b93a77 100644 --- a/drivers/media/pci/saa7146/hexium_gemini.c +++ b/drivers/media/pci/saa7146/hexium_gemini.c @@ -304,6 +304,9 @@ static int hexium_attach(struct saa7146_dev *dev, struct saa7146_pci_extension_d ret = saa7146_register_device(&hexium->video_dev, dev, "hexium gemini", VFL_TYPE_GRABBER); if (ret < 0) { pr_err("cannot register capture v4l2 device. skipping.\n"); + saa7146_vv_release(dev); + i2c_del_adapter(&hexium->i2c_adapter); + kfree(hexium); return ret; } -- 2.20.1